From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36669C74A5B for ; Tue, 21 Mar 2023 10:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aTeFoNygK5hvUll8c7G96tsAGfIBhmZOCQB564UOz0Q=; b=cZ307PilobP6J6 FSDKu8BOrP0D4X8k9q+tqE4cY1EBx+4SBupQr0gG430bhuUAGf4uGFI94driM+pFkPOnE8pSNxGrS Hg9cYZEIRlGmiqPGBsZrVAf8m8AGHqcneCWf3L4MDrqoaC3a+KRIfnR14Hls8Jl+Adze8Tq7+oU1H 1ZPICUa8+KwfhiSRheKJs033iCYjC+8+umqF7BPb6hUQCGZEsYHCe80Arm43pAkRE1GvO0C/V/SbM f0XL7vD4t4+81l8FCyjaJ8Fkbz8AHmH4M26W3iYG7N//xg3yDSAMnSQhLce/JlnqKPStfsFOzqjTO 5I/fr6K8ovOoX3G5PpPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peYuz-00ByUh-1Y; Tue, 21 Mar 2023 10:08:37 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peYuv-00ByTO-1M for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 10:08:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1679393313; x=1710929313; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=adF2aNaNl3IWC5s2kzUM/m6VZW5aUO+RIufl4f2rZbs=; b=avKWTvfk1ejlHpPUL28mO6adckpFaY5gpHwWjeT71W4bQjqX+N2h4oS6 LBsdVKxasB5dAdnaCNe014JfWLgkq7keuxnsFlRW67TDDxq/HG32Rp+3V HAeVD0AVvs93GGH93HZ6PU/+Cn3xmMRUfau/faUYUPGoHsq048XZDWjLD tH8tFzyu6UhNv7y37leTEL53lj2yoz9avkHnoWvjXiv+qtCY/DCPxG5mJ xo7ZzBlG+csLW4OW8BMybxjRz2JbdFA2fM7SGFzaF9jAbDSqsgJ+ZTGx0 jWSzYjfDnPAKLs9yyh3y/4jaMRVEBMlveySUjsYuJ9fK8GHwuOIlWaPNs A==; X-IronPort-AV: E=Sophos;i="5.98,278,1673910000"; d="scan'208";a="29826595" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 21 Mar 2023 11:08:29 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 21 Mar 2023 11:08:29 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 21 Mar 2023 11:08:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1679393309; x=1710929309; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=adF2aNaNl3IWC5s2kzUM/m6VZW5aUO+RIufl4f2rZbs=; b=V4OIIX6jiAFg0TYZTrCsmSH6fRc5htVE+7IbNZkkn1bfMVqBqkCY4yc3 wqt6mGVwWZlhwedLu3UpPDoPNqbwf0vTKPyx3Ce44MmNB5F7cKD9hhEIG 2tnM8TFkL1o/U/E1Qe/NRAYvNnIxASAqrZgSfZRJXeJh89oVvRVPXUX9H 3bBHRIDxeJ/xt1A7Y+X3aCiT9l7MksMX1k9AJwqt7FGdxODDLD90QobPa +S0PkkdZ9Lrs0YtTldX589Byr/seHcNKKO0s9OjNSe8sWc2o8nGtOly+1 6sjxnt6n2avTQ/3oBhQdrN08RHhJtCqLrPjo2TxiP6usejs/rCijYsBrR Q==; X-IronPort-AV: E=Sophos;i="5.98,278,1673910000"; d="scan'208";a="29826594" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 21 Mar 2023 11:08:29 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 7FCEB280056; Tue, 21 Mar 2023 11:08:29 +0100 (CET) From: Alexander Stein To: Laurent Pinchart Cc: Rui Miguel Silva , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] media: imx: imx7-media-csi: Fix mbus framefmt field init Date: Tue, 21 Mar 2023 11:08:27 +0100 Message-ID: <2884312.e9J7NaK4W3@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230321093757.GZ20234@pendragon.ideasonboard.com> References: <20230321072707.678039-1-alexander.stein@ew.tq-group.com> <20230321072707.678039-2-alexander.stein@ew.tq-group.com> <20230321093757.GZ20234@pendragon.ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_030833_974162_2E735BC3 X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Am Dienstag, 21. M=E4rz 2023, 10:37:57 CET schrieb Laurent Pinchart: > Hi Alexander, > = > Thank you for the patch. > = > On Tue, Mar 21, 2023 at 08:27:06AM +0100, Alexander Stein wrote: > > 'field' is zero-initialized to V4L2_FIELD_ANY, which is an invalid value > > to return to userspace. Instead fefault to non-interleaving. > = > I prefer defaulting to non-interleaving instead of fefaulting :-) I'll > fix the typo in my tree. Oh :-) thanks for fixing this. Best regards, Alexander > > Signed-off-by: Alexander Stein > = > Reviewed-by: Laurent Pinchart > = > > --- > > = > > drivers/media/platform/nxp/imx7-media-csi.c | 1 + > > 1 file changed, 1 insertion(+) > > = > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c > > b/drivers/media/platform/nxp/imx7-media-csi.c index > > c22bf5c827e7..3e97b9f2ff69 100644 > > --- a/drivers/media/platform/nxp/imx7-media-csi.c > > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > > @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct > > imx7_csi *csi)> = > > format.code =3D IMX7_CSI_DEF_MBUS_CODE; > > format.width =3D IMX7_CSI_DEF_PIX_WIDTH; > > format.height =3D IMX7_CSI_DEF_PIX_HEIGHT; > > = > > + format.field =3D V4L2_FIELD_NONE; > > = > > imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL); > > csi->vdev_compose.width =3D format.width; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel