public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cns3xxx: fix allmodconfig panic in pci driver
Date: Wed, 03 Sep 2014 15:27:30 +0200	[thread overview]
Message-ID: <2886818.zPBP0DOepO@wuerfel> (raw)
In-Reply-To: <1409750292-24105-1-git-send-email-kaixu.xia@linaro.org>

On Wednesday 03 September 2014 21:18:12 Xia Kaixu wrote:
> From: Xia Kaixu <kaixu.xia@linaro.org>
> 
> The kernel panic occurs when running an allmodconfig kernel on 
> OMAP4460. The inicall "cns3xxx_pcie_init" does not check which
> hardware it's running on and just tries to access to its specific 
> registers. Now call it from .init_late callback from the two
> machine descriptors.
> 
> Signed-off-by: Xia Kaixu <kaixu.xia@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Anton Vorontsov <anton@enomsg.org>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: Imre Kaloz <kaloz@openwrt.org>
> Cc: linaro-kernel at lists.linaro.org
> Cc: linux-arm-kernel at lists.infradead.org

Hi Kaixu,

it seems this time all the Cc's worked. One thing I just noticed is that
you confused the 'Signed-off-by' lines. I did look at the patch earlier
before you sent it out but unfortunately missed that.

You can read again in Documentation/SubmittingPatches about how
they work, but the short version is that you must never put someone
else's name in Signed-off-by under a patch you write yourself.
When we apply the patch, I (or whoever else does) will put that
line below yours to document who handled the patch.

Otherwise, the patch looks good to me, thanks a lot for doing it.

	Arnd

  reply	other threads:[~2014-09-03 13:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <kaixu.xia@linaro.org>
2014-09-03 13:18 ` [PATCH] ARM: cns3xxx: fix allmodconfig panic in pci driver Xia Kaixu
2014-09-03 13:27   ` Arnd Bergmann [this message]
2014-09-04  3:46     ` xiakaixu
2014-09-04 20:32   ` Arnd Bergmann
2014-09-04 21:42   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2886818.zPBP0DOepO@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox