From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59EDC10F27 for ; Mon, 9 Mar 2020 10:39:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7845720674 for ; Mon, 9 Mar 2020 10:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TZLpBkMP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="G6+lcIPL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7845720674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h0DQHr7g+DzICafV7U5JxxSuEMzCxkA5uaLeEqYycpA=; b=TZLpBkMP3xEz1H LX7cmGlweY35YRrOEnl8EcxJB0c2UMAyyKDIweYa19m8YrQGFctMZ9Rjbh8KD2xiYHXySzKy3cqqB bbWK4OkcSl8lpA5zdkP1CsA+BGg0xmQp8jLM073ZoISO9irL+BQFgIBE+CiCnAOr+iHBLggT8+sQM ML6MGoMtskLveBtLaufpmkY3nd8Yg4R0BIwZarsb4x/FJN1248ohAAqZpASSlPu3iWc1l1QCYgjc/ 0F9Ubf8jl+qstPMCpZc8DCR8cRuwoaveGZXuqVtJnNDJjsAhF5YsBIfIBizKHjTgiJiYTdrrhNNUC kyqkkpgLgzkXQqy5BE0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBFp6-0001S1-1M; Mon, 09 Mar 2020 10:39:48 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBFp2-0001RB-I2 for linux-arm-kernel@lists.infradead.org; Mon, 09 Mar 2020 10:39:46 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 029AScac025793; Mon, 9 Mar 2020 11:39:37 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=iqtz+8jVUcIa98vBWaQrx9xYUGQQ4Q8iCdRJjvFbN7g=; b=G6+lcIPLfe/fl3LP3qkR7/r+NE9RTxcXW7XSciIUVUQSJK3eE9FScRHwmTpU5LH1/sVJ 2RyQ/++eefGINPkMcxZeB86JDPwRqhBF1jxYqFag5ePmd04XpK04F8pYOfiBqzAIei0h jr6i1PCprE/vHVfsajmuVXlb/lfOUiu18r7n0EEABc4zJp2WqPTCQhh5Z5Cv1g3drOwy VIXy8OkskezCz1fbFhoUJwp9FfOJ2eEWNvG3T1EilpM3tkGqnLZKpJYR+jxt0ySQjlXC FJEkVp1/YA15p8ghk3FyltBAr1//TZ7LGj06u/HP1/+BFfXg198qs6rQeO9koPoSgY0q IQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2ym2923gbu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Mar 2020 11:39:37 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8235A100034; Mon, 9 Mar 2020 11:39:33 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag5node3.st.com [10.75.127.15]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5112E2AE6B7; Mon, 9 Mar 2020 11:39:33 +0100 (CET) Received: from [10.48.0.71] (10.75.127.46) by SFHDAG5NODE3.st.com (10.75.127.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 9 Mar 2020 11:39:32 +0100 Subject: Re: [PATCH v2] iio: adc: stm32-adc: fix sleep in atomic context To: Olivier Moysan , , , , , , References: <20200309100212.16499-1-olivier.moysan@st.com> From: Fabrice Gasnier Message-ID: <288fb604-16c6-da52-533f-7f1440ed9daa@st.com> Date: Mon, 9 Mar 2020 11:39:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200309100212.16499-1-olivier.moysan@st.com> Content-Language: en-US X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG4NODE2.st.com (10.75.127.11) To SFHDAG5NODE3.st.com (10.75.127.15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-09_02:2020-03-08, 2020-03-09 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200309_033944_899132_018E5C99 X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/9/20 11:02 AM, Olivier Moysan wrote: > This commit fixes the following error: > "BUG: sleeping function called from invalid context at kernel/irq/chip.c" > > In DMA mode suppress the trigger irq handler, and make the buffer > transfers directly in DMA callback, instead. > > Fixes: 2763ea0585c9 ("iio: adc: stm32: add optional dma support") > > Signed-off-by: Olivier Moysan Hi Olivier, Acked-by: Fabrice Gasnier Thanks, Fabrice > --- > Changes in v2: > - Add "Fixes" tag in commit message > > This solution has been already discussed in the thread > https://lkml.org/lkml/2019/3/30/171, and applied in STM32 DFSDM driver: > e19ac9d9a978 ("iio: adc: stm32-dfsdm: fix sleep in atomic context") > --- > drivers/iio/adc/stm32-adc.c | 31 ++++++++++++++++++++++++++++--- > 1 file changed, 28 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c > index 80c3f963527b..ae622ee6d08c 100644 > --- a/drivers/iio/adc/stm32-adc.c > +++ b/drivers/iio/adc/stm32-adc.c > @@ -1418,8 +1418,30 @@ static unsigned int stm32_adc_dma_residue(struct stm32_adc *adc) > static void stm32_adc_dma_buffer_done(void *data) > { > struct iio_dev *indio_dev = data; > + struct stm32_adc *adc = iio_priv(indio_dev); > + int residue = stm32_adc_dma_residue(adc); > + > + /* > + * In DMA mode the trigger services of IIO are not used > + * (e.g. no call to iio_trigger_poll). > + * Calling irq handler associated to the hardware trigger is not > + * relevant as the conversions have already been done. Data > + * transfers are performed directly in DMA callback instead. > + * This implementation avoids to call trigger irq handler that > + * may sleep, in an atomic context (DMA irq handler context). > + */ > + dev_dbg(&indio_dev->dev, "%s bufi=%d\n", __func__, adc->bufi); > > - iio_trigger_poll_chained(indio_dev->trig); > + while (residue >= indio_dev->scan_bytes) { > + u16 *buffer = (u16 *)&adc->rx_buf[adc->bufi]; > + > + iio_push_to_buffers(indio_dev, buffer); > + > + residue -= indio_dev->scan_bytes; > + adc->bufi += indio_dev->scan_bytes; > + if (adc->bufi >= adc->rx_buf_sz) > + adc->bufi = 0; > + } > } > > static int stm32_adc_dma_start(struct iio_dev *indio_dev) > @@ -1845,6 +1867,7 @@ static int stm32_adc_probe(struct platform_device *pdev) > { > struct iio_dev *indio_dev; > struct device *dev = &pdev->dev; > + irqreturn_t (*handler)(int irq, void *p) = NULL; > struct stm32_adc *adc; > int ret; > > @@ -1911,9 +1934,11 @@ static int stm32_adc_probe(struct platform_device *pdev) > if (ret < 0) > return ret; > > + if (!adc->dma_chan) > + handler = &stm32_adc_trigger_handler; > + > ret = iio_triggered_buffer_setup(indio_dev, > - &iio_pollfunc_store_time, > - &stm32_adc_trigger_handler, > + &iio_pollfunc_store_time, handler, > &stm32_adc_buffer_setup_ops); > if (ret) { > dev_err(&pdev->dev, "buffer setup failed\n"); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel