From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 696BFC54E60 for ; Tue, 19 Mar 2024 06:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UKVNfWsK9OIvCX6HWG2/MJJuXdiSWYflw2c7bzRrnFQ=; b=hk2OXC2xW5ZMR+ 1R4FFFactlofHTNQt8GfsIXE89OvQmnwL1ihAVyPdufmE1tZFgLDaC3PWXuVjQ4zQ/adDfXrrQVBW nUJImLfTic9kUJN/fzAeMntaG8Z+OKVz3f4h750dvFwSjTLHLdfLU0o7q6QKFN+xb781Vx7U/TOKW mIKy7KwFQwj0olxl1JfcasdG3Kef6th7hAmv5SfwsH5XWw/nHRbC6xD87lAJfKV1ZLIYdutlqEGAc zeg2AJe9WswzcD65JWFCt4BsObd9VE2tCtXpVji4mVvV3qBw8TX4togpMv68gLrDRBSoUUQN/+Xtm tSd15BA2xAZ/PcgypluA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTRb-0000000BbHZ-32TG; Tue, 19 Mar 2024 06:59:31 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTRY-0000000BbGx-1bsW for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 06:59:30 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1dee5daa236so34610555ad.0 for ; Mon, 18 Mar 2024 23:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710831567; x=1711436367; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sMcKfZi1xz5eaYp9NuQfLHyNEpRw2+4mgzvyh4Nj45M=; b=cd8MoFyLxuRa5Nk7O139u9rfB/g5aGTeIfhxa7i9a6Ex6GInXVG70tBh61HnqjCsVi ct25jDqdyLbIL13KHxQwuCYcwSu6nznNi5z/RRLJJzTZkpm8SI40rXdhJIvxVhlD6ONy evSzZuIcdrfJ2BGyDyV+ztFEgLHbUDCvafh2FBCSO6YkJnrRG82mnTSCPHYzbePVuwnA v/h+dcRGzKOQ9X15+ZhLhgXcLEtxXjP4F6wt7YzWSch7XnjjQJkr1J2cs6OEAyNXyoPn cfCY0B36jwHcESVbCsAtmlDzclehZQ4XdVUeE9+JcfhLnO2HXcl5DBAgsGl/BApnRqY6 QB7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710831567; x=1711436367; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sMcKfZi1xz5eaYp9NuQfLHyNEpRw2+4mgzvyh4Nj45M=; b=baNdacPY3x0Ju5V9zzgl8lXdNJlc4K2AFN/FtacZ+QE7sWKPoaLXxpCzKXDvnN822S hELvOWtFgduo5nOh4Pfvsk/odHVQrAVvJ67YyD4dmhxfbzkAMQyWE5R//RlIZVfu0cLz z6ty19ZS69NbOG/avbZR5ivvf02JpFc3k9GsFMJ7KJ5KFUiZUZ2ifOcoEXZF8kp6ZdtQ tQlTP2s6wwIF6v4+rfUVZzZxluk7EfoquwkQLtxu23ApgYH7WCg06DrmUnUW5HZML0eM j3JzWBxD1dUT5GlaiNVJu5L6aL1UKGfOGPr8kIaDD9ujH3bE0KRr99b3T9EM+N51fTL9 45pQ== X-Forwarded-Encrypted: i=1; AJvYcCUktD4xC5xMYgMoyHfhiGxB8kst//f550GBf+8u11dtxt4d1BX9rqrVBqVyc6YiBpaYsY00AWyyW5KEl9/Ae1JyvZXZijn5qKGoQFoUMiddIQT6CpE= X-Gm-Message-State: AOJu0YyLpsPkFYmdngRp5h1oIak37dSJCfLFTa+p3TK5x+N4hAJ/9zNO YxPpmbLELB1T7nBhTa5ZMsdAytev4TEMWpnrTAoW5rPidmMs77og X-Google-Smtp-Source: AGHT+IEPaXPncig+2mfJueHot0LijD4BGVGO0GUG1oH2eSfMb7KVBv96LoNJAMJa6u8EF69x5xL/1g== X-Received: by 2002:a17:903:230a:b0:1de:f6aa:c991 with SMTP id d10-20020a170903230a00b001def6aac991mr14909604plh.34.1710831567041; Mon, 18 Mar 2024 23:59:27 -0700 (PDT) Received: from [172.16.116.58] ([103.15.228.94]) by smtp.gmail.com with ESMTPSA id u16-20020a170903125000b001dd8e1db1b1sm10509163plh.175.2024.03.18.23.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 23:59:26 -0700 (PDT) Message-ID: <28a5e314-30ba-4fc4-9228-51adb63e7aaa@gmail.com> Date: Tue, 19 Mar 2024 12:29:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/8] mikrobus: Add mikrobus driver Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: jkridner@beagleboard.org, robertcnelson@beagleboard.org, Vaishnav M A , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Jiri Slaby , Johan Hovold , Alex Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, greybus-dev@lists.linaro.org References: <20240315184908.500352-1-ayushdevel1325@gmail.com> <20240315184908.500352-8-ayushdevel1325@gmail.com> <8799b216-57a7-451b-80a3-3d4ae9693e0b@linaro.org> <402d1296-0a0c-4f85-a096-be7993869f94@gmail.com> <81d55f10-c538-494f-8274-6ea8c4366ab2@linaro.org> From: Ayush Singh In-Reply-To: <81d55f10-c538-494f-8274-6ea8c4366ab2@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_235928_461317_D224B394 X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/19/24 11:02, Krzysztof Kozlowski wrote: > On 16/03/2024 14:06, Ayush Singh wrote: >> > Are you sure this fits in Linux coding style limit (not checkpatch >> limit, but the limit expressed by Linux coding style)? >> >> >> Well, I am just using clang-format with column width of 100 instead of >> 80. The docs now say 80 is prefered rather than mandatory, so well I was > So you introduce your own style? Then consider it mandatory... > >> using 100 since I prefer that. If 80 is necessary or would make review >> easier than I can just switch to it. > You do not choose your own coding style. > >> >> I will remove serdev, pwm, clickID and send a new patch with the minimal >> driver and better commit messages as suggested with Vaishnav. It is >> important to have good support for mikroBUS boards without clickID as well. > Best regards, > Krzysztof > I mean after the whole discussion about 80 vs 100 column line limit a few years ago, and change in checkpatch behavior, I thought 100 was an acceptable column length in the kernel, but I guess was mistaken, and 80 character is still mandatory? Not sure why there was a change in checkpatch and docs though. Regardless, I have switched 80 in the next patch since it is mandatory, and I do not care as long as I can format using a formatter. Ayush Singh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel