From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC95AC00140 for ; Sat, 6 Aug 2022 01:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9gsCC/TeAXc34HK5yRnK2ZfRLKtdGHsovzsxTEvX63I=; b=uYkKRI/GBZfJgH x71YGMio/w6pZQzoDVeFx1DnBjeM8L047JM1s61RbHJlqDh3gWlx5jNRzw8i6PoruPdE4aP4LWzuh DGx9JF7JBaCzZNK/QWbYhSNDEHd+w4l5F71CTmGlYudONibRYqGHdsZ23R1he2druQKXLiRUxtwRL OkPpKI86H7Du1KOGEWM+uRuLbaa00L+6u/HxgaPBcc415k0jChzzSQ/IKfwcYvNXfDEiw6ZGJ95u2 5Xz+oUoxO/P1FFkrO34g3kdAINkAG1nDg+L5gRCWUpKyW5Z74DTwx12SDai5R8CKoK5QH/YdjYKe1 w+rmW0jUYzVdFSQpbqag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oK8Ly-002LhS-Hk; Sat, 06 Aug 2022 01:11:46 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oK8Lt-002LfZ-41 for linux-arm-kernel@lists.infradead.org; Sat, 06 Aug 2022 01:11:43 +0000 Received: from [192.168.254.32] (unknown [47.189.24.195]) by linux.microsoft.com (Postfix) with ESMTPSA id 6821621004C5; Fri, 5 Aug 2022 18:11:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6821621004C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1659748298; bh=pfOc+xGf+nuzNbZ5dCq0tO3HMBJlaKXeF3tQHDr1nVk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=URs7nyA1xpSH1yNYjiyNdXH8b7Wkv/dAn84+2N7CSQ4VUSeB6vLqmHprNXwHTe6SV XQ8Jq6b98hhWM2Fg1CPlMCqbxgpuvXy6klil/FOG3MM5JlN4CcpFnb/0MXMizcuasi va27NV/4D2nX6Ul+wFERQzG13/GYlAIsEM/+u8ZA= Message-ID: <28a74a5e-544a-8b82-15a6-dc0d6c54bef8@linux.microsoft.com> Date: Fri, 5 Aug 2022 20:11:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/8] arm64: stacktrace: cleanups and improvements Content-Language: en-US To: Mark Rutland , linux-arm-kernel@lists.infradead.org, Marc Zyngier Cc: broonie@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, kaleshsingh@google.com, tabba@google.com, will@kernel.org References: <20220805124522.706457-1-mark.rutland@arm.com> From: "Madhavan T. Venkataraman" In-Reply-To: <20220805124522.706457-1-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220805_181141_249793_C3A26D57 X-CRM114-Status: GOOD ( 21.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for the improvements. For the whole series: Reviewed-by: Madhavan T. Venkataraman On 8/5/22 07:45, Mark Rutland wrote: > Hi Marc, > > This series is a set of improvements for the recently merged stacktrace > rework queued in the kvmarm next branch, along the lines of my prior > suggestions. I'm hoping that it would be possible to queue this for > -rc1. > > Largely, the series decouples portions of the unwind code, making some > structural changes that remove the need for coupling (e.g. removing the > need for the stack type enumeration, and factoring out callbacks). This > should make it easier to make some further changes I have spoken about > previously (e.g. adding some metadata to the stack dump output), and I > have some patches building atop this which I intend to send out once > this is merged. > > The only (intended) functional change from this series is improved > boundary detection, where overlapping frame records will now be caught > and rejected. > > I've tested this natively (with the ftrace tests, LKDTM, and > /proc/self/stack), which seems happy. > > I've also tested the NVHE and PKVM unwinders by hacking a BUG() into the > hyp code shortly after the KVM hyp code is initialized, and in both > cases the output is unchanged. > > Since v1 [1]: > * Fix build warning with CONFIG_SDEI_INTERFACE=y && W=1 > * Fix typos > * Fix whitespace errors > * Apply tags from Kalesh Singh and Mark Brown > > [1] https://lore.kernel.org/r/20220801121209.2479449-1-mark.rutland@arm.com > > Thanks, > Mark. > > Mark Rutland (8): > arm64: stacktrace: simplify unwind_next_common() > arm64: stacktrace: rename unwind_next_common() -> > unwind_next_frame_record() > arm64: stacktrace: move SDEI stack helpers to stacktrace code > arm64: stacktrace: add stackinfo_on_stack() helper > arm64: stacktrace: rework stack boundary discovery > arm64: stacktrace: remove stack type from fp translator > arm64: stacktrace: track all stack boundaries explicitly > arm64: stacktrace: track hyp stacks in unwinder's address space > > arch/arm64/include/asm/processor.h | 2 +- > arch/arm64/include/asm/sdei.h | 17 -- > arch/arm64/include/asm/stacktrace.h | 71 +++++-- > arch/arm64/include/asm/stacktrace/common.h | 211 +++++++++------------ > arch/arm64/kernel/ptrace.c | 2 +- > arch/arm64/kernel/sdei.c | 32 ---- > arch/arm64/kernel/stacktrace.c | 66 ++++--- > arch/arm64/kvm/hyp/nvhe/stacktrace.c | 40 ++-- > arch/arm64/kvm/stacktrace.c | 135 +++++++------ > 9 files changed, 288 insertions(+), 288 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel