From mboxrd@z Thu Jan 1 00:00:00 1970 From: robin.murphy@arm.com (Robin Murphy) Date: Fri, 18 Nov 2016 16:43:30 +0000 Subject: [PATCH v8 12/16] drivers: iommu: arm-smmu: split probe functions into DT/generic portions In-Reply-To: <20161118160006.GW13470@arm.com> References: <20161116152936.22955-1-lorenzo.pieralisi@arm.com> <20161116152936.22955-13-lorenzo.pieralisi@arm.com> <20161118160006.GW13470@arm.com> Message-ID: <28abb42b-4a93-fbb0-d8bb-e6b82b2b992f@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18/11/16 16:00, Will Deacon wrote: > On Wed, Nov 16, 2016 at 03:29:32PM +0000, Lorenzo Pieralisi wrote: >> Current ARM SMMU probe functions intermingle HW and DT probing >> in the initialization functions to detect and programme the ARM SMMU >> driver features. In order to allow probing the ARM SMMU with other >> firmwares than DT, this patch splits the ARM SMMU init functions into >> DT and HW specific portions so that other FW interfaces (ie ACPI) can >> reuse the HW probing functions and skip the DT portion accordingly. >> >> This patch implements no functional change, only code reshuffling. >> >> Signed-off-by: Lorenzo Pieralisi >> Reviewed-by: Tomasz Nowicki >> Tested-by: Hanjun Guo >> Tested-by: Tomasz Nowicki >> Cc: Will Deacon >> Cc: Hanjun Guo >> Cc: Robin Murphy >> --- >> drivers/iommu/arm-smmu.c | 62 +++++++++++++++++++++++++++++------------------- >> 1 file changed, 37 insertions(+), 25 deletions(-) > > Reviewed-by: Will Deacon > > Although I'd also like Robin to have a look at this. Sorry, I've been slow this week. Having finally got round to taking a proper look, I swear this seems even tidier than the last version I looked at closely. It doesn't break DT boot on my Juno, either. Reviewed-by: Robin Murphy > > Will >