From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4A0EC433F5 for ; Fri, 1 Apr 2022 17:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CCuvpHDs+uYj+0FrbqIebLHI7RjjNyiPSospFw96Teo=; b=Ci210ZWdMZexpc MQ9GvIXi19rYb6NdUcn7Zu/fHepbd/Aa3QB+9pRx8LwKzVCJTXvzwfOZwQadz1ix50z/zLIhe0KF7 vFJ3iK6w2OPia1GLkYpGIS10+rvJkmF9EEm9isPLxk0dtk7io1q9cJ9jpMyPHaGCK+cBAbFvJqF2z nZIh5DBu7eqTb6+G6Poe4EL08d2chae9WaJf6f2sQrPW6t5oNWml7IR1l5UFQch7gz/hWdgzQ8uDS NqyHvPBobfVimfgUapWfuafEJpWxbOIHle8NKD8KJ94P1NMRy0G0qgBehJFrl3VhtpwxcZSd7O1K6 dFBphpLkf2Tbx0zucFwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naKiC-006dtB-4k; Fri, 01 Apr 2022 17:05:24 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naKi8-006ds2-2m for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 17:05:21 +0000 Received: from [192.168.4.54] (cpe-70-95-196-11.san.res.rr.com [70.95.196.11]) by linux.microsoft.com (Postfix) with ESMTPSA id 105EE20DEECE; Fri, 1 Apr 2022 10:05:17 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 105EE20DEECE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1648832717; bh=8iqwr0fkDf/M1HJO1B33GqKPPbT8OnwevZSVUEf6xFc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WYm/onuc+L4XZzc3uS3IFOs9xTQzuXAe+ZbFQh7p34Y8Q0USYgdpW5svKlmeX+Njf TjRwsHY0AqWU4KIszhBBAOOa0/8Odt7IzJrUtf+p3gfCLi1lXT/v41IQ9+6qGj+72S E60gRXE7vFCHJvdp65DBVe8X0TC7VvPPBbokJbns= Message-ID: <28b9ca3e-83d8-ea4b-1f27-d23c2d29424f@linux.microsoft.com> Date: Fri, 1 Apr 2022 10:05:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 resend 3/3] arm64: mm: Cleanup useless parameters in zone_sizes_init() Content-Language: en-US To: Kefeng Wang , catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: f.fainelli@gmail.com References: <20220331074055.125824-1-wangkefeng.wang@huawei.com> <20220331074055.125824-4-wangkefeng.wang@huawei.com> From: Vijay Balakrishna In-Reply-To: <20220331074055.125824-4-wangkefeng.wang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_100520_355215_2B8790A3 X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/31/2022 12:40 AM, Kefeng Wang wrote: > Directly use max_pfn for max and no one use min, kill them. > > Signed-off-by: Kefeng Wang Looks good. Reference to dma32_phys_limit in zone_sizes_init() depends on what you do with my comment [1]. [1] https://lore.kernel.org/all/69c1e722-33ea-95cf-de84-aed3022cb042@linux.microsoft.com/ Reviewed-by: Vijay Balakrishna > --- > arch/arm64/mm/init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index 0aafa9181607..80e9ff37b697 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -181,7 +181,7 @@ static phys_addr_t __init max_zone_phys(unsigned int zone_bits) > return min(zone_mask, memblock_end_of_DRAM() - 1) + 1; > } > > -static void __init zone_sizes_init(unsigned long min, unsigned long max) > +static void __init zone_sizes_init(void) > { > unsigned long max_zone_pfns[MAX_NR_ZONES] = {0}; > #ifdef CONFIG_ZONE_DMA > @@ -199,7 +199,7 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max) > #ifdef CONFIG_ZONE_DMA32 > max_zone_pfns[ZONE_DMA32] = PFN_DOWN(dma32_phys_limit); > #endif > - max_zone_pfns[ZONE_NORMAL] = max; > + max_zone_pfns[ZONE_NORMAL] = max_pfn; > > free_area_init(max_zone_pfns); > } > @@ -401,7 +401,7 @@ void __init bootmem_init(void) > * done after the fixed reservations > */ > sparse_init(); > - zone_sizes_init(min, max); > + zone_sizes_init(); > > /* > * Reserve the CMA area after arm64_dma_phys_limit was initialised. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel