From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1070C433E0 for ; Wed, 30 Dec 2020 23:35:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61F4D207A9 for ; Wed, 30 Dec 2020 23:35:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61F4D207A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lechnology.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6Wvk7S5u/LOC/rIjEoT9dBx3ktvYWWuVY25apmM9uPc=; b=at67yoMHZXdzGnBA5cyrULTwI kL0ZEySzs2oWbOAPHgRTOQxsud2+h1Bi9O9oRdjdCqaKiSVvdOtfcPbQkRoJ082cv6eOLLwQmAueE D6DVQGe+so91sTydZyZUO8ShhI4rgbAansA+JRygYQSvkk06IT4jtuXONJF49Y/HKse8t47Qwfq5b viWNAiqSDOI9KwIyQGsa7oRlWW1NmO2yLqFD64xJVZuGjOfL9SOqpIFA6faF3Jw267QdePMXqwvYb DNBpGJ4VzzoTaPId9XE1iYaeoCvmXIfmnyJQIOqDmrgxnf7XpF7zzsKjaqOnjRQiqnMOwgsbxd3d9 YJSLQJ0mg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kukyt-0001cL-B5; Wed, 30 Dec 2020 23:34:15 +0000 Received: from vern.gendns.com ([98.142.107.122]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kukyq-0001bt-4h for linux-arm-kernel@lists.infradead.org; Wed, 30 Dec 2020 23:34:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LsHXR2e4SeHb6nWLvgDlYAkW2jrz4NZvHBU+beGGqjk=; b=nxOVY/Upf6L9yB0fDOUuLdENEu BOdqHHrdHdVimcpoi0AQghaNPDV8Hof/YwQUsMycf1Do8Z67fA/B0Op8weZbHDvlTbxuDiLHH6vTT 05DDFAb0CIT8mBUxzrRxqSD64RG/7guGbGOlpB46z/iTK4FC2y9qxjreD6xIOTljiBPSxpaZ6DYsK k/p6zNPA+0xk1PFN6Ohur9iVsPjeN1ixfow1LPIzElqdsm9QtJiSkuJbndXKLgtXkf6nCSIHvg1a9 2uPXEFhM3qRbse7xFeW6fpvoUSnfj5z0G33dVVJ57q3JjfowJZvG8wriPL6htGLaRRp4COvxNu1Hn E7vxSzGQ==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:43040 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kukyn-0006qC-7b; Wed, 30 Dec 2020 18:34:09 -0500 Subject: Re: [PATCH v7 0/5] Introduce the Counter character device interface To: William Breathitt Gray , jic23@kernel.org References: From: David Lechner Message-ID: <28cfe031-8883-3160-8658-084c2d4260c0@lechnology.com> Date: Wed, 30 Dec 2020 17:34:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201230_183412_239118_A4BAF270 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kamel.bouhara@bootlin.com, gwendal@chromium.org, a.fatoum@pengutronix.de, mcoquelin.stm32@gmail.com, linux-iio@vger.kernel.org, patrick.havelange@essensium.com, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, fabrice.gasnier@st.com, syednwaris@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/25/20 6:15 PM, William Breathitt Gray wrote: > Changes in v7: > - Implemented u32 enums; enum types can now be used directly for > callbacks and values > - Fixed refcount underflow bug > - Refactored all err check to check for err < 0; this should help > prevent future oversights on valid positive return valids > - Use mutex instead of raw_spin_lock in counter_chrdev_read(); > kifo_to_user() can now safely sleep > - Renamed COUNTER_COMPONENT_DUMMY to COUNTER_COMPONENT_NONE to make > purpose more obvious > - Introduced a watch_validate() callback > - Consolidated the functionality to clear the watches to the > counter_clear_watches() function > - Reimplemented counter_push_event() as a void function; on error, > errno is returned via struct counter_event so that it can be handled > by userspace (because interrupt handlers can't do much for this) > - Renamed the events_config() callback to events_configure(); > "events_config" could be confused as a read callback when this is > actually intended to configure the device for the requested events > - Reimplemented 104-QUAD-8 driver to use events_configure() and > watch_validate() callbacks; irq_trigger_enable sysfs attribute > removed because events_configure() now serves this purpose > > The changes for this revision were much simpler compared to the previous > revisions. I don't have any further questions for this patchset, so it's > really just a search for possible bugs or regressions now. Please test > and verify this patchset on your systems, and ACK appropriately. > I'll wait for the next round to give my Reviewed-By, Tested-By but I've rebased my WIP TI eQEP changes[1] on this and I haven't ran into any problems yet. [1]: https://github.com/dlech/linux/commits/bone-counter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel