From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ken Sloat <ksloat@cornersoftsolutions.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
dmaengine@vger.kernel.org, alexandre.torgue@foss.st.com,
mcoquelin.stm32@gmail.com, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org, vkoul@kernel.org,
amelie.delaunay@foss.st.com
Subject: Re: [PATCH v1] dt-bindings: dma: st-stm32-dmamux: Add description for dma-cell values
Date: Thu, 5 Dec 2024 17:09:35 +0100 [thread overview]
Message-ID: <28d1bb46-ab18-42da-9ca2-ff498c888d66@kernel.org> (raw)
In-Reply-To: <CADRqkYDnDNL_H2CzxjsPOdM++iYp-9Ak3PVFBw2qcjR_M=GeBA@mail.gmail.com>
On 05/12/2024 17:07, Ken Sloat wrote:
>>> + 1. The mux input number/line for the request
>>> + 2. Bitfield representing DMA channel configuration that is passed
>>> + to the real DMA controller
>>> + 3. Bitfield representing device dependent DMA features passed to
>>> + the real DMA controller
>>> +
>>> + For bitfield definitions of cells 2 and 3, see the associated
>>> + bindings doc for the actual DMA controller the mux is connected
>>
>> This does not sound right. This is the binding for DMA controller, so
>> you are saying "please look at itself". I suggest to drop this as well.
>>
>
> While logically it is the DMA controller, this doc is specifically for
> the mux - the DMA controller has its own driver and binding docs in
> Documentation/devicetree/bindings/dma/stm32/st,stm32-dma.yaml
>
> I can reference st,stm32-dma.yaml directly, but I was unsure if this
> mux IP was used with another DMA controller from ST on a different
> SoC.
>
> What do you suggest here?
Thanks for explanation, I think it is fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-05 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 15:32 [PATCH v1] dt-bindings: dma: st-stm32-dmamux: Add description for dma-cell values Ken Sloat
2024-12-05 15:59 ` Krzysztof Kozlowski
2024-12-05 16:07 ` Ken Sloat
2024-12-05 16:09 ` Krzysztof Kozlowski [this message]
2024-12-05 18:04 ` Amelie Delaunay
2024-12-06 10:40 ` Ken Sloat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28d1bb46-ab18-42da-9ca2-ff498c888d66@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=ksloat@cornersoftsolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox