From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support
Date: Thu, 16 Jan 2014 23:04:53 -0800 [thread overview]
Message-ID: <2909743.WgOIUglCS0@lenovo> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1401151525400.1587-100000@iolanthe.rowland.org>
Le mercredi 15 janvier 2014, 15:26:21 Alan Stern a ?crit :
> On Wed, 15 Jan 2014, Hans de Goede wrote:
> > Hi All,
> >
> > This version of my ohci and ehci-platform clks, phy and dt support
> > patch-set, really fixes the 2 small bugs Alan found.
>
> All okay -- this time I can't find anything to complain about. :-)
There is one minor issue; which is that the ehci binding claims the driver
supports the following optional boolean properties:
- big-endian-regs : boolean, set this for hcds with big-endian registers
- big-endian-desc : boolean, set this for hcds with big-endian descriptors
- big-endian : boolean, for hcds with big-endian-regs + big-endian-desc
while it does not (yet) so this is misleading. Can we at get that fixed before
merging? Copy pasting the PPC ehci driver should do the job.
--
Florian
next prev parent reply other threads:[~2014-01-17 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 19:24 [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support Hans de Goede
2014-01-15 19:24 ` [PATCH v7 1/2] ohci-platform: Add support for devicetree instantiation Hans de Goede
2014-01-21 17:59 ` Sergei Shtylyov
2014-01-21 17:10 ` Hans de Goede
2014-01-15 19:24 ` [PATCH v7 2/2] ehci-platform: Add support for clks and phy passed through devicetree Hans de Goede
2014-01-16 0:11 ` Florian Fainelli
2014-01-15 20:26 ` [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support Alan Stern
2014-01-17 7:04 ` Florian Fainelli [this message]
2014-01-17 17:12 ` Alan Stern
2014-01-18 16:21 ` Hans de Goede
2014-01-19 2:49 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2909743.WgOIUglCS0@lenovo \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).