From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E800C433F5 for ; Thu, 9 Dec 2021 21:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=EkHr7CZvutbMQXzZKwMSbG+peMxpkXzyQ+COGKPavI4=; b=YKsDFRsr0iazuozEx7dM6AqOQS pepCIYTYNj71K3m8PJn4en1UdJGN/2/3I76F2aMUOalievK8wHdnLHgVLEmbJ0LKZiOwoIX8ST3yo 81Uw030tlkdcFYd1aWzGM0H7VWyNTsMu29DgaFtemBAWDus6gNTWn9ssPaWII/1TaGVvMiXKpO6ia dqOIzW3PuyyyMOozEQpCFneaCRjQ+L5aOD5uutYIImtzfxHTh4P9g0YGI1nTqn0QvnFnRXwvOEY0Q EMw0XWGOoJ7yxtRkfZoRW9eyZAPmqrV0KQk/PCKJG9pS9oFFbK1TmhHeStkb+llbJtw2ro7o5kUxd wBjiZKOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvR4A-00060G-Bx; Thu, 09 Dec 2021 21:35:02 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvR47-0005yw-3V; Thu, 09 Dec 2021 21:35:00 +0000 Received: by mail-pg1-x535.google.com with SMTP id j11so6269756pgs.2; Thu, 09 Dec 2021 13:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5amisMk02X6OjYIuHUB57loA8SORa0eE7CAIPMryo38=; b=ipw8Fb2thSLvDq0x0iCSQ22eedLIpCehS0ABagq5ThL0UFzZ8B8hRNObuCb6uiJWx0 b0KDL2Tnne2hSzPAoq+2IyjGKUjoie73/WMeHNIJvOfFQQT9LqZW5jdz0c9lzGyOPgQt IMc+AuZ+Vj6K5TAbjflDlK294jR6+QSTFewBHIwD1uz7InoNtvOcED74xncRNeOwVQM9 M3cemFaqqlgDbs9cG6VJCyjU9lbGi9RDYg0ktz1VAkRttj6/wsl/wQ4sd8m9Odox53ia mwpuDvnG7B7JMEcR8sZpWmsBfqPRFFOapv2GiogGA9kkFIta8V7VvbTHhd1ydiTww9k9 si7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5amisMk02X6OjYIuHUB57loA8SORa0eE7CAIPMryo38=; b=u09S6ZxEIlou7n0K9Y95rnD2lcqTA1BFMNt84sdGLnXwslYIzC5QeJKZ4zVbHqbY2H fXpqUtz9ZoD5hWgSsyvQc+8l+5ZFkCUeOyeKBVWR6vlPRu4MbyxrEpzq3DwZu8rjmkJY XauA11ny8Qb2FqFSwRBdebYQQhttWeHEL1EQVzTkOclKT00cK620vaz/XyIRujs3mH2Q GwkNSyStmINYBnep0GxltMPNB1APZnlrZvrMTOdpnj4e68+QrhUXTgHoMiD4xq99h52n pIvKMqZnN91P2BN+74S1rbDZjgoIUOJaQ4GtxY1kv7JX2o2w0SbUD8jMH1InY48ndU3U QJvA== X-Gm-Message-State: AOAM531GDWLyZuKZHKnzPhrR2wLwDw/zODC4y4RYQEEERaDIF2C0xbw+ ob8rDMZdEMZ5X7fw7BCgadFME8H8hOc= X-Google-Smtp-Source: ABdhPJxr4pe7eb47Ap+CyEWNd0mA2jhMsJkSiHs3GbzIJ/xHzZUqPMlNUYGcI73CQ+7276kdVUDERw== X-Received: by 2002:a05:6a00:1344:b0:49f:f357:ac9 with SMTP id k4-20020a056a00134400b0049ff3570ac9mr14060302pfu.62.1639085697976; Thu, 09 Dec 2021 13:34:57 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id v25sm603062pfg.175.2021.12.09.13.34.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Dec 2021 13:34:57 -0800 (PST) Subject: Re: [PATCH v10 1/7] PCI: brcmstb: Fix function return value handling To: Jim Quinlan , linux-pci@vger.kernel.org, Bjorn Helgaas , Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20211209211407.8102-1-jim2101024@gmail.com> <20211209211407.8102-2-jim2101024@gmail.com> From: Florian Fainelli Message-ID: <290fe880-32a4-109d-35fa-fc72c88798e9@gmail.com> Date: Thu, 9 Dec 2021 13:34:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211209211407.8102-2-jim2101024@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_133459_182460_EE0EDAAE X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/9/21 1:13 PM, Jim Quinlan wrote: > Do at least a dev_err() on some calls to reset_control_rearm() and > brcm_phy_stop(). In some cases it may not make sense to return this error > value "above" as doing so will cause more trouble than is warranted. > > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel