From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A9E7C433FE for ; Wed, 2 Mar 2022 12:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bX5oJo+63nfTlOruECln2kow0gibaBp0DCOdhaeXZyU=; b=GMMpS4bSY2cFMz bY4nHLFEQsOItGwxksTUj/oIttPZEoApIgmM+bLQDDcu9NJM+5TyVl8Dz/WxrxB/nsqgbhP7PezIy 9DjW98VYe0ChS3flNSUny3pyZv1/xnK0oFwokmbV2RNxyFU+hI3bdDU7HbXqzzxd4/iqeGOHNQ77W IRE3NosWLu6ZpMXZzsvwjI1PR+jVyJttvwWO3xPxzpQ7zEADJiENvhpLV38GGrmT4d+7uVoyAJmkD HMXf67lvba2sK+kfM8pEvRZoN2iOB7rH/+S8VJo5S1OlhdwpbX87LCP89isqjEvoeP59OXn3IBesI T0ydVvxV6Tp/gCI4n0mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPNp6-002a51-34; Wed, 02 Mar 2022 12:11:16 +0000 Received: from esa3.hgst.iphmx.com ([216.71.153.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPNp2-002a3k-7S for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2022 12:11:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1646223071; x=1677759071; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vAuQx7BREl0FilyuvYvK+6a4J3lvwM0xT1xhYotLxzk=; b=RYOaBPhRKxClRtBv+DU/CNEhQhcChjVDuUITFWWm1TSAY8ABuJe5TsXB KbjRBeXmRAOOfCftib+Y7vOS91mV774vg/Tl/4mwQ3wZw0hsteZ4hbXcf CdCwh7wG/oYyWRDB4BSmww1TiBylaR4sOuC/nHfWJo0j8nQvEj0tFkZpd 32YrchmECtzj07UEbBPeJbcLmEybLTXvYkLd1q0DrwdYpFUTKunOuPWcl eCW/Upslr51wAM56/I32Rnh3JbQkJ4CAK2jnh+Di4wjxB69BfoVv7emiU jOcZyZUeA4Ta5YvRUOUng8REfxG7SDvMwnSeJRA7ybUfX5d96YHcEVXmx A==; X-IronPort-AV: E=Sophos;i="5.90,148,1643644800"; d="scan'208";a="199127676" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 02 Mar 2022 20:11:09 +0800 IronPort-SDR: vPjaC5lOhEJ61znnLejz76zshcf28elS2YJtC/AZ+K1L/hzz02FkkExSQEsb5BaSZWaxFuq7I9 qNOwrlpPEplNpKmzwl7gTa0hB/7tB5nbt4BAPHS/ua8X/hULYuJu9j7yVLGgUKIyw0uNfeXRP4 SdB2ss5ewPr2V8TZZrMZdOGsCeQWsRiQguXo5CrhLRhddee0wQJhRBuzwo1Lzb/xehOb/LRNPs eANmGt+gKjtPhrgmDbkzQE5gb4PS7tyFotZ0PZtYXGVAcWYMkj9WkK0aBWF/rbw/x+zIOiBeHY Hx9uKvOexTjz0gQgROxD/KPQ Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 03:42:32 -0800 IronPort-SDR: HHad6VS+n8w0G7+L4gF4zacBX08U7sKsYpr67IANMhThwaFgYZWcA4QkZtHWO9yCvxFK2T0FRL 7/b9fPsHwoiWca9w0oU2yL3edXO/y5h7LU/yv3swS053gIDUpK9FZB2ZcnCbltKChdjDbw3Web NHDDNOC905iInS3/Hd3bp/AJeR6B7Z82tCv3e/9hSClk+a8+EyS+VBBUP7qcEoWgqKzNjJwePE Ho8xvh0dZyHM7hpVEej8/gzQVOaBaQC45uIaNyAhwWI2L7eWfhvj2zLspAwidH4IYzI8L6OE/q 0Q4= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 04:11:10 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4K7tHx43tLz1SVp4 for ; Wed, 2 Mar 2022 04:11:09 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1646223066; x=1648815067; bh=vAuQx7BREl0FilyuvYvK+6a4J3lvwM0xT1x hYotLxzk=; b=sW24+POORS7QCs5ajGoOpwrD02UfzHTMEihD7QuUSYtAsBb9DyB 3fIO572maEFRNfM0Qnxag1NYztWLzDufPPInhe8sBaLq19I4HRkhNQbLH2d9KJ9N Ofxwk4Z+v/4ezCovRr1X1ZePFzZQG3kfzrBIEZ9VA72/11++DL/FcEbSjx2mv4g8 dtbg8czLWBdbTztEThp8OVK+7kRXsLlmuRpLNbii27M1WSv4pCtJYLDpIA6tenW/ D3dYyrQOZ4xWfynPIeSVI0U77bsuV5aO7k+2n90FdpjqkrNFp0oSc9vca5m/JcPG YWGAOZmXjGAT/mK9K4wjqDJ184QEQFBAnCw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TSDTclfuoa71 for ; Wed, 2 Mar 2022 04:11:06 -0800 (PST) Received: from [10.112.1.94] (c02drav6md6t.wdc.com [10.112.1.94]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4K7tHq4cw8z1Rvlx; Wed, 2 Mar 2022 04:11:03 -0800 (PST) Message-ID: <2918bfa8-ca14-1395-b8a0-428e250c5a00@opensource.wdc.com> Date: Wed, 2 Mar 2022 14:11:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] ata: Drop commas after OF match table sentinels Content-Language: en-US To: Geert Uytterhoeven Cc: Hans de Goede , Jens Axboe , Patrice Chotard , Sergey Shtylyov , Linus Walleij , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org References: <15d4b8e1108c902c4e80c87edfc702a7786de4ba.1646209667.git.geert+renesas@glider.be> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <15d4b8e1108c902c4e80c87edfc702a7786de4ba.1646209667.git.geert+renesas@glider.be> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_041112_379239_2017382D X-CRM114-Status: GOOD ( 25.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/03/02 10:30, Geert Uytterhoeven wrote: > It does not make sense to have a comma after a sentinel, as any new > elements must be added before the sentinel. > > Add comments to clarify the purpose of the empty elements. Some nits below. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/ata/ahci_brcm.c | 2 +- > drivers/ata/ahci_ceva.c | 2 +- > drivers/ata/ahci_da850.c | 2 +- > drivers/ata/ahci_dm816.c | 2 +- > drivers/ata/ahci_imx.c | 2 +- > drivers/ata/ahci_mtk.c | 2 +- > drivers/ata/ahci_mvebu.c | 2 +- > drivers/ata/ahci_octeon.c | 2 +- > drivers/ata/ahci_platform.c | 2 +- > drivers/ata/ahci_qoriq.c | 2 +- > drivers/ata/ahci_st.c | 2 +- > drivers/ata/ahci_sunxi.c | 2 +- > drivers/ata/ahci_xgene.c | 2 +- > drivers/ata/pata_ftide010.c | 2 +- > drivers/ata/pata_ixp4xx_cf.c | 2 +- > drivers/ata/pata_macio.c | 2 +- > drivers/ata/pata_mpc52xx.c | 2 +- > drivers/ata/pata_octeon_cf.c | 2 +- > drivers/ata/pata_of_platform.c | 2 +- > drivers/ata/sata_fsl.c | 2 +- > drivers/ata/sata_gemini.c | 2 +- > drivers/ata/sata_highbank.c | 2 +- > drivers/ata/sata_mv.c | 2 +- > drivers/ata/sata_rcar.c | 2 +- > 24 files changed, 24 insertions(+), 24 deletions(-) [...] > diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c > index 34cb104f6b43e5cf..2a92797b5e11a9aa 100644 > --- a/drivers/ata/pata_ftide010.c > +++ b/drivers/ata/pata_ftide010.c > @@ -557,7 +557,7 @@ static const struct of_device_id pata_ftide010_of_match[] = { > { > .compatible = "faraday,ftide010", > }, While at it, could you rewrap this one to a single line to have a consistent style ? > - {}, > + { /* sentinel */ } > }; > > static struct platform_driver pata_ftide010_driver = { > diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c > index 17b557c91e1c78fc..e225913a619d8414 100644 > --- a/drivers/ata/pata_ixp4xx_cf.c > +++ b/drivers/ata/pata_ixp4xx_cf.c > @@ -293,7 +293,7 @@ static int ixp4xx_pata_probe(struct platform_device *pdev) > > static const struct of_device_id ixp4xx_pata_of_match[] = { > { .compatible = "intel,ixp4xx-compact-flash", }, > - { }, > + { /* sentinel */ } > }; > > static struct platform_driver ixp4xx_pata_platform_driver = { > diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c > index 16e8aa184a75793f..8cf778723fd6d049 100644 > --- a/drivers/ata/pata_macio.c > +++ b/drivers/ata/pata_macio.c > @@ -1345,7 +1345,7 @@ static const struct of_device_id pata_macio_match[] = > { > .type = "ata", > }, Here too. > - {}, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, pata_macio_match); > > diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c > index f1d352d5f128537a..bc9d9df3b5aced64 100644 > --- a/drivers/ata/pata_mpc52xx.c > +++ b/drivers/ata/pata_mpc52xx.c > @@ -849,7 +849,7 @@ mpc52xx_ata_resume(struct platform_device *op) > static const struct of_device_id mpc52xx_ata_of_match[] = { > { .compatible = "fsl,mpc5200-ata", }, > { .compatible = "mpc5200-ata", }, > - {}, > + { /* sentinel */ } > }; > > > diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c > index 05c2ab3757568c62..bdaec863171a14cf 100644 > --- a/drivers/ata/pata_octeon_cf.c > +++ b/drivers/ata/pata_octeon_cf.c > @@ -1009,7 +1009,7 @@ static const struct of_device_id octeon_cf_match[] = { > { > .compatible = "cavium,ebt3000-compact-flash", > }, And here as well. > - {}, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, octeon_cf_match); > > diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c > index c3a40b717dcdcc2a..ac5a633c00a57ac1 100644 > --- a/drivers/ata/pata_of_platform.c > +++ b/drivers/ata/pata_of_platform.c > @@ -79,7 +79,7 @@ static int pata_of_platform_probe(struct platform_device *ofdev) > > static const struct of_device_id pata_of_platform_match[] = { > { .compatible = "ata-generic", }, > - { }, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, pata_of_platform_match); > > diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c > index 556034a15430461f..11867a7eb4691771 100644 > --- a/drivers/ata/sata_fsl.c > +++ b/drivers/ata/sata_fsl.c > @@ -1583,7 +1583,7 @@ static const struct of_device_id fsl_sata_match[] = { > { > .compatible = "fsl,pq-sata-v2", > }, Same. > - {}, > + { /* sentinel */ } > }; > > MODULE_DEVICE_TABLE(of, fsl_sata_match); > diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c > index 440a63de20d01a07..c7e9efc0025f1a91 100644 > --- a/drivers/ata/sata_gemini.c > +++ b/drivers/ata/sata_gemini.c > @@ -422,7 +422,7 @@ static const struct of_device_id gemini_sata_of_match[] = { > { > .compatible = "cortina,gemini-sata-bridge", > }, Another... > - {}, > + { /* sentinel */ } > }; > > static struct platform_driver gemini_sata_driver = { > diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c > index b29d3f1d64b03317..cd375e4df9644e33 100644 > --- a/drivers/ata/sata_highbank.c > +++ b/drivers/ata/sata_highbank.c > @@ -444,7 +444,7 @@ static struct scsi_host_template ahci_highbank_platform_sht = { > > static const struct of_device_id ahci_of_match[] = { > { .compatible = "calxeda,hb-ahci" }, > - {}, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, ahci_of_match); > > diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c > index 53446b997740d5fd..13d92b71e6659cda 100644 > --- a/drivers/ata/sata_mv.c > +++ b/drivers/ata/sata_mv.c > @@ -4277,7 +4277,7 @@ static int mv_platform_resume(struct platform_device *pdev) > static const struct of_device_id mv_sata_dt_ids[] = { > { .compatible = "marvell,armada-370-sata", }, > { .compatible = "marvell,orion-sata", }, > - {}, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, mv_sata_dt_ids); > #endif > diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c > index 3d96b6faa3f0e1c6..1483d3efeb7e220e 100644 > --- a/drivers/ata/sata_rcar.c > +++ b/drivers/ata/sata_rcar.c > @@ -857,7 +857,7 @@ static const struct of_device_id sata_rcar_match[] = { > .compatible = "renesas,rcar-gen3-sata", > .data = (void *)RCAR_GEN3_SATA > }, > - { }, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, sata_rcar_match); > -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel