From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24526C433F5 for ; Thu, 13 Jan 2022 13:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iAJoaMT1pFc+Aiq+KxAWEouRGvnupO1zzuKzqTKK6FY=; b=q+nP/05UIxWpZl 47FWvnAl6KiSlaba41j83KZCa4xXikjeQMn0aMky7kAqPhMPodyuAKEPhH4FMRFFlwORsLUcjkM0a nffvTjp0Dr3ZUit2Uko221V9aC2c6K866+VcxlkC/UXB8+OcjgFrSruPmb67JohSFcuWgRgaQ2GcX Bsj13xNse5dZ3yXj7YyrQHu4/LkoMq8UviLl/Zrbz28BoWwTAkCyEN2E2wZyy1yOrv6hcJ5D9/RBq Cp6LoH+Ssymb25krOs+u39bXlyUzlp09G3N/7KN9Ka3NhATcuouxQBbH7JHyU12l4DSGSrvmXoKKU di0AqdX0hxwbbsBnPcDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n801G-00651l-Q9; Thu, 13 Jan 2022 13:19:59 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n801C-00650g-Kc for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 13:19:56 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 59BA540033 for ; Thu, 13 Jan 2022 13:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642079993; bh=UOUdEGb7wEdGYbFlp4O3YYitu+PjyU8K/AOUKs49Rb0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MtTK5DJxusz2DBiXNCwvzXrtQK2S3oDOOdtWw69U5bF3Atfn6sTdgeBr+acaG/1HK XAhL02eQ8S/3E7c1QCg/9gZWJsNXtnh6Ywb79XQSialkVHjY1LMRrlpCHbueftQZNs 4Vyilp4bhYUxLRM9BlG0cPfRc+IUGlaTKo/NMm6KuJyU+SbqNJnXy1dYKD8VXt23NN /2UqdxOBZwaVIm32Goy4gBLZvVKcjwjKmqoz/j1RssYAQ1e06eezj865iwbtrupkOW Hmqr1l98mZeQXAXKWSeWJb/Is/lDZ92yOpye2eLw0/EqWdji01JHedbZnyPK10vHWe x+kFzCknzrWdw== Received: by mail-ed1-f71.google.com with SMTP id i9-20020a05640242c900b003fe97faab62so5282116edc.9 for ; Thu, 13 Jan 2022 05:19:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UOUdEGb7wEdGYbFlp4O3YYitu+PjyU8K/AOUKs49Rb0=; b=7Tr85zYsqLkX+7gHupnlN/c+KlMLh6JcAB4ZAMCPKD1pOARv2Nqa/I3SpBKHZNo6yY 2QsuiVreyRQtxj1fz/fflg1Aoa0ZBguATstLzm1+GNHFbW9n4hs7lYyqM0ebRZj/ZXfG P3PEEI0FxcqlShbuyW3hFPW+NzXS4qE9NvDvTEhxhyFVoiyh/YmHgbNlnTAQRNevWBo8 Vm62BeB3lzTm0lO+DKrPgh1zYlZF4ouvlR4cmYS79mJpJJLEQGk6InIZbF8muy2bHvDz w06hqKZyX83O02hBO5c41cSLaR0a2W9DPP+xox/yqWjYx5TFujT7b55ELx2ljkItN6Hq ACGA== X-Gm-Message-State: AOAM530XI3LsgyC8ljuemw2Iv35pQ8zL2Y8hr8CS/ktvUScDrzB9lrvB f3UvJcBAOvJhTXpM3OTXoEA8f84KT3HltO2VbVImJ4zpDbVsxIOdsukhYKnQdhC/YA9UkLgPETE 8UrIiQ8MJFwIa1wed/+P4EM06CDTMXujKgd2YUmyV2DBg/YsMyrC1 X-Received: by 2002:aa7:d785:: with SMTP id s5mr4033384edq.215.1642079992879; Thu, 13 Jan 2022 05:19:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzT2lhQ3mOwZZIJMGGqBFmFbDHwdc9XrZq0CxY23tWw6dY8rlyIXWxbhd5cD/0kImAV/gctJA== X-Received: by 2002:aa7:d785:: with SMTP id s5mr4033354edq.215.1642079992686; Thu, 13 Jan 2022 05:19:52 -0800 (PST) Received: from [192.168.0.30] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id g21sm1139201edt.12.2022.01.13.05.19.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 05:19:52 -0800 (PST) Message-ID: <2927c34e-3259-4e9a-a657-aeeebf9089d2@canonical.com> Date: Thu, 13 Jan 2022 14:19:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com, Shashank Prashar , Aswani Reddy References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-16-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220113121143.22280-16-alim.akhtar@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_051954_865993_B51CB881 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/01/2022 13:11, Alim Akhtar wrote: > Add initial pin configuration nodes for FSD SoC. > > Cc: linux-fsd@tesla.com > Signed-off-by: Shashank Prashar > Signed-off-by: Aswani Reddy > Signed-off-by: Alim Akhtar > --- > arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 338 +++++++++++++++++++++ > arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++ > 2 files changed, 360 insertions(+) > create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi > > diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi > new file mode 100644 > index 000000000000..ec8d944af636 > --- /dev/null > +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi > @@ -0,0 +1,338 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Tesla Full Self-Driving SoC device tree source > + * > + * Copyright (c) 2017-2021 Samsung Electronics Co., Ltd. > + * https://www.samsung.com > + * Copyright (c) 2017-2021 Tesla, Inc. > + * https://www.tesla.com > + */ > + > +#include > + > +&pinctrl_fsys0 { > + No need for empty line. > + gpf0: gpf0 { FYI: It's ok now, but the nodes will have to be renamed to "xxx-gpio-bank" later. > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpf1: gpf1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpf6: gpf6 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpf4: gpf4 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpf5: gpf5 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > +}; > + > +&pinctrl_peric { > + No need for empty line. > + gpc8: gpc8 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpf2: gpf2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpf3: gpf3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpd0: gpd0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb0: gpb0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb1: gpb1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb4: gpb4 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb5: gpb5 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb6: gpb6 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb7: gpb7 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpd1: gpd1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpd2: gpd2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpd3: gpd3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg0: gpg0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg1: gpg1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg2: gpg2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg3: gpg3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg4: gpg4 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg5: gpg5 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg6: gpg6 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg7: gpg7 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + pwm0_out: pwm0-out { All pin configuretion node names with "-pins" suffix. Upcoming dtschema will require this. > + samsung,pins = "gpb6-1"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + pwm1_out: pwm1-out { > + samsung,pins = "gpb6-5"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c0_bus: hs-i2c0-bus { > + samsung,pins = "gpb0-0", "gpb0-1"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c1_bus: hs-i2c1-bus { > + samsung,pins = "gpb0-2", "gpb0-3"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c2_bus: hs-i2c2-bus { > + samsung,pins = "gpb0-4", "gpb0-5"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c3_bus: hs-i2c3-bus { > + samsung,pins = "gpb0-6", "gpb0-7"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c4_bus: hs-i2c4-bus { > + samsung,pins = "gpb1-0", "gpb1-1"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c5_bus: hs-i2c5-bus { > + samsung,pins = "gpb1-2", "gpb1-3"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c6_bus: hs-i2c6-bus { > + samsung,pins = "gpb1-4", "gpb1-5"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + hs_i2c7_bus: hs-i2c7-bus { > + samsung,pins = "gpb1-6", "gpb1-7"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + uart0_data: uart0-data { > + samsung,pins = "gpb7-0", "gpb7-1"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + uart1_data: uart1-data { > + samsung,pins = "gpb7-4", "gpb7-5"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + spi0_bus: spi0-bus { > + samsung,pins = "gpb4-0", "gpb4-2", "gpb4-3"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + spi1_bus: spi1-bus { > + samsung,pins = "gpb4-4", "gpb4-6", "gpb4-7"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > + > + spi2_bus: spi2-bus { > + samsung,pins = "gpb5-0", "gpb5-2", "gpb5-3"; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; > + }; > +}; > + > +&pinctrl_pmu { > + No need for empty line. > + gpq0: gpq0 { > + gpio-controller; > + #gpio-cells = <2>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel