From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4333EC54E67 for ; Tue, 26 Mar 2024 07:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UZ6ZJ1lFhxLYGXs2Jcp+DZvKFsJ+nLiF60Ym6xg8Iw8=; b=vycekp8HumkR6N ALD/O3jGcq4+jWAyJ90ZqlhbnzSUp7yY2DhD6cXU3spWlu+DxJuXLBMuwe3Mq5SmsRIda7I3BBNAg bCKRMufglp5qhkadcpdjksk0ooeqTJZlvDtv4SaXB0cpPvHYwk3dUFpm5gUZU9jaKUafebWifhIGR 0Pkb0KPgLXoEXiD5Nf3k/OoQzzwsZQJofZDDmn5UX0IhWV/J6GJkJwXOg98CdeqmLagt4Cqs1TePr 3CcjemOr2vFPUwpOhLpf01y83JJq2QBeqSPpb1ucCRw+lOU+kLE2FONZnMZQ9Vjxy/Jc/Mkdok4rr FhpXjamKELMzlgGAk6ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp10q-00000003OxS-1llc; Tue, 26 Mar 2024 07:14:24 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp10l-00000003Ow5-4A7l for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 07:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1711437260; x=1742973260; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=00WgOmyzkRllaoUEEu1uoP3kJXxqshi5oJasmpbz0Ts=; b=jQQyD3ocSGSV3fF+7ns5+orpJTc52pzjJeKQlSSwNdA1KwngGkWVFBNQ nsNG/pdGdXY5XyBMStNB1JM91Ysly8cWxbURXOkopMhWHD8phzP0pgJV8 BZko+OF+PTn1GGywCs6mzgsH85gtTj8fb4TEhfz8dz9ICEwD0C5E290Qk ArpjqqaQX8iC4bSV7Nc27q3LcCXcfh7TGPJ8w/3GqNN6G1/L67ZlEufrH Kcn4p0peYy5HuBMd1G+iVbn29yx27TqUapBkcG4gwGH3Nf6m8FcpQNble 6ONx9z2W/eaKva01qxh38vT9ghXYnl35KmMh+HRSl1cDDg+OxloolhcgO g==; X-IronPort-AV: E=Sophos;i="6.07,155,1708383600"; d="scan'208";a="36094014" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 26 Mar 2024 08:14:12 +0100 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8D4F716EDC7; Tue, 26 Mar 2024 08:14:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1711437248; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=00WgOmyzkRllaoUEEu1uoP3kJXxqshi5oJasmpbz0Ts=; b=QGOFVlBMdZoRZjKwDMSLJZIEbnb9InlFc4QS7xXIRFSfRqN2aMkk4QDZ5brjVC4d9QU+iR tu3C8x+13iQqTrv/MIfOysn7fRaEetW8+YEi8T6CInel22Ol7DAJcI/N835Q94Lx6z7Vj7 MQS1Vxm/iDP2OWZF11pl2KOYBnk5YBHw+0pcj/usj64sn7ooM9lRlx0Sbq2sS6AU39+z5t FdmCiKAFE5MFyBiN8/wiV+ANaWMa8b3fuHALyoneIkDytV/ePnwpuaSCMqBCRbmwAvKApv BrfdTqRumIdBxo4u1VlCv/cV7Ab8UQi/vHCFD63qNNjUv7B6uGTrzAkHeTz1xQ== From: Alexander Stein To: Laurent Pinchart Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Paul Elder , Adam Ford , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Marek Vasut , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mp: Add DT nodes for the two ISPs Date: Tue, 26 Mar 2024 08:14:13 +0100 Message-ID: <2929432.e9J7NaK4W3@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240325204924.GY18799@pendragon.ideasonboard.com> References: <20240325151339.19041-1-laurent.pinchart@ideasonboard.com> <4879631.GXAFRqVoOG@steina-w> <20240325204924.GY18799@pendragon.ideasonboard.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_001420_785864_E1EAAE73 X-CRM114-Status: GOOD ( 26.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Am Montag, 25. M=E4rz 2024, 21:49:24 CET schrieb Laurent Pinchart: > Hi Alexander, > = > On Mon, Mar 25, 2024 at 04:52:21PM +0100, Alexander Stein wrote: > > Am Montag, 25. M=E4rz 2024, 16:13:39 CET schrieb Laurent Pinchart: > > > From: Paul Elder > > > = > > > The ISP supports both CSI and parallel interfaces, where port 0 > > > corresponds to the former and port 1 corresponds to the latter. Since > > > the i.MX8MP's ISPs are connected by the parallel interface to the CSI > > > receiver, set them both to port 1. > > > = > > > Signed-off-by: Paul Elder > > > Signed-off-by: Laurent Pinchart > > > --- > > > Changes since v1: > > > = > > > - Fix clock ordering > > > - Add #address-cells and #size-cells to ports nodes > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 50 +++++++++++++++++++++= ++ > > > 1 file changed, 50 insertions(+) > > > = > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/b= oot/dts/freescale/imx8mp.dtsi > > > index bfc5c81a5bd4..1d2670b91b53 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > @@ -1616,6 +1616,56 @@ isi_in_1: endpoint { > > > }; > > > }; > > > = > > > + isp_0: isp@32e10000 { > > > + compatible =3D "fsl,imx8mp-isp"; > > > + reg =3D <0x32e10000 0x10000>; > > > + interrupts =3D ; > > > + clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_APB_ROOT>; > > > + clock-names =3D "isp", "aclk", "hclk"; > > > + assigned-clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP>; > > > + assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL2_500M>; > > > + assigned-clock-rates =3D <500000000>; > > > + power-domains =3D <&media_blk_ctrl IMX8MP_MEDIABLK_PD_ISP>; > > > + fsl,blk-ctrl =3D <&media_blk_ctrl 0>; > > > + status =3D "disabled"; > > > + > > > + ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@1 { > > > + reg =3D <1>; > > > + }; > > > + }; > > > + }; > > > + > > > + isp_1: isp@32e20000 { > > > + compatible =3D "fsl,imx8mp-isp"; > > > + reg =3D <0x32e20000 0x10000>; > > > + interrupts =3D ; > > > + clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_APB_ROOT>; > > > + clock-names =3D "isp", "aclk", "hclk"; > > > + assigned-clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP>; > > > + assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL2_500M>; > > > + assigned-clock-rates =3D <500000000>; > > > + power-domains =3D <&media_blk_ctrl IMX8MP_MEDIABLK_PD_ISP>; > > > + fsl,blk-ctrl =3D <&media_blk_ctrl 1>; > > > + status =3D "disabled"; > > > + > > > + ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@1 { > > > + reg =3D <1>; > > > + }; > > > + }; > > > + }; > > > + > > = > > The patch itself is okay. But you might not be able to > > configure the parent of IMX8MP_CLK_MEDIA_ISP if dewarp is enabled befor= e. > > This is due to IMX8MP_CLK_MEDIA_ISP_ROOT being enabled in 'pgc_ispdwp' > > power domain. Reparenting is not possible anymore in this case. > = > Good point. = > = > > Something like > > ---8<--- > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > @@ -1837,11 +1837,13 @@ media_blk_ctrl: blk-ctrl@32ec0000 { > > <&clk IMX8MP_CLK_MEDI= A_APB>, > > <&clk IMX8MP_CLK_MEDI= A_DISP1_PIX>, > > <&clk IMX8MP_CLK_MEDI= A_DISP2_PIX>, > > + <&clk IMX8MP_CLK_MEDI= A_ISP>, > > <&clk IMX8MP_VIDEO_PL= L1>; > > assigned-clock-parents =3D <&clk IMX8MP= _SYS_PLL2_1000M>, > > <&clk IMX8MP_S= YS_PLL1_800M>, > > <&clk IMX8MP_V= IDEO_PLL1_OUT>, > > - <&clk IMX8MP_V= IDEO_PLL1_OUT>; > > + <&clk IMX8MP_V= IDEO_PLL1_OUT>, > > + <&clk IMX8MP_S= YS_PLL2_500M>; > > assigned-clock-rates =3D <500000000>, <= 200000000>, > > <0>, <0>, <10395= 00000>; > = > With an assigned clock rate here too then ? You are right. This posted diff is what I was using for a while now though. Apparently the clock frequency was still correct. Best regards, Alexander > > #power-domain-cells =3D <1>; > > ---8<--- > > is needed. > = > Sascha, are you OK with this approach ? > = > > > dewarp: dwe@32e30000 { > > > compatible =3D "nxp,imx8mp-dw100"; > > > reg =3D <0x32e30000 0x10000>; > > > = > > > base-commit: 4cece764965020c22cff7665b18a012006359095 > = > = -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel