From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C7B0C0044D for ; Sat, 14 Mar 2020 15:09:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB7CF20774 for ; Sat, 14 Mar 2020 15:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z+hGIzNw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB7CF20774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u4kqDa8hxUMhPuX0+Wq2DjZbqXz5lJf0BYB6jLd3SyQ=; b=Z+hGIzNwx4GkJR 7E8lA2eq0q/QI9wjxdpK86Lzuj8mjuaR7LwkjkMZDjU8uRfvckj8N4VjoMJnJBsxGmg8yo1TNA9Rf qOsNz1o2QKZCRsSlA+LymR3tbcdM5Hrzpo1UbN8Y2fSLSApSsBazNXzXZtnmbJ6ocFxyxYH3MU8tu Tycw6SYTkncLWn95OfuagZ85uv15JJP1yB6Zq8STwlHkDgWhBykfIZosdWthMX5mbs9oOMa8DXskv CTIZ9xDM/ZkAfmloux17eARDYkp4ailtMsSrjwrlNpeHhAjUoRJZWMIW6qjBmwP2YVG6sG7oy8jnr MuXR3iR3fW1zqzKhmj3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jD8Pw-000587-LP; Sat, 14 Mar 2020 15:09:36 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jD8Ps-00057E-5U; Sat, 14 Mar 2020 15:09:34 +0000 Received: from ip5f5a5d2f.dynamic.kabel-deutschland.de ([95.90.93.47] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jD8Pn-0001Qn-3r; Sat, 14 Mar 2020 16:09:27 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Katsuhiro Suzuki Subject: Re: [PATCH] ARM: dts: rockchip: use DMA channels for UARTs of TinkerBoard Date: Sat, 14 Mar 2020 16:09:26 +0100 Message-ID: <2930126.sCcUyySgUU@diego> In-Reply-To: <20200314142327.25568-1-katsuhiro@katsuster.net> References: <20200314142327.25568-1-katsuhiro@katsuster.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200314_080932_578478_4B97236A X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Samstag, 14. M=E4rz 2020, 15:23:27 CET schrieb Katsuhiro Suzuki: > This patch enables to use DMAC for all UARTs that are connected to > dmac_peri core for TinkerBoard. > = > Only uart2 is connected different DMAC (dmac_bus_s) so keep current > settings on this patch. This belongs in rk3288.dtsi, as this is definitly not board-specific, as the dma-uart connection is done inside the soc. At least on arm64 (rk3328, px30, probably more) we already have the uart dmas in the core dtsi without any problems. Is there any reason why you only did add it to the tinker board only? Heiko > Signed-off-by: Katsuhiro Suzuki > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > = > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3= 288-tinker.dtsi > index 312582c1bd37..6efabeaf3c6d 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -491,10 +491,14 @@ &tsadc { > }; > = > &uart0 { > + dmas =3D <&dmac_peri 1>, <&dmac_peri 2>; > + dma-names =3D "tx", "rx"; > status =3D "okay"; > }; > = > &uart1 { > + dmas =3D <&dmac_peri 3>, <&dmac_peri 4>; > + dma-names =3D "tx", "rx"; > status =3D "okay"; > }; > = > @@ -503,10 +507,14 @@ &uart2 { > }; > = > &uart3 { > + dmas =3D <&dmac_peri 7>, <&dmac_peri 8>; > + dma-names =3D "tx", "rx"; > status =3D "okay"; > }; > = > &uart4 { > + dmas =3D <&dmac_peri 9>, <&dmac_peri 10>; > + dma-names =3D "tx", "rx"; > status =3D "okay"; > }; > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel