From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] target/cxgbit: add INET dependency
Date: Tue, 01 Mar 2016 22:21:19 +0100 [thread overview]
Message-ID: <2941855.lXKcTvDzjQ@wuerfel> (raw)
In-Reply-To: <1456810108.19657.187.camel@haakon3.risingtidesystems.com>
On Monday 29 February 2016 21:28:28 Nicholas A. Bellinger wrote:
> > diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig
> > index cf335b4dbb4e..ce6f5cca315d 100644
> > --- a/drivers/target/iscsi/cxgbit/Kconfig
> > +++ b/drivers/target/iscsi/cxgbit/Kconfig
> > @@ -1,6 +1,7 @@
> > config ISCSI_TARGET_CXGB4
> > tristate "Chelsio iSCSI target offload driver"
> > depends on ISCSI_TARGET && CHELSIO_T4
> > + depends on INET
> > select CHELSIO_T4_UWIRE
> > ---help---
> > To compile this driver as module, choose M here: the module
>
> Odd, ISCSI_TARGET already depends on NET, but I guess that's not enough
> for cxgbit.. ;)
>
The problem is that you can have CONFIG_NET=y but CONFIG_INET=n
It would probably be reasonable to make the ISCSI_TARGET option depend
on CONFIG_INET directly, which would solve the problem as well.
Arnd
prev parent reply other threads:[~2016-03-01 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 11:14 [PATCH] target/cxgbit: add INET dependency Arnd Bergmann
2016-03-01 5:28 ` Nicholas A. Bellinger
2016-03-01 7:28 ` Varun Prakash
2016-03-01 21:21 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2941855.lXKcTvDzjQ@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox