From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.
Date: Wed, 23 Sep 2015 21:36:42 +0200 [thread overview]
Message-ID: <29453556.BCB7AZ5P6c@wuerfel> (raw)
In-Reply-To: <5602CCA4.8070606@caviumnetworks.com>
On Wednesday 23 September 2015 09:00:36 David Daney wrote:
> On 09/23/2015 12:51 AM, Arnd Bergmann wrote:
> > On Tuesday 22 September 2015 17:09:56 David Daney wrote:
> >> From: David Daney <david.daney@cavium.com>
> >>
> >> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
> >> Since it is arm64, create a new quirks.c file there to contain arm64
> >> related quirks. Add the ThunderX bridge quirk, gated by a new config
> >> variable, so that it can be disabled for kernels that aren't expected
> >> to be used on ThunderX.
> >>
> >> Signed-off-by: David Daney <david.daney@cavium.com>
> >> ---
> >> arch/arm64/Kconfig | 11 +++++++++++
> >> arch/arm64/kernel/Makefile | 2 +-
> >> arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
> >> 3 files changed, 48 insertions(+), 1 deletion(-)
> >> create mode 100644 arch/arm64/kernel/quirks.c
> >>
> >
> > Looks reasonable to me. Just one question: Is the same bridge used
> > on MIPS machines?
>
> No. The MIPS64 based OCTEON family of SoCs does not contain
> PCI-buses/config-space/bridges for on-chip hardware blocks. The on-chip
> blocks in OCTEON are all platform devices. So, ...
>
> > If so, maybe it should be moved to drivers/pci/quirks.c
> > instead for better reuse.
>
> The quirk is specific to some arm64 based SoCs, thus my idea to have
> arch specific quirks.
Ok.
Arnd
next prev parent reply other threads:[~2015-09-23 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 0:09 [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges David Daney
2015-09-23 7:51 ` Arnd Bergmann
2015-09-23 16:00 ` David Daney
2015-09-23 19:36 ` Arnd Bergmann [this message]
2015-09-23 18:40 ` Will Deacon
2015-09-23 18:48 ` David Daney
2015-11-24 21:52 ` Bjorn Helgaas
2015-11-24 22:26 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29453556.BCB7AZ5P6c@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).