[PATCH 02/13] ARM: STi: DT: STiH416: Add DT node for the stih415/6 usb2 phy

Peter Griffin
2014-11-12T13:55:00Z

Hi Lee,

Thanks for reviewing.

On Mon, 10 Nov 2014, Lee Jones wrote:

> On Fri, 07 Nov 2014, Peter Griffin wrote:
>
> > This usb picophy is found on stih415/6 SoC.
>
> Then shouldn't it live in stih41x.dtsi?

No, it is the same ip block, and underlying driver, but needs a different
compatible string as it's wired up to different sysconfig registers on the SoC.

>
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> > arch/arm/boot/dts/stih416.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
> > index 1137bdf..0f3019a 100644
> > --- a/arch/arm/boot/dts/stih416.dtsi
> > +++ b/arch/arm/boot/dts/stih416.dtsi
> > @@ -316,5 +316,14 @@
> >
> > status = "disabled";
> > };
> > +
> > + usb2_phy: usb2phy at 0 {
> > + compatible = "st,stih416-usb-phy";
> > + #phy-cells = <0>;
> > + st,syscfg = <&syscfg_rear>;
> > + clocks = <&clk_sysin>;
> > + clock-names = "osc_phy";
> > +
>
> Remove this '\n'.

Fixed in v2.

regards,

Peter.