From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4FAC433DF for ; Mon, 19 Oct 2020 12:09:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 029A322268 for ; Mon, 19 Oct 2020 12:09:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uzg4yeYz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="M5/YtPqH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 029A322268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O6H0wRDqDDb1vfhUazHnbgSQV8MnY8B8cX+2TFBmwY4=; b=uzg4yeYziHIkHjj6M0UX2fCNG VRaSejCNRrYCKOrinFxLurHoxG12pT6H8d/rBu42dSATxkwqovvepgyD3P1k9Kvf5U7YY9lsj9Vmb fIwSap5zooCxKjVSbFscqZq8HAF6a3uOj/tzYYdWniYQrm4P4XqPCngAdksRtCwp8Tw0N5cOEuJAp ym3tQYMqyij4pNrzGTNV2SFRgz9V7Rj14RU84jVRLnyytNZGahVmK1Ag3pSTvL5NO2UD7GAjdOiGw GmFSJ2SFg3mgs0xHBdU0hYCUvKWn2WWSi5vwKKL2qKBMoizZ5FNi5Qi7DtHYa8qfLPz9qukr31pUW inxAjsFww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUTxH-0000gr-1Y; Mon, 19 Oct 2020 12:07:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUTxE-0000gI-E6 for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 12:07:57 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FD8022268; Mon, 19 Oct 2020 12:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603109275; bh=3noPGpjp762hGnSUK70UPaaIzFQ7lKiB2FH5eZtTlDA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M5/YtPqHbtKAUgR3DwCSgfAQrTvVxmEmF1S2YqDLubx0IY5tVxtoFsssvrSZACO+a beI8MXzHo4/ZVTJTiOsBExKnM9w5CnxFSTovxPz1GuV0u0NjeCFzhvs5uE96RIvHD+ ZCItI/8nzgIoheRq36gteJpuqNH6LkVi86aleRZ8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kUTxB-002PXG-Bu; Mon, 19 Oct 2020 13:07:53 +0100 MIME-Version: 1.0 Date: Mon, 19 Oct 2020 13:07:53 +0100 From: Marc Zyngier To: Sumit Garg Subject: Re: [PATCH v5 2/5] irqchip/gic-v3: Enable support for SGIs to act as NMIs In-Reply-To: <1602673931-28782-3-git-send-email-sumit.garg@linaro.org> References: <1602673931-28782-1-git-send-email-sumit.garg@linaro.org> <1602673931-28782-3-git-send-email-sumit.garg@linaro.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <294754db12f4cd8a8ec9329a44e1cf02@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sumit.garg@linaro.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, jason@lakedaemon.net, mark.rutland@arm.com, julien.thierry.kdev@gmail.com, dianders@chromium.org, daniel.thompson@linaro.org, jason.wessel@windriver.com, msys.mizuma@gmail.com, ito-yuichi@fujitsu.com, kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_080756_651541_040923F5 X-CRM114-Status: GOOD ( 20.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, daniel.thompson@linaro.org, jason@lakedaemon.net, catalin.marinas@arm.com, ito-yuichi@fujitsu.com, dianders@chromium.org, linux-kernel@vger.kernel.org, julien.thierry.kdev@gmail.com, jason.wessel@windriver.com, kgdb-bugreport@lists.sourceforge.net, tglx@linutronix.de, msys.mizuma@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-10-14 12:12, Sumit Garg wrote: > Add support to handle SGIs as regular NMIs. As SGIs or IPIs defaults to > a There is nothing "regular" about NMIs. Drop "or IPIs". s/defaults/default/ > special flow handler: handle_percpu_devid_fasteoi_ipi(), so skip NMI > handler update in case of SGIs. > > Also, enable NMI support prior to gic_smp_init() as allocation of SGIs > as IRQs/NMIs happen as part of this routine. > > Signed-off-by: Sumit Garg > --- > drivers/irqchip/irq-gic-v3.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3.c > b/drivers/irqchip/irq-gic-v3.c > index 16fecc0..5efc865 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -477,6 +477,11 @@ static int gic_irq_nmi_setup(struct irq_data *d) > if (WARN_ON(gic_irq(d) >= 8192)) > return -EINVAL; > > + if (get_intid_range(d) == SGI_RANGE) { > + gic_irq_set_prio(d, GICD_INT_NMI_PRI); > + return 0; > + } > + Please follow the existing control flow, or rework it to be organised by range. > /* desc lock should already be held */ > if (gic_irq_in_rdist(d)) { > u32 idx = gic_get_ppi_index(d); > @@ -514,6 +519,11 @@ static void gic_irq_nmi_teardown(struct irq_data > *d) > if (WARN_ON(gic_irq(d) >= 8192)) > return; > > + if (get_intid_range(d) == SGI_RANGE) { > + gic_irq_set_prio(d, GICD_INT_DEF_PRI); > + return; > + } Same here. > + > /* desc lock should already be held */ > if (gic_irq_in_rdist(d)) { > u32 idx = gic_get_ppi_index(d); > @@ -1708,6 +1718,7 @@ static int __init gic_init_bases(void __iomem > *dist_base, > > gic_dist_init(); > gic_cpu_init(); > + gic_enable_nmi_support(); > gic_smp_init(); > gic_cpu_pm_init(); > > @@ -1719,8 +1730,6 @@ static int __init gic_init_bases(void __iomem > *dist_base, > gicv2m_init(handle, gic_data.domain); > } > > - gic_enable_nmi_support(); > - > return 0; > > out_free: Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel