public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] clk/exynos5420: assign dout_pixel id to pixel clock divider
Date: Tue, 27 Aug 2013 01:49:29 +0200	[thread overview]
Message-ID: <2957212.KZ8HRQb1uk@flatron> (raw)
In-Reply-To: <1377508383-15185-6-git-send-email-rahul.sharma@samsung.com>

Hi Rahul,

On Monday 26 of August 2013 14:43:03 Rahul Sharma wrote:
> dout_pixel is a new ID allocated for pixel clock divider. It is
> queried in the driver to pass as the parent to hdmi clock while
> switching between parents.
> 
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  Documentation/devicetree/bindings/clock/exynos5420-clock.txt |    5
> +++++ drivers/clk/samsung/clk-exynos5420.c                         |   
> 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/clock/exynos5420-clock.txt
> b/Documentation/devicetree/bindings/clock/exynos5420-clock.txt index
> 6f16aa8..4c069bd 100644
> --- a/Documentation/devicetree/bindings/clock/exynos5420-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/exynos5420-clock.txt
> @@ -187,6 +187,11 @@ clock which they consume.
> 
>    mout_hdmi		1024
> 
> +  Divider		ID
> +  ----------------------------
> +
> +  dout_pixel		2048

That's an even bigger hole.

Could you check in the documentation how many muxes are present in the 
clock controller of Exynos5420, add some margin (presumably rounding up to 
some nice value, not necessarily to a power of two) and calculate a more 
reasonable start value for dividers?

Best regards,
Tomasz'

      reply	other threads:[~2013-08-26 23:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26  9:12 [PATCH v3 0/5] clk/exynos5420: add clocks for hdmi subsystem Rahul Sharma
2013-08-26  9:12 ` [PATCH v3 1/5] clk/exynos5420: add sclk_hdmiphy to the list of special clocks Rahul Sharma
2013-08-26  9:13 ` [PATCH v3 2/5] clk/exynos5420: add gate clock for mixer sysmmu Rahul Sharma
2013-08-26  9:13 ` [PATCH v3 3/5] clk/exynos5420: fix the order of parents of hdmi mux Rahul Sharma
2013-08-26  9:13 ` [PATCH v3 4/5] clk/exynos5420: add hdmi mux to change parents in hdmi driver Rahul Sharma
2013-08-26 23:46   ` Tomasz Figa
2013-08-27  4:44     ` Rahul Sharma
2013-08-28 11:55       ` Tomasz Figa
2013-08-29  3:22         ` Rahul Sharma
2013-08-26  9:13 ` [PATCH v3 5/5] clk/exynos5420: assign dout_pixel id to pixel clock divider Rahul Sharma
2013-08-26 23:49   ` Tomasz Figa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2957212.KZ8HRQb1uk@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox