From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE19EC27C76 for ; Wed, 25 Jan 2023 08:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x7DR0Q4xoUjqvggoT0Pk407iuhy9V/KQmaNFHGjOWzw=; b=KJX2HuOoApY2Nj E4U7WRMNxc39ooLqfiqeFeeGaHugUoOO5EM2bM0YAN0RfaAijqb6CS79vfMf5ZQQAWarGj72II640 gHcrpwuYhOHOtwHaD9FyYWif0Ti7SKUlV2LQXKScdfFpnoetmYnIKzkOEszk+SZY44rQ0mPJb9syZ 24Vj/IeZtpXETWtvnxhSXconKMuD/TaZYJBnJKRClOqyoaAYWDMJdtX81+EyBK0Zoji/BavPeBAy0 q4xgR8/8WXNzM1OvPbu34Cw18zLTyKCdvj1nBEk8YZjzEHL8UCPTDQmONGxxkK9oeBUuti5wrofoc cBWTwClzLYqPF0iK/Fiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKbCI-006RHW-Az; Wed, 25 Jan 2023 08:31:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKbBE-006Qtz-5W for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 08:30:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674635449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kr0S8akD6qUBjK/SM2fF6lu+0ihmEwSHU9fQtaMUMNo=; b=Mppe5nNW1QLUDULW9Qak8LiKCeBvmtQH++BkMM5gFXY3U+gc+JJhkcFQMI/RjYNbYcW/rY x3PWWdmuOMUvDuoAKVErx5fFepgK6UPXRsH7O+jiYX/e39gWDBbG1HMiKkQa1h308yJGsO LmpMIwqVaWChTLl8DViWrAyF2pXD2EI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-651-m5Q6SmtrNICzgGJX7FSY9Q-1; Wed, 25 Jan 2023 03:30:45 -0500 X-MC-Unique: m5Q6SmtrNICzgGJX7FSY9Q-1 Received: by mail-wr1-f72.google.com with SMTP id t20-20020adfba54000000b002be0eb97f4fso2976248wrg.8 for ; Wed, 25 Jan 2023 00:30:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kr0S8akD6qUBjK/SM2fF6lu+0ihmEwSHU9fQtaMUMNo=; b=Uh8tVKyrphvm6RZehEWp7tIH0lfIsVfK7JFUj9SXw9El0bIdGwzY0PxHptBEej+3WA IF6MJ8YAN3nTRtOapzX5iiyokpeZeogGR7DRrXtoFfjz9vIM2b9HsmGY2V1wIguNiDx0 XHSfWHrNm7wi6+luIVLwjFW2MyzcNupjy1/OExxNACyAHsCxey/vcIdINMCbEnb4XIPS WsWYfP/tkWM6heKdlCTojaMXw5cqNIrPR3zBDwkSJTaA1G5O4ehhmwwNN56pY15I3c7k wnYuMOa6DVV6cCP3aZKc6V2Vgaz0Ujz+OD222N7KNisq+Xnn7hC8ZJXvH+/HDejjj/Nj +b+A== X-Gm-Message-State: AFqh2kpDIq50xI5I617IbikDfz+Uv3+1ComF9da12CTPBehaXNE3xxZe GPfeIGGTfwJSSSJD6TQ6ItAb3Os2bXu6Mz/w1dQEzpwdlvTEYVr4BqQhljvIjBX6AfVHK839nXA 5sRnjjUCVEqOP/MQvZAubn8UtFWxIDmR2rdM= X-Received: by 2002:a05:6000:388:b0:2bc:7ec3:8b2 with SMTP id u8-20020a056000038800b002bc7ec308b2mr29736114wrf.68.1674635444578; Wed, 25 Jan 2023 00:30:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXvJXEPl3F4VP/2Wui1NMuiLkn1RDtzF7t2lLspd9Qgz+v3EiIOxwRmTCt+QhhFH4DIAkfWI6g== X-Received: by 2002:a05:6000:388:b0:2bc:7ec3:8b2 with SMTP id u8-20020a056000038800b002bc7ec308b2mr29736083wrf.68.1674635444065; Wed, 25 Jan 2023 00:30:44 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id n17-20020a5d67d1000000b002425be3c9e2sm3716862wrw.60.2023.01.25.00.30.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 00:30:43 -0800 (PST) Message-ID: <296bcff0-9d75-3d6b-e101-dddb26edadf1@redhat.com> Date: Wed, 25 Jan 2023 09:30:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 01/10] drm/client: Test for connectors before sending hotplug event To: Thomas Zimmermann , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org References: <20230124134010.30263-1-tzimmermann@suse.de> <20230124134010.30263-2-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20230124134010.30263-2-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_003052_353025_9EF7E158 X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Thomas, On 1/24/23 14:40, Thomas Zimmermann wrote: > Test for connectors in the client code and remove a similar test > from the generic fbdev emulation. Do nothing if the test fails. > Not having connectors indicates a driver bug. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas but I've a question below. > drivers/gpu/drm/drm_client.c | 5 +++++ > drivers/gpu/drm/drm_fbdev_generic.c | 5 ----- > 2 files changed, 5 insertions(+), 5 deletions(-) [...] > --- a/drivers/gpu/drm/drm_fbdev_generic.c > +++ b/drivers/gpu/drm/drm_fbdev_generic.c > @@ -389,11 +389,6 @@ static int drm_fbdev_client_hotplug(struct drm_client_dev *client) > if (dev->fb_helper) > return drm_fb_helper_hotplug_event(dev->fb_helper); > > - if (!dev->mode_config.num_connector) { > - drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n"); > - return 0; > - } > - What about the following code snippet: if (!drm_drv_uses_atomic_modeset(dev)) drm_helper_disable_unused_functions(dev); that seems to be something that should be in the core client dev hotplug as well, since it isn't specific to the fbdev emulation client ? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel