From: Marek Vasut <marex@denx.de>
To: Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] soc: imx: gpcv2: Synchronously suspend MIX domains
Date: Mon, 18 Oct 2021 14:11:45 +0200 [thread overview]
Message-ID: <296dce79-db6c-752d-209b-c8e52f676474@denx.de> (raw)
In-Reply-To: <03b44ecca330759a427ed748a24dafac03cdb2c1.camel@pengutronix.de>
On 10/17/21 9:40 PM, Lucas Stach wrote:
> Am Samstag, dem 16.10.2021 um 23:05 +0200 schrieb Marek Vasut:
>> In case the following power domain sequence happens, iMX8M Mini always hangs:
>> gpumix:on -> gpu:on -> gpu:off -> gpu:on
>> This is likely due to another quirk of the GPC block. This situation can be
>> prevented by always synchronously powering off both the domain and MIX domain.
>> Make it so. This turns the aforementioned sequence into:
>> gpumix:on -> gpu:on -> gpu:off -> gpumix:off -> gpumix:on -> gpu:on
>>
> Did you test this with the reset sequence fixed? 2b2f106eb552 (Revert
> "soc: imx: gpcv2: move reset assert after requesting domain power up")
> in Shawns tree.
It is also in next, so yes.
> I don't like that this is slowing down the power-down sequence and I'm
> not sure if it's required for the other domains, or if this is again a
> GPU domain specific issue.
That's why I CCed NXP, they might provide clarification.
> However, if it's fixing a hang that isn't
> solved by the proper reset sequence, I would say better safe than
> sorry, and we can always optimize this later if possible.
I have this feeling we will be optimizing them until we end up keeping
them on all the time, because of the constant quirks ... I hope I am
wrong about this.
> Under the assumption that it's required even with the proper reset
> sequence:
> Acked-by: Lucas Stach <l.stach@pengutronix.de>
[...]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-18 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 21:05 [PATCH] soc: imx: gpcv2: Synchronously suspend MIX domains Marek Vasut
2021-10-17 19:40 ` Lucas Stach
2021-10-18 12:11 ` Marek Vasut [this message]
2021-11-21 2:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=296dce79-db6c-752d-209b-c8e52f676474@denx.de \
--to=marex@denx.de \
--cc=frieder.schrempf@kontron.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox