From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2183C433F5 for ; Mon, 18 Oct 2021 12:13:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CC7E60FC3 for ; Mon, 18 Oct 2021 12:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8CC7E60FC3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l/bU7h+GmhJIGrt1R5YMT0E2gnnKYIAon4ES/npfFv8=; b=DlIgOySsq/l6CB4/pCykBkjPPm OizpECnMeIK/pBQhz/JV6NUQ9I6efPwcTymaEVjcsfMsKCnOMGuKPwmBlV5nGIT+Y95VCmiQipUBe zjny0YmpV8sGzzzdN8b14UiZXmjsEyT+6LzcIaQb5bNRKUI3kYnkX0dstPfGNHLLEwD7tMDyOxDDx /OETaokn54Pw6q5b/lT4sjfNKmWYm00Ptd8odqzIhecsbzNDYzsvlgn9vV7vDLei6wBixv94vtZgr qL+Wydd6WATGT2OpoGazGJi7rtE1xOlSZIajRGnFK6m0xY4XM6Z4aC2B0R/XmixY9wJTQXad1FJBQ w/agfQSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcRUf-00FaqL-OQ; Mon, 18 Oct 2021 12:11:53 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcRUb-00Fapw-SM for linux-arm-kernel@lists.infradead.org; Mon, 18 Oct 2021 12:11:51 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 52353833F2; Mon, 18 Oct 2021 14:11:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634559106; bh=1ha8AiXGf0lMhIZgYec99Y5CKmfUmHpsqQ1l3aWNouI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=G2U/TQ0tdaavvmh6NhOnqAcF+FNDbPu0obMt+e5aUXjUWJfkmrRWk0TigPZW0Y0jQ tpyfn7jD3k8hQn2cUqlJHK688qrHbR3wB1gK7apiOVdF7PkxK+IlInGF1HH2M+hoxb bSTcMMh9LfglWffPZdwIjgtoz7BQtw9e9bwdnTgdOSGchlpkUKVF8WqEwgGGvIEJNZ Ayr012888II0NsjnPOlEtgihi+syV0j79VGG3OfFLx/UZfxJ5A7TM9PpG6Du86jmca bHqYM68Q03lIMdBXMC+tFlVuRUp84pvLx69cfWiC8Bl2BowKkncXXOPWVCmJfb+UHx BTJabTijuGLZw== Subject: Re: [PATCH] soc: imx: gpcv2: Synchronously suspend MIX domains To: Lucas Stach , linux-arm-kernel@lists.infradead.org Cc: Frieder Schrempf , NXP Linux Team , Peng Fan , Shawn Guo References: <20211016210547.171717-1-marex@denx.de> <03b44ecca330759a427ed748a24dafac03cdb2c1.camel@pengutronix.de> From: Marek Vasut Message-ID: <296dce79-db6c-752d-209b-c8e52f676474@denx.de> Date: Mon, 18 Oct 2021 14:11:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <03b44ecca330759a427ed748a24dafac03cdb2c1.camel@pengutronix.de> Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_051150_120636_B71CC333 X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/17/21 9:40 PM, Lucas Stach wrote: > Am Samstag, dem 16.10.2021 um 23:05 +0200 schrieb Marek Vasut: >> In case the following power domain sequence happens, iMX8M Mini always hangs: >> gpumix:on -> gpu:on -> gpu:off -> gpu:on >> This is likely due to another quirk of the GPC block. This situation can be >> prevented by always synchronously powering off both the domain and MIX domain. >> Make it so. This turns the aforementioned sequence into: >> gpumix:on -> gpu:on -> gpu:off -> gpumix:off -> gpumix:on -> gpu:on >> > Did you test this with the reset sequence fixed? 2b2f106eb552 (Revert > "soc: imx: gpcv2: move reset assert after requesting domain power up") > in Shawns tree. It is also in next, so yes. > I don't like that this is slowing down the power-down sequence and I'm > not sure if it's required for the other domains, or if this is again a > GPU domain specific issue. That's why I CCed NXP, they might provide clarification. > However, if it's fixing a hang that isn't > solved by the proper reset sequence, I would say better safe than > sorry, and we can always optimize this later if possible. I have this feeling we will be optimizing them until we end up keeping them on all the time, because of the constant quirks ... I hope I am wrong about this. > Under the assumption that it's required even with the proper reset > sequence: > Acked-by: Lucas Stach [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel