From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs.
Date: Wed, 25 Nov 2015 21:09:15 +0100 [thread overview]
Message-ID: <2971730.8fz1SdakMA@wuerfel> (raw)
In-Reply-To: <5656149D.50704@caviumnetworks.com>
On Wednesday 25 November 2015 12:05:49 David Daney wrote:
>
> Somebody should make a decision about this point.
>
> Here is what happens:
>
> 1) A driver for non-generic PCI host bridge is submitted.
>
> 2) Comments are received stating that it is just another PCI host
> bridge and please use pci-host-generic instead.
>
> 3) Patches to pci-host-generic are submitted.
>
> 4) Comments are received stating that pci-host-generic is for generic
> things only, and please create a device specific driver.
>
> 5) goto 1
I'm pretty sure the comments were along the lines of
1) a driver was submitted stating that it was for an SBSA-compliant
platform
2) The reply was that you don't need a driver for that and just use
the generic driver, as that is the point of SBSA
3) it turns out the hardware is nonstandard after all and so it needs
its own driver.
> > It's easy enough to split out the common parts if we want to reuse
> > some of this, or to move them into drivers/pci/*.c for others to
> > reuse too.
> >
>
> If we do that, do you want "pci-host-cam-generic" and
> "pci-host-ecam-generic" split out too?
>
> They are two completely different things crammed into the single
> pci-host-generic driver source file. Or is there some set of config
> access methods that are sufficiently generic that they can stay?
Those two are part of the PCI standard, they are obviously generic
because any mmconfig compliant host bridge will work with one or the
other.
Arnd
prev parent reply other threads:[~2015-11-25 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 0:56 [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs David Daney
2015-09-29 7:42 ` Arnd Bergmann
2015-09-29 16:03 ` David Daney
2015-11-25 17:06 ` Bjorn Helgaas
2015-11-25 17:26 ` David Daney
2015-11-25 19:52 ` Arnd Bergmann
2015-11-25 20:05 ` David Daney
2015-11-25 20:09 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2971730.8fz1SdakMA@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox