From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCD5C433DB for ; Wed, 6 Jan 2021 17:50:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3791C2311B for ; Wed, 6 Jan 2021 17:50:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3791C2311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pGothxjl48l3jukshvZu4H+UuErmfyyzmYJm11P2lNg=; b=IWnu0QxzcBEVQ72xcu/QBZ6WS GAtxLe7f58mjfN4N+rs7FKbDzJUOwndF2Iit63ph8ekhO2FZQlkKHsivBaoMaybwUjQW5oFDn538+ e+fee6CVQleYTqdVTps+wqhnv+53/Mc0d2dr9fFtKjsKrg+M12DHdrmfk7PNwH4K9yAitL8Ol7kJ0 tBN6r0ilDRF5tKGs7iAiSgDiRFvXRznPRetEONUKOQAiwef/c2pvaogt0zy8hevlTHAruPDxpckle RFF0//cEQg/szM3vOhjBV5zV0VuBC9ktlxgRAXmUziP0b/eEJvnAbuNHjqcb2nBQxWk9c07o/b9Xn EMc2tX1pA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCui-0006OP-7c; Wed, 06 Jan 2021 17:48:04 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCuf-0006Ns-BH for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 17:48:02 +0000 Received: by mail-ej1-x629.google.com with SMTP id t16so6058468ejf.13 for ; Wed, 06 Jan 2021 09:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IGY7/SPZqlhfzimwK9zIX4GmCaCBvqq2AJVtpbzpQ5s=; b=eaTLHJM7ITvqDCpMKNycI2E8rrcp1NBR4Iv3hQ9WhhMlEihcyC7rDtMCipqCgwNzHr cQ/SUdZLiaIHE7M7oRlL4jb7fQ0fJ1Lm1EZQyJgtbCwG5QHXkJ1Z0O18TLLgEhumaUgE GUkeHx0feO0t2HnHaC0AOvfFP/bqOJsJa0A/pTNIq/EjjwqDWmap0H158F0Yv1HBf7/2 CbLgxxx6tCNAsA37Q1VMcsSW5Dxyt+xBLvNW/00VjVYJVLNDU+cgYHgirGwnSbaWMKUF Y2lWdi5K4K5MoP9/D1xZ8inR18dljhpPDRoYx0cBA8Kf87kNOrVmcG//yWUDTR/MHMU+ bFPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IGY7/SPZqlhfzimwK9zIX4GmCaCBvqq2AJVtpbzpQ5s=; b=L3Ii99HSV+Nnv5ghpVGHgtum8m0TRBsEocHe/pkJYcjnx5abmzPwu3NbClfGLgFt0O NwkOuT3yczjs3c7zZcmknJkV9UaZjN1yGg40VPuQW5a7hVnefcCQbK8Ptri7IIRCZ8gN NRkqGNy6mmSwlvkmIpjKNUCKe0PZtRIC9TpuuDnyCzcpBenGfOYIRJ/sNVQYTbAh3UnY Rkge5+4SWlOwlIvvwM6dkCT+I7yTfGGPZbLU3jZAPWxFphKxe5TKUVRYOU6Sf+wHu6Hg 6Me10V+QLi+tzfm5UG3WUZWTqmfWVwzYEsBNceu3aFUB4GMVLTgZRj/JQj7h4qgFwh1a u+gw== X-Gm-Message-State: AOAM5306aSeGVoI/Fy5hPImh1eCpfx3ivMvj8s6XZHs44IlCuquTtctC RSMudMgE/wUh4BluRg+h/w8= X-Google-Smtp-Source: ABdhPJyyVMZKqQNBBrjTGQENxqC0tOeWGnnfGvrShGZYkXODVDPN+il+hAD54F5fnYFhQUWOwtTy+Q== X-Received: by 2002:a17:906:2ccb:: with SMTP id r11mr3651863ejr.39.1609955280095; Wed, 06 Jan 2021 09:48:00 -0800 (PST) Received: from ?IPv6:2003:ea:8f06:5500:e1db:b990:7e09:f1cf? (p200300ea8f065500e1dbb9907e09f1cf.dip0.t-ipconnect.de. [2003:ea:8f06:5500:e1db:b990:7e09:f1cf]) by smtp.googlemail.com with ESMTPSA id x16sm1536046ejb.38.2021.01.06.09.47.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 09:47:59 -0800 (PST) Subject: Re: [PATCH v2 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk' To: Bjorn Helgaas References: <20210106173725.GA1316633@bjorn-Precision-5520> From: Heiner Kallweit Message-ID: <297679ab-6a72-7f99-6b72-9b26675342cf@gmail.com> Date: Wed, 6 Jan 2021 18:47:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210106173725.GA1316633@bjorn-Precision-5520> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_124801_407668_2FC7B8BB X-CRM114-Status: GOOD ( 21.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Realtek linux nic maintainers , "linux-pci@vger.kernel.org" , Russell King - ARM Linux , "netdev@vger.kernel.org" , Bjorn Helgaas , Jakub Kicinski , David Miller , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06.01.2021 18:37, Bjorn Helgaas wrote: > On Wed, Jan 06, 2021 at 12:05:41PM +0100, Heiner Kallweit wrote: >> Use new PCI core function pci_quirk_broken_parity(), in addition to >> setting broken_parity_status is disables parity checking. > > That sentence has a typo or something so it doesn't read quite right. > Maybe: > > Use new PCI core function pci_quirk_broken_parity() to disable > parity checking. > OK, let me adjust this in a v3. > "broken_parity_status" is basically internal to the PCI core and > doesn't really seem relevant here. The only uses are the sysfs > store/show functions and edac. > >> This allows us to remove a quirk in r8169 driver. >> >> Signed-off-by: Heiner Kallweit >> --- >> v2: >> - remove additional changes from this patch >> --- >> arch/arm/mach-iop32x/n2100.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c >> index 78b9a5ee4..9f2aae3cd 100644 >> --- a/arch/arm/mach-iop32x/n2100.c >> +++ b/arch/arm/mach-iop32x/n2100.c >> @@ -125,7 +125,7 @@ static void n2100_fixup_r8169(struct pci_dev *dev) >> if (dev->bus->number == 0 && >> (dev->devfn == PCI_DEVFN(1, 0) || >> dev->devfn == PCI_DEVFN(2, 0))) >> - dev->broken_parity_status = 1; >> + pci_quirk_broken_parity(dev); >> } >> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REALTEK, PCI_ANY_ID, n2100_fixup_r8169); >> >> -- >> 2.30.0 >> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel