From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>, arm@kernel.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] clocksource/drivers/ixp4xx: Drop ifdef
Date: Mon, 6 May 2019 11:11:33 +0200 [thread overview]
Message-ID: <297a0b9b-fbd2-4a35-12bb-2cfdecf3d196@linaro.org> (raw)
In-Reply-To: <20190506063109.3072-1-linus.walleij@linaro.org>
On 06/05/2019 08:31, Linus Walleij wrote:
> As the sched_clock registration was put inside an ifdef
> in the driver, but this is not appropriate, the ifdef
> is only appropriate for delay_timer, which is not yet
> implemented.
>
> Fixes: 13e0b4059b98 ("clocksource/drivers/ixp4xx: Add driver")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> ARM SoC folks: please apply this directly on the IXP4xx
> branch where the IXP4xx rework is pending for v5.2.
> ---
> drivers/clocksource/timer-ixp4xx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-ixp4xx.c b/drivers/clocksource/timer-ixp4xx.c
> index 404445bc11ea..5c2190b654cd 100644
> --- a/drivers/clocksource/timer-ixp4xx.c
> +++ b/drivers/clocksource/timer-ixp4xx.c
> @@ -222,9 +222,7 @@ static __init int ixp4xx_timer_register(void __iomem *base,
> clockevents_config_and_register(&tmr->clkevt, timer_freq,
> 0xf, 0xfffffffe);
>
> -#ifdef CONFIG_ARM
> sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq);
> -#endif
>
> return 0;
> }
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-06 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 6:31 [PATCH 1/3] clocksource/drivers/ixp4xx: Drop ifdef Linus Walleij
2019-05-06 6:31 ` [PATCH 2/3] soc: ixp4xx: qmgr: Fix an NULL vs IS_ERR() check in probe Linus Walleij
2019-05-16 6:21 ` Olof Johansson
2019-05-06 6:31 ` [PATCH 3/3] ARM: ixp4xx: Remove duplicated include from common.c Linus Walleij
2019-05-16 6:22 ` Olof Johansson
2019-05-06 9:11 ` Daniel Lezcano [this message]
2019-05-16 6:21 ` [PATCH 1/3] clocksource/drivers/ixp4xx: Drop ifdef Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=297a0b9b-fbd2-4a35-12bb-2cfdecf3d196@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=arm@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox