From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E110C531C7 for ; Thu, 23 Jul 2026 09:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Pr9th7Q/0UArs0i/KXSaVLwzvEgsB6lvyrr/8f4KOw=; b=Hg7KU2NS9W7TU0kDIIh7s3rNDL 1UFKyJc7Y66ZyGP/lwYHURudM5iGw3pFbOGiRJZJuI4TUrBtUW/Q80uLejXNfY1TTXKWG93CGOCOv J15ovpc9huxB9RH27Ugl0WdFtMMO25QiQDerJ65hmITRRhKtJZJ/c3bQmvSNc8P+mtumUTJPUA+hw 4p0kqbhOQ7UiaqNPxVYLMP+65P9347DAhdcjtEDrDUgTi6OdrY4mPo2qOX6nDx2rEwjqiW5J2Tsn2 +Ooj0W3zBlIQVJ0lWi1BiS7TJu5AFjQqPesae9X0x8cT1iHgFcg7wmU5b1J6eAZ1WAhNaWpBECNBn 0kqSDC0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmpUA-0000000Dodn-163s; Thu, 23 Jul 2026 09:12:58 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmpU7-0000000Docw-1Ds3; Thu, 23 Jul 2026 09:12:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1784797972; bh=NEmV2fqvR/cLJUCeISN7mSdpl+4odir3BIdW8hvoBrI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=h3U2hpK6Vq/y18j2Z7pwLk5QmUsUccohgcjBkxw/kU/h0qX1QPgLGv4oZSIQqFZ1D Y//0Qz4e3IkZYS/7JZLaitvt8JBEpCPVK0icmtYBCGjr4x8SrsN9BCmefDN4p8vRC4 Mkr+mafYgJv9P/+vc1qLayZ56jFRW7P+KYiA4eozVIVj7B6R8UzOiOOqnMhbQIYAOv WNQNPt/DQE/CA6dXVk3uFtC67UhwsOixY9QhfNdKLxLsHfiwyqqQeRztlfqU7IpbZi LF6US/IlmDwrfR0Hfy8S3kwoRwH2yFmHyvNb7RBm3/XsBc03DO+SWacrCeoZrxNT8Y LiWeMlPEJRLVg== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6E5CE17E0018; Thu, 23 Jul 2026 11:12:51 +0200 (CEST) Message-ID: <297c6368-5ca3-456b-8e6c-bc8cd5cf48cb@collabora.com> Date: Thu, 23 Jul 2026 12:12:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 46/61] drm/rockchip: rk3066_hdmi: Advertise HDMI 1.4 capabilities To: Diederik de Haas , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Algea Cao , Daniel Stone , Liu Ying , Phong LE Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org References: <20260723-dw-hdmi-qp-scramb-v9-0-4fb12ea22ac9@collabora.com> <20260723-dw-hdmi-qp-scramb-v9-46-4fb12ea22ac9@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260723_021255_503130_16F00ADA X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Diederik, On 7/23/26 12:02 PM, Diederik de Haas wrote: > Hi Cristian, > > On Thu Jul 23, 2026 at 3:35 AM CEST, Cristian Ciocaltea wrote: >> Bridges using DRM_BRIDGE_OP_HDMI are now expected to also provide a >> supported HDMI version. This is not yet enforced, but will become >> mandatory once the migration to the new caps-based HDMI connector >> initialization API is completed. >> >> The RK3066 HDMI TX supports HDMI 1.4a, as described in commit >> f84d3d37b7fb ("drm: rockchip: introduce rk3066 hdmi"). However, the >> driver does not currently enforce a maximum TMDS character rate, it only >> filters non-CEA modes and excludes VIC 1 (640x480) via the .mode_valid >> callback. >> >> Advertise HDMI 1.4 support for now so that modes exceeding the 340 MHz >> TMDS limit are rejected by the core. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c >> index f28d6a883e09..c080abe676c4 100644 >> --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c >> +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c >> @@ -14,6 +14,7 @@ >> #include >> >> #include >> +#include >> #include >> #include >> #include >> @@ -712,6 +713,7 @@ rk3066_hdmi_register(struct drm_device *drm, struct rk3066_hdmi *hdmi) >> hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA; >> hdmi->bridge.vendor = "Rockchip"; >> hdmi->bridge.product = "RK3066 HDMI"; >> + hdmi->bridge.supported_hdmi_ver = HDMI_VERSION_1_3; > > Is this correct or should this be HDMI_VERSION_1_4 ? > In the other 'Advertise HDMI N.M capabilities' patches, there is a (direct) > match between the version mention in the commit summary and the > supported_hdmi_ver property, but not here. This is indeed a mismatch between the commit description and the actual code changes. It has no functional impact, as HDMI 1.3 and HDMI 1.4 are equivalent in terms of the maximum supported TMDS character rate, which is what we currently infer. I'll set it to HDMI_VERSION_1_4 in the next revision. Thanks, Cristian