From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A050AC433EF for ; Tue, 14 Jun 2022 09:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=50dbwaJVqWhf37v2kwehrHerpzpt2bEAshXvjfGGnfw=; b=iKLpVqX8Qv8X1V 8ur1WIpvlRIOHGz+T2r2Rcynv3jvPe5w/YqCHwq0ABZmhIrg5K6HL3fdoMcBwAZHZUpPFWOOEQd9Y EVy30+FYQ5H2RU4E39b5BIMKpb0BTZ6dBmt5n1Nz9IpMF7khpg0NXQAfcOvjp3v9JX24AmybBJd6y Li2UCdvgvJXy92rFFIQtXKlF2azp4MzIgiRx2XVO4JdkLo46lUifYu8HvrXeeh362InXmECCqB1S7 nknyA9AZydCfqPfw/ljaaMr1w7MZD9xjBijLksWfqNB+yGLWx8dsIj4sO1dUG2ZywYzIDiZmg2nZ/ P4OxlipW36pIDuFqryPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12W8-008Y8Q-10; Tue, 14 Jun 2022 09:07:21 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12Fg-008PGm-Lm for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 08:50:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1655196620; x=1686732620; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=tPc0IrgKz20P5AwzixTnKu9z43B1Bimpi40DrNJmtX8=; b=1qVji0aqvIxwKxWHV0yJWa/Np8sQRDfbt5KV6w3p9Mivbm0NcazEfgHF NVyVc3c4v3OA0VqSdrmBZtmzkA8kD8+poI0uO+irv13T7IVDY4bJ7tkYZ h137ByM0lkSMZ32VLoLwUs/jp78TDvZ5LoYELSKrmrEb2VIh7mogTsL4r lEvi8PqI5hdL0qT2h7b33TBP4xzU1oQ4rpVWtB6aqWlfDfrVghYXyMBpK 0hkmvPeZJe8M6yhIU20I33zOiF5gc3TeV6rgXhbWRLp/5uVfvyvJrqhyC uKZx6uDpe8yw+yXuMokMfnZa2D+72xsI4q3B/AJ9vJTZ4UI64RcYk8zI0 g==; X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="168327102" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 Jun 2022 01:50:19 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 14 Jun 2022 01:50:19 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Tue, 14 Jun 2022 01:50:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E8OR8tu90X/MAZhGnywxeRV5mtjmcwUoPK1SfKu3n+3cr3L/NpGorfLzOSb2HFy9kyJHtZPd35DgvubYZ8viO1QDOA+KWBV9F+zbC0FPk9WY2EtZbV/UaRATcYm3puL07hFpeV1wheDG7NXzxj/cxLAxK9dV6txEkhCpY79MJ2qx9f+aGQ/OIsX8PeXaurKnZDqIaoLnjYHhaaHl8UXvW2SCowFivNJ0rGnYGq9MKt+zNlWekEjTJrN/rC4l6l/POKASmnD6laNVj1cTHxjzJmMRbIXvcLdIzG3aaYCZxHvjj8euxLJjhhAqDTj3RK81/5ydZ+fwAeSqZcFdd/NVjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPc0IrgKz20P5AwzixTnKu9z43B1Bimpi40DrNJmtX8=; b=D+pF4Sg9YPecTO9gaSeWbyINglK1rQnJIlzIEQtpAC5iPHQet1Kdj8y11kGoTwfqumMzJLRFK/ju9FdN04062MVqZECVZcbV+vSkwZiz6bGxMzwjVvtlIoIrwboPcSbcQ7qvL/3GKU7TkEaryJjiSBqGV3eaOwWww8rS5Z/5i7vv416zhllpwcZEYgM+gloUOyf/fMcvjDVkAIfUqvBlDeIl/tsSGbF7ss2AeYKPB4x5xOpPg0Iu0sX5vzIJfWOfuIap9vliB2btb+ukkFiQsQK6oUDR0uG72beA5HUbnmyONd1asxlz6KjhMJBEnu+ktHx2k2jF5CvtoTlJZ9YFlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPc0IrgKz20P5AwzixTnKu9z43B1Bimpi40DrNJmtX8=; b=s53eaHdXvSdJsoCR6OMqoZZSJRDfriq/DcoDj4NxLMGX5JJaDRZQAjvXxScQjExkHBgiYzcytAubqgKo9o5fSiI1q9Jf4tIG9Vfb0pUInaR4DOL3NxQT1PvlfLouSke4/pCusdr+vMR69aJKlF6KJ6a3wBcJhiaxRf+q2cl1RbI= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by SJ1PR11MB6276.namprd11.prod.outlook.com (2603:10b6:a03:455::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Tue, 14 Jun 2022 08:50:14 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8%3]) with mapi id 15.20.5332.022; Tue, 14 Jun 2022 08:50:14 +0000 From: To: Subject: Re: [PATCH 11/16] iio: adc: at91-sama5d2_adc: add locking parameter to at91_adc_read_info_raw() Thread-Topic: [PATCH 11/16] iio: adc: at91-sama5d2_adc: add locking parameter to at91_adc_read_info_raw() Thread-Index: AQHYf8vDnSSymt/QDEuUTLKV0A4wdA== Date: Tue, 14 Jun 2022 08:50:14 +0000 Message-ID: <2989a8a5-b350-aac1-dcfb-249ac5bb23aa@microchip.com> References: <20220609083213.1795019-1-claudiu.beznea@microchip.com> <20220609083213.1795019-12-claudiu.beznea@microchip.com> <20220611185851.4d266d5e@jic23-huawei> In-Reply-To: <20220611185851.4d266d5e@jic23-huawei> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 33c09b59-e7f3-41c6-99fe-08da4de2e630 x-ms-traffictypediagnostic: SJ1PR11MB6276:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qjSkaD/uhJfJzdCMnAgJnkZJTISPVv7mD9mabgpo2ELuJ2zkmxXDLTutttNxUz/xuM8/sJr18x3NJs3HXrta1513dfEHnRTcWWEA0uVWkgILSdmEpbUKnTui113acNZe9iIXqsZ+BzKEt7GD0w1r9QKm7t/h0A8OXwPXRefGVCMyTbOp+9jHDfZ1jOvj5439paQzQFYeTyMh5fLWXZGPQNFJHEXiRsPhc62M0jwgI8SBq0+wPwSklILyZl5qq88fYADwtf2wdyGPpEURBSACcIK/j9B6hQH/o7/JEAizBje/qE8+K4SrwYy9N/P0IX/JXhhfb7qK/xOmc2U8ODshmNN5z30tZr7K1lTodArOJ//yNP847F9+mCJoeextMMUV6/CKpt8tiwj5a+bre6NXedNC6/fIMvxcylxsS7xzShUxBQPPtrqq0TBYmC1shCal6sNZD4K0TEkMdyXM5ZEEOKX56dppJgraq8fppZ2+1rLRdbRIiyFIb27flZfPFUn15IJ2MbySezdXkWJUTauE/O+amEMdpul50vkAtLyMxA/TVuOOuMXhqgn9pPLk/dsBFt57oVdcnp2E27dgBfYsHhwYiFKsyd9MTVRWDhKr15w5fxQ6Jy9U3AmlxUkmXjaRgEqV7rmdv9azeL80ETxFpg3KOrcaT5eBxSffzaLyHVm0DKo3pnOSkmJIEmcaZDivbp4UI2N2Cxh1gcv1Bj+XnTpNGCEO+HEF29kbje7hlKuSkHIaGIejStme9ZhCBqdxQsWpBU+X5JPbs08puiVdEQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(66476007)(91956017)(66946007)(4326008)(64756008)(66446008)(8676002)(76116006)(66556008)(6486002)(7416002)(38100700002)(6512007)(8936002)(71200400001)(38070700005)(2906002)(6506007)(5660300002)(31696002)(26005)(53546011)(86362001)(36756003)(54906003)(316002)(186003)(83380400001)(122000001)(6916009)(508600001)(31686004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OU14V3pyLy81UzFiczBZRVVHOWNwVDZoTVlqS3JERDhYWXh5cmplUTlKd3Rm?= =?utf-8?B?QlNkb0JtTFZMRVk2NE1iUVFsQjZERXl6UXZ6RlBsaEcydmJ0L1pFNnJGR1Z0?= =?utf-8?B?cTE5ZUVsdW1pTzNzM3FrUWR3ZUp6Ny9INXVySkgzVjgxUmxuYUtSNm5OUjNV?= =?utf-8?B?VVNwbDJqVzFid2VEbHlZeE5MVkowdm96U3gvaTJjY3I4S1BtOHRyT0hQdUtC?= =?utf-8?B?TlF6bjNYYVRpUVJVOTNFVlFSN0NkTFUxV0JJZmNsNE1QUzQ3QTdLMTFxdUY1?= =?utf-8?B?NzZOMExFWklyVnB6YzZSdmNwNWdxd3hGdmtabW5ISlhOWDRiNmxSU3k4ajB5?= =?utf-8?B?NDRObWI0SmprVHArM0tNZHBJNHVUUitqNnFZUWpCWVlyWjk1N0hSSkRpQ09C?= =?utf-8?B?dVVwQTNDZHZ0aUpkcmFTcktpQ3dPWDFoWjZVak1lQ2tGNlBHVDVkazRFWGxx?= =?utf-8?B?YVlyR0hFRnJhZVovaktmNHJFRFhBdDFWaGYrVmt0WVNwbkNLcCtXMXBLeE1L?= =?utf-8?B?eU1IREk3bGQyZFFsVzFZVERpTFpRazlzZ3lHdHJLZEd6K0REYmNYREJveCtt?= =?utf-8?B?azBGZkFoUkxMRkJKT2loZkd4WE91OHh0RTFlMnFOMG51dTVubGZsdk5KWmgr?= =?utf-8?B?MnMvamRETGJoOTdrNEFmcUFjeGxTbDYxUTJHaEVUaWh4WThYcmUwWkYvbE1v?= =?utf-8?B?aFBoWm9ZYk90amozNzNvUTNZbHg2RmQxUUdtYmoxSW5UVDVkcVc0elg5S2VI?= =?utf-8?B?dnhKSUxYaHhGZDBTYVBCdjQwQUhFekJYclp5dTlTTWM2eGRmeEcyNENhUHdj?= =?utf-8?B?bm1GWG9IYUhBM2lQeFBqM1RKSkFPbDd2QVVIYmFjV3J3a0tiWXBoRElaNkFS?= =?utf-8?B?ekMwOE5ZdFdmMUp2WFhEM1FBUVpRYVNVTUJuSkxZTnJoVzlDcGJQZnZJT0Ns?= =?utf-8?B?cnhZQmVEUDE5anlQODZYa3ROejN5dmNjWUE1TTkxY0xFOFJUa3VSc0paemsw?= =?utf-8?B?THRXZWErUTVWcWpKV215VWswZGZQZHBldW0wcXI1TEpjWDIyV0FjNE1IMzV6?= =?utf-8?B?OStQeVdjZ3VocFIvZUdpbGhVa0NHSXZCSkZTejN4Z0cwQ3pGeEg3UzM5aW1K?= =?utf-8?B?MTVEc2dMTGFKcGQwNHE5Z2pkemFlWDBVR1FFMEhFYmlWZWVBcmlRVkNYZjRN?= =?utf-8?B?cktpWVgrUWtteVJybVIrS212c3FmNDBlZlhaNVVsaEZTdFFUM1h4UGVWcTda?= =?utf-8?B?M28xVklicmlLQ0lrT3g0WXh5UGtqdFFiSGtJV3AyNFBHV042VE91Q3hQbi93?= =?utf-8?B?T1lGZHp0S3BrdzA2bWNIM1ZEL0lNVjBJbTF3STVTaDVENEpaS2tOVjR1V1RL?= =?utf-8?B?cGJTWkZCMnQyd3JER0JmMS8yUDRuRXNKLy9RWXpPOHNiRk9mc3lGYXVDSUVU?= =?utf-8?B?MHV2Nm9mdjdyMkJIdUozTlFpQ09FemFUdit0UytyVE52SVFGU2VNK3pEb05W?= =?utf-8?B?Q0xKYzVnYWxnMWpjQ3p0OXFtUjlTZGhMU2RidFFwa1dnaFlZb3RodDRZcWJa?= =?utf-8?B?ekVSeGFXeGRnU2o4cUhvdU9ibzl6Tm5oMFd6NTkyMzNlczBMMGVjQ1FnWFNU?= =?utf-8?B?cFV3MUVUNDVKcjlTR3RNZXNhWXljdUszaVNtelZEZHMwT0kwOEgxWnhPSUpT?= =?utf-8?B?c1MxR3Q2OEhvcVBRL3V4bDBTTDRNMWxxYWFIRUU4SEd2enQrYXRLS2d3cVZX?= =?utf-8?B?bm0xaENHNHVSNUk5ZFpnUnkxYnVBeG9wbWQra21rZmFJNjRhTGMyU2JTL0xO?= =?utf-8?B?WjljTGYyT1dQS0hicGRsWVowaEtIZnVtYXpsOWdyTHRKWXo3Nzd0YXE0RXBT?= =?utf-8?B?dUN0d21SQjVINzc0aWF0TFBNSWZnNzVTTWxsNDdWMnRNQ1pjVGtLQmQwSzg2?= =?utf-8?B?dDM1V1hLRDE1M0craDJMQkVpbElFWDZmUVRHQ3pqY1RSVFNjZks1VmJQVEg3?= =?utf-8?B?YUtSUkJyUCs3Rks1Tm5lcjlXMGFNaG0rNktOaUZzQ05iTjloNXJXTytBQlNk?= =?utf-8?B?ZDRRZXkya1NoWWNyeUgrQVl4aStCaHh5OUtqTGQ4UlhrL3FWWGViSzV3Tjcr?= =?utf-8?B?clZyVnZ5ZFFsRHlDcy84ejRGTW9SaTJZSzMwb0M3d05xSDlnYmM3WU4wdTNl?= =?utf-8?B?TXRONW1aZ2hwYlJFWlZsRU1ROWFWMFBua2d5MVB3RWpyRVFpMUVQdzVvaENF?= =?utf-8?B?Z3hzR29UZUVSUDd0ZlU3dWhtWUYxUXdLVVp3cFBSVXRudjR2NlVRZXllckt4?= =?utf-8?B?K2hYQm1kd1R4dVVBeDlMaWZaRzdMRnJzV1NSaHlsK3E2VVUzMUZjTzRibUps?= =?utf-8?Q?hYK/9pnTaEBcyTko=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33c09b59-e7f3-41c6-99fe-08da4de2e630 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2022 08:50:14.5770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E+wyGvymepqAihnu+pW6uskT6BnmujGXyQV03BHHacOJ96CVYCCLu58Rswa3lTDH3gYABCLSWvhC/iJZoQ/VtY24lUlWol+S84Wz1UvDpew= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6276 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_015020_783329_CD0A6D92 X-CRM114-Status: GOOD ( 23.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, lars@metafoo.de, ludovic.desroches@atmel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Eugen.Hristev@microchip.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.06.2022 20:58, Jonathan Cameron wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, 9 Jun 2022 11:32:08 +0300 > Claudiu Beznea wrote: > >> Add a parameter to at91_adc_read_info_raw() to specify if st->lock mutex >> need to be acquired. This prepares for the addition of temperature sensor >> code which will re-use at91_adc_read_info_raw() function to read 2 voltages >> for determining the real temperature. > > This looks like a potential lock dependency issue. > iio_device_claim_direct_mode() takes an internal iio lock, and > you then take st->lock. > > If you are going to invert that locking order in another path > you have a deadlock. > > So rethink this. If you want to reuse the code you'll need to factor > it out to a separate function that takes none of the locks then > take all locks needed in each call path (in the same order). OK, I'll check it. > > Jonathan > > >> >> Signed-off-by: Claudiu Beznea >> --- >> drivers/iio/adc/at91-sama5d2_adc.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c >> index 1283bcf4e682..8f8fef42de84 100644 >> --- a/drivers/iio/adc/at91-sama5d2_adc.c >> +++ b/drivers/iio/adc/at91-sama5d2_adc.c >> @@ -1583,7 +1583,8 @@ static irqreturn_t at91_adc_interrupt(int irq, void *private) >> } >> >> static int at91_adc_read_info_raw(struct iio_dev *indio_dev, >> - struct iio_chan_spec const *chan, int *val) >> + struct iio_chan_spec const *chan, int *val, >> + bool lock) >> { >> struct at91_adc_state *st = iio_priv(indio_dev); >> int (*fn)(struct at91_adc_state *, int, u16 *) = NULL; >> @@ -1602,13 +1603,15 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev, >> ret = iio_device_claim_direct_mode(indio_dev); >> if (ret) >> return ret; >> - mutex_lock(&st->lock); >> + if (lock) >> + mutex_lock(&st->lock); >> >> if (fn) { >> ret = fn(st, chan->channel, &tmp_val); >> *val = tmp_val; >> ret = at91_adc_adjust_val_osr(st, val); >> - mutex_unlock(&st->lock); >> + if (lock) >> + mutex_unlock(&st->lock); >> iio_device_release_direct_mode(indio_dev); >> >> return ret; >> @@ -1644,7 +1647,8 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev, >> /* Needed to ACK the DRDY interruption */ >> at91_adc_readl(st, LCDR); >> >> - mutex_unlock(&st->lock); >> + if (lock) >> + mutex_unlock(&st->lock); >> >> iio_device_release_direct_mode(indio_dev); >> return ret; >> @@ -1658,7 +1662,8 @@ static int at91_adc_read_raw(struct iio_dev *indio_dev, >> >> switch (mask) { >> case IIO_CHAN_INFO_RAW: >> - return at91_adc_read_info_raw(indio_dev, chan, val); >> + return at91_adc_read_info_raw(indio_dev, chan, val, true); >> + >> case IIO_CHAN_INFO_SCALE: >> *val = st->vref_uv / 1000; >> if (chan->differential) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel