From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02E78C77B61 for ; Thu, 13 Apr 2023 17:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l5jBED7Ia4G27dKVgABEg4i4Yu+A8Wecf0AY7WYUMeA=; b=d6iNYKm6qTxfK3 0hIAhNvl6l6hHUcqoXuruw6LGpS9DzHn/81ld6Oks+s1Pjli9/HvgwvVOznVTHYAKmWiQ8whUftqL WPzM/mNY15qyOUKj/EVIp5z403d6+rPtYCPiRXKXOi9rVmk8BdTEYgN6oqeSdi5YocHoYcOvf8F04 2ea6b+S+LzxwjgaTIMPQ/iBB4LzJN02KgUO+wnIdTwQ7cewkzPJUwoW10raBLxRFwznF6mach1sol nOPkcwtA9J0p+vaGgvgBebGVy95q23U6px6hrkypqkhnDGaVhcrNtvBVuo6ntQUY9hsILYOQTMOsN 7I/54qWiLXbV/NczY1vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pn0YL-006nIB-1J; Thu, 13 Apr 2023 17:16:09 +0000 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pn0YF-006nFO-28 for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 17:16:08 +0000 Received: by mail-qt1-x832.google.com with SMTP id l11so17193068qtj.4 for ; Thu, 13 Apr 2023 10:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681406159; x=1683998159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=if+eweMpKSPw4ABoMbVMDGxTF36ZdVsMnlzvEryPtKs=; b=qaKN/MLnxUQcthWApLlSBdpvdv19s0p1x5z3lzpzzTx39vs2YbBJuNZbeLJJNOyIBb nF08e0k6lCQdQxMo4kEO+mgaVZq/sB/9MRvuc/8Zf49lDZqb6W0YtcNZI4p+dL0wilVB oAsj09HuNSwVfIkNtNn+wE4mruVGQB3YeAlIs/vO1/1ZRLLLj/EFIP1IlI4btLXQT8P8 cZxEJ1tjQ4+BXgJoufO10gwKWBi8R77KYbhZ3pnwnzNUyn8c4xMFMAKhiOlC/JJNnCcq XdnNVdemEije4GM33zv9zZiwPaNC2r2laF6ICKWlRutbXfzah5Uh5nVnj5npEaNZ0oF2 cscA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681406159; x=1683998159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=if+eweMpKSPw4ABoMbVMDGxTF36ZdVsMnlzvEryPtKs=; b=U71r4JJ2khOGAl6ZcmgAPUpzvl2fAiA19Zk20dxMc9GpJrJX4zbvJLm1Iiw/UPcC3M ECZZMMVOmwyKsxbhV+f/8YIX6lcmb/Zy+0mLKO35iIYf05LnN5fHx8U/L4TKmm6NKxQt z6lOF3Sdv9NAFGH2ahC+TUJPfFmn6BgZiDvF/OoAVnBHtzNyS7VywkoCej2YcxyanzDV LelIFaaI7psMqvYDFkZ1QG/BUuLgY0GTsgvMO+R96mbOCM5YtfFvn7tC8SWU8IePP8ut CtqnG6iB6eFja8IC0ONjMbTwpIYf+LaEc6sPRRl9t5jAmq+X9OGf7E+vFQ4JFtmxbvxd 5JjQ== X-Gm-Message-State: AAQBX9e1u+tgCl5w3EcRsgK1SJwBNdZL5JFsNCeE6zYMe85SLhLWxdIW A3SGU1bliL2fnud4HhEWaMs= X-Google-Smtp-Source: AKy350bF7+ZZYGyT4ws/zJC4Ya+Onaht9i9MWm9l0F72FmoZ0P+iN43eXwa0ekkd9ppUWtfl+4zK/Q== X-Received: by 2002:a05:622a:120c:b0:3e4:e9c9:df70 with SMTP id y12-20020a05622a120c00b003e4e9c9df70mr3529740qtx.10.1681406159380; Thu, 13 Apr 2023 10:15:59 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id bk37-20020a05620a1a2500b0074add69317bsm109446qkb.121.2023.04.13.10.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 10:15:58 -0700 (PDT) Message-ID: <298c045a-5438-6761-46d8-c46c57989812@gmail.com> Date: Thu, 13 Apr 2023 10:15:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH net-next v4] net: stmmac:fix system hang when setting up tag_8021q VLAN for DSA ports Content-Language: en-US To: Jacob Keller , Yan Wang , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, kuba@kernel.org, mcoquelin.stm32@gmail.com Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "open list:STMMAC ETHERNET DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" , open list References: <01ef9d4f-d2dc-d584-4733-798cffda49a1@intel.com> From: Florian Fainelli In-Reply-To: <01ef9d4f-d2dc-d584-4733-798cffda49a1@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_101603_723106_FA6923BB X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/13/23 10:07, Jacob Keller wrote: > > > On 4/13/2023 8:06 AM, Yan Wang wrote: >> The system hang because of dsa_tag_8021q_port_setup()-> >> stmmac_vlan_rx_add_vid(). >> >> I found in stmmac_drv_probe() that cailing pm_runtime_put() >> disabled the clock. >> >> First, when the kernel is compiled with CONFIG_PM=y,The stmmac's >> resume/suspend is active. >> >> Secondly,stmmac as DSA master,the dsa_tag_8021q_port_setup() function >> will callback stmmac_vlan_rx_add_vid when DSA dirver starts. However, >> The system is hanged for the stmmac_vlan_rx_add_vid() accesses its >> registers after stmmac's clock is closed. >> >> I would suggest adding the pm_runtime_resume_and_get() to the >> stmmac_vlan_rx_add_vid().This guarantees that resuming clock output >> while in use. >> >> Signed-off-by: Yan Wang > > This looks identical to the net fix you posted at [1]. I don't think we > need both? > > [1]: > https://lore.kernel.org/netdev/KL1PR01MB5448020DE191340AE64530B0E6989@KL1PR01MB5448.apcprd01.prod.exchangelabs.com/ Unfortunately both still lack a proper Fixes: tag, and this is bug fix. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel