From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5D85E9B260 for ; Tue, 24 Feb 2026 13:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8r/5mlkGFR+cg2cNs/uKZz5HxZUzfmwW5AEmY5shqyA=; b=wh/tVV7RTyr94G07M0iAxK1gpH NgzEGgg8d1QK3bqJMsRY1DgzrAUyr82A2SiNeRW2Cfy6hoEoGULchI4up6dDZMiEmHU0kOLDE1hSt W1dmMO0/3lMuwsg50y+z4nknw5B6wrrEaJMU0PJud4DNCydxSOUKWvdpIWMOlwsnifkcm8Ycrf4tR +iYLZfBLXXI/eebSpMp9AExObs/tP3kDl42SdurFlUUPLfDP78jqIxPJ2UnKrw9vB/BDBtWwU8e1h 4pZq8/5D/3OSSKCF7mIQvPTtKto271CWwo+IWprle/EQOyndJGyy4GfAdHkyE7Jt6aHC704Vx63ou 0rcqMadg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vusIh-000000027Y5-2ruP; Tue, 24 Feb 2026 13:18:07 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vusIf-000000027XO-3MLS; Tue, 24 Feb 2026 13:18:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 20D334066C; Tue, 24 Feb 2026 13:18:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DB7FC116D0; Tue, 24 Feb 2026 13:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771939085; bh=G6eZk5Nfo/RDIiGr0N39A1cxm9lBiDCxNCqjfX17+x8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rjxbxFoxRQXNKHhuQWTUz5qFtnYkgLOWBjXXUUm8noaFW0VgSm2s3T/pXo3gT4umW KsEXCf22g2ZNHC2fbnUOqFqFOw82LpheUV//ABxiXewlacqe9T2c9N6wDwLma543CU G5IX6PDCONCJjQQ2eUh8FF3LqPazCcw8XKLatgDOZ+wVOuc2jVD2iHCHVR+ZIHm0zv g5BBqAkHVY5YZcD8PDSkdazBsc5tzEZQMoAFgXOLBXkr91a0GIiDfFBkthWbj3uJVw sxV4OneK2RZAgx2SAMjYvd9byubBT/bJeJQnkFiG0GnrpdCds5B06enikZWld6W713 wFo156lkGobcQ== Message-ID: <2996bc4a-1746-40ff-8ec0-76f779600c1e@kernel.org> Date: Tue, 24 Feb 2026 14:17:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] media: dt-bindings: rockchip,vdec: Correct reg-names order for RK35{76,88} To: Nicolas Dufresne , Cristian Ciocaltea Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Detlev Casanova , Ezequiel Garcia , Mauro Carvalho Chehab , Hans Verkuil , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley , linux-media@vger.kernel.org References: <20260223-vdec-reg-order-rk3576-v2-0-daf4942dfc02@collabora.com> <20260223-vdec-reg-order-rk3576-v2-1-daf4942dfc02@collabora.com> <20260224-saffron-peccary-from-heaven-2d5e6e@quoll> <244b22d3be77047163b4e47c4ed33b5b1befb4b4.camel@collabora.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <244b22d3be77047163b4e47c4ed33b5b1befb4b4.camel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260224_051805_952979_860FD781 X-CRM114-Status: GOOD ( 18.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/02/2026 14:14, Nicolas Dufresne wrote: > Hi, > > Le mardi 24 février 2026 à 08:17 +0100, Krzysztof Kozlowski a écrit : >> On Mon, Feb 23, 2026 at 09:49:49PM +0200, Cristian Ciocaltea wrote: >>> Update 'reg-names' property to allow providing the register blocks in >>> the expected address-based order for RK3576 & RK3588 video decoder and, >> >> What? The register blocks SHOULD NOT be provided in address-based order. >> There was never such coding style, never ever we gave such hint and if >> you found Qcom discussions you would see me and Rob objecting to it. > > Would be nice to make a suggestion to how to fix this warning differently. > > rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100" I provided the suggestion in the commit mentioning the issue. Nothing here suggests any warning, so why would I suggest some steps? > > >> >>> consequently, fix some DTC warnings. >>> >>> Additionally, drop the 'reg' description items as the order is not fixed >>> anymore, while the information they offer is not very relevant anyway. >>> >>> Fixes: c6ffb7e1fb90 ("media: dt-bindings: rockchip: Document RK3588 Video Decoder bindings") >>> Fixes: a5c4a6526476 ("media: dt-bindings: rockchip: Add RK3576 Video Decoder bindings") >> >> No, nothing to be fixed here. Describe the bug, because missing order >> to address-based is for sure not a bug. > > The warning should be part of this this commit message, since the cover letter > is not going into git. > >> >>> Signed-off-by: Cristian Ciocaltea >>> --- >>>  Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 13 ++++++------- >>>  1 file changed, 6 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml >>> index 809fda45b3bd..2d3164a2882b 100644 >>> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml >>> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml >>> @@ -28,16 +28,15 @@ properties: >>>   >>>    reg: >>>      minItems: 1 >>> -    items: >>> -      - description: The function configuration registers base >>> -      - description: The link table configuration registers base >>> -      - description: The cache configuration registers base >>> +    maxItems: 3 >>>   >>>    reg-names: >>> -    items: >>> +    oneOf: >>>        - const: function >>> -      - const: link >>> -      - const: cache >>> +      - items: >>> +          - const: link >>> +          - const: function >>> +          - const: cache >> >> No, ABI break without point. > > Its not released yet, otherwise both order would need to be allowed. Nothing in commit msg explains that and we expressed such expectation multiple times. Otherwise you get above comment. Best regards, Krzysztof