From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gary Bisson <bisson.gary@gmail.com>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
angelogioacchino.delregno@collabora.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com
Subject: Re: [PATCH 4/5] arm64: dts: mediatek: add device tree for Tungsten 510 board
Date: Mon, 1 Dec 2025 09:53:03 +0100 [thread overview]
Message-ID: <29ad8354-231d-470e-a899-cb7c42754c8c@kernel.org> (raw)
In-Reply-To: <20251201084140.376058-5-bisson.gary@gmail.com>
On 01/12/2025 09:41, Gary Bisson wrote:
> +
> +&i2c_mux_lcd_2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@2c {
> + compatible = "ti,sn65dsi84";
> + reg = <0x2c>;
> + enable-gpios = <&pio 25 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&dsi0_sn65dsi84_pins>;
> + status = "okay";
Did you disable it anywhere?
...
> +
> +&spmi {
> + #address-cells = <1>;
> + #size-cells = <2>;
> +
> + mt6315_6: mt6315@6 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
e.g. pmic
> + compatible = "mediatek,mt6315-regulator";
> + reg = <0x6 0 0xb>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-01 8:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 8:41 [PATCH 0/5] Add support for Ezurio MediaTek platforms Gary Bisson
2025-12-01 8:41 ` [PATCH 1/5] dt-bindings: vendor-prefixes: Add Ezurio LLC Gary Bisson
2025-12-01 8:50 ` Krzysztof Kozlowski
2025-12-01 8:59 ` Gary Bisson
2025-12-01 9:33 ` Rob Herring (Arm)
2025-12-01 10:04 ` Gary Bisson
2025-12-01 10:10 ` Krzysztof Kozlowski
2025-12-01 8:41 ` [PATCH 2/5] dt-bindings: arm: mediatek: Add ezurio,mt8370-tungsten-smarc Gary Bisson
2025-12-01 8:51 ` Krzysztof Kozlowski
2025-12-01 9:33 ` Rob Herring (Arm)
2025-12-01 8:41 ` [PATCH 3/5] dt-bindings: arm: mediatek: Add ezurio,mt8390-tungsten-smarc Gary Bisson
2025-12-01 9:33 ` Rob Herring (Arm)
2025-12-01 8:41 ` [PATCH 4/5] arm64: dts: mediatek: add device tree for Tungsten 510 board Gary Bisson
2025-12-01 8:53 ` Krzysztof Kozlowski [this message]
2025-12-01 8:41 ` [PATCH 5/5] arm64: dts: mediatek: add device tree for Tungsten 700 board Gary Bisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ad8354-231d-470e-a899-cb7c42754c8c@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bisson.gary@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).