Re: [PATCH v2 01/14] dt-bindings: net: mediatek: add optional properties for the SoC ethernet core

Lorenzo Bianconi
2022-04-08T09:35:40Z

[-- Attachment #1.1: Type: text/plain, Size: 1553 bytes --]

> On Tue, Apr 05, 2022 at 09:57:42PM +0200, Felix Fietkau wrote:
> > From: Lorenzo Bianconi <lorenzo@kernel.org>
> >
> > Introduce dma-coherent, cci-control and hifsys optional properties to
> > the mediatek ethernet controller bindings
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > Signed-off-by: Felix Fietkau <nbd@nbd.name>
> > ---
> > Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > index 72d03e07cf7c..13cb12ee4ed6 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > @@ -41,6 +41,12 @@ Required properties:
> > - mediatek,pctl: phandle to the syscon node that handles the ports slew rate
> > and driver current: only for MT2701 and MT7623 SoC
> >
> > +Optional properties:
> > +- dma-coherent: present if dma operations are coherent
> > +- mediatek,cci-control: phandle to the cache coherent interconnect node
>
> There's a common property for this already. See CCI-400 binding.
>
> > +- mediatek,hifsys: phandle to the mediatek hifsys controller used to provide
> > + various clocks and reset to the system.
> > +
>
> This series is adding a handful of new properties. Please convert the
> binding to DT schema first.

ack, I will converti this file to yaml format.

Regards,
Lorenzo

>
> Rob

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]