From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0500BCF9C69 for ; Wed, 25 Sep 2024 01:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GcWVN5jq5I86+F+azhdXxblU0W/zeOeflgS1enKCNA8=; b=Bbh2JbGuCMpn7XWeQ4fm9PfUxX Eww4xpmF4wXKCIFdJyYaUED+EuBkMttg93o9hW5Y+gvVKCAxN1CZPaFWXAwtJoDG7fBObOiJFOrnM czYBJ+8ooUIb4W6X3Tq+KO7CFdzNyrkLKhlqi0bKuB2nRFTW34w6PkVboyWj8Llejy+HrL2EIyeWJ PQMQk4OEINjT5oZf1vCTIh85EgJRZiMdcKY2doED1kiQvYB1F5v9YfEPds6Vf7+caP5OewaZr36qa iTkMSbp73y29SQVhJs8keVLuTNi1tNc7dtiij0rFETV8aoO9itBi2A/6IbLPJxJpweUfjwWPJfMEY G/J5cWGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stH4L-00000003lF5-40Zd; Wed, 25 Sep 2024 01:43:53 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stH3C-00000003l7X-25mE; Wed, 25 Sep 2024 01:42:43 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2d8a9a15a7fso1171234a91.0; Tue, 24 Sep 2024 18:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727228561; x=1727833361; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GcWVN5jq5I86+F+azhdXxblU0W/zeOeflgS1enKCNA8=; b=YUIJf/D7kHUC76woMSGHOWRiFQLxeM99uSePRwEkm0zrGOZxyDEBHwYI4yxl+J4Sxl vsFjFTUnFiHe6ZrENd3XERNAjIaW3Rh3ATmC17K2q3S2fEKD4inmjk5WVcLBd+Zfyqxd VZR7LPkXAP2C8sjdIHKbHPFRq08pQKofMXmI4FkageEBgPRxK6hpE31lqZxywsFy7QxU fHHFZKK9wSKTGhcZzSakK9DQETJULhfJe9Uc9WEa7KqaDnuktwk6s6Rb2qgSok6ByI8n kkHPuPX660mxs7QO9qtCh+UUlPIhF5lL/s1eEdoOLBumeNFaUQksHbg+f3dShSaE04af P6nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727228561; x=1727833361; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GcWVN5jq5I86+F+azhdXxblU0W/zeOeflgS1enKCNA8=; b=aQj6+aN2jpEnfLdVb9AfYL5sKunULQ6P7Ek9yiHDGE79UL0f23AxCKOjV9VduPdK+S ZM3KXVMaCu/qgaBaE5sL8mAz/IvXO2FLeIS/unsBlZ+UZu0kgpTiK02z6hUzgIlEqLWU JLcxrllyT3vvA51ub1yJiFaiY6HzQQj/4xO27LuM/d5xMQc26A9pFhljQce0nBNvO5g3 uSHASlO6ITBPrO7Wox6JSlyuvYHxxye/rPyiolq5AILqldk/5+GHH/1EeEp9DBu/1c9W fmJ03JuARZXXLaT4Fzq6glZjK9HDhHGfqyOR601Rx+NXaZWSgHkAo7c0zojZ9E+fqcDb m6uw== X-Forwarded-Encrypted: i=1; AJvYcCW/WMKr5qfe6fP0T9k+WBJaaccLaTV/vYKZmg6lcmdphkswUftpVtswx2lZ1aqcOdbH+rVzPfyVBZbA+TJEBTs=@lists.infradead.org, AJvYcCWRh2wLd7tnL8cpx7570IFu0G96WbtaoAFPWIUIBquN3+sBJU5F8u2rayCbyPBpR1S73hljv/cSMxAjm1zEnaoK@lists.infradead.org X-Gm-Message-State: AOJu0YzPKZdI78k4EFiyCQnM1ERQAL81MNe3JzrrqR0/5FGURJz+f7eS KjaJ+OyMENqB1TmfQXXC23yYBnGl703b54+c5XTThJ+yZXhCoxB0 X-Google-Smtp-Source: AGHT+IFqIBT66TkyL0J2QfmtEOX6F9Je5mvlnxVw4zEkidcGIvNVdjtGkMa+udbesxpclhLKmHCHiA== X-Received: by 2002:a17:903:110c:b0:207:14b3:10f0 with SMTP id d9443c01a7336-20afc6427e0mr6506155ad.14.1727228561153; Tue, 24 Sep 2024 18:42:41 -0700 (PDT) Received: from [192.168.60.56] ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20af18572bdsm15396675ad.248.2024.09.24.18.42.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 18:42:40 -0700 (PDT) Message-ID: <29d80d30-dcbf-4fe1-b7aa-3f8c46fee714@gmail.com> Date: Wed, 25 Sep 2024 09:42:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] phy: rockchip: inno-usb2: Add usb2 phys support for rk3576 Content-Language: en-US To: Heiko Stuebner , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, william.wu@rock-chips.com, tim.chen@rock-chips.com, Frank Wang References: <20240924085510.20863-1-frawang.cn@gmail.com> <20240924085510.20863-2-frawang.cn@gmail.com> <15288441.JCcGWNJJiE@phil> From: frawang In-Reply-To: <15288441.JCcGWNJJiE@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_184242_558470_E544C54D X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Heiko, On 2024/9/24 18:01, Heiko Stuebner wrote: > Am Dienstag, 24. September 2024, 10:55:10 CEST schrieb Frank Wang: >> From: William Wu >> >> The RK3576 SoC has two independent USB2.0 PHYs, and >> each PHY has one port. > Can you please split the content into "converting to clk_bulk" (see > additional comment below) and "add rk3576" please? > > That would make the patch a lot cleaner. OK, I shall amend in the next patch. > >> @@ -376,6 +378,7 @@ rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy) >> { >> struct device_node *node = rphy->dev->of_node; >> struct clk_init_data init; >> + struct clk *refclk = of_clk_get_by_name(node, "phyclk"); > Doesn't this create an imbalance - with the missing put? > I think ideally just define clk_bulk_data structs for the > 1-clock and 3-clock variant, attach that to the device-data > and then use the regular devm_clk_bulk_get ? > > That way you can then retrieve the clock from that struct? How about keep the clk_bulk_data and num_clks member in rockchip_usb2phy structs, and retrieve the clock by "clks.id" here? Just like the following codes. @@ -378,8 +378,9 @@ rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy)  {         struct device_node *node = rphy->dev->of_node;         struct clk_init_data init; -       struct clk *refclk = of_clk_get_by_name(node, "phyclk"); +       struct clk *refclk = NULL;         const char *clk_name; +       int i;         int ret = 0;         init.flags = 0; @@ -389,6 +390,13 @@ rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy)         /* optional override of the clockname */         of_property_read_string(node, "clock-output-names", &init.name); +       for (i = 0; i < rphy->num_clks; i++) { +               if (!strncmp(rphy->clks[i].id, "phyclk", 6)) { +                       refclk = rphy->clks[i].clk; +                       break; +               } +       } + BR. Frank > > Thanks > Heiko >