From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74059C001B0 for ; Tue, 8 Aug 2023 11:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/bw7i6lKG9hbbiWE0WM3X1E6JLo2BsE6G8gKJMbG+/Q=; b=MJ4qdyO6W+f7oj luRQV6rkT5KjtF0qnuGy51XJclc5KJPy8AkWE93FEkG0/3uIY2OcZ2l1wWebYPgs33EdAIR6jLI9U cfEttOqxhgjOlrPbGoe1tcjN/FKCSJqQ+6L+f0ob+twT8cE2It3/Ag17ZfEDrWrvNu2EcNSY9580q kzh1/bd63ZjF9EiNSVhCVO36z1t0b+C9+wahMS6//ARNFBu3n9oh06LnJ7OcaTwA30ZWAcQNlZJuh DAcl6TUZ0JHvGeppXfo91u0vzYIkmN3qShhIRjjD9NAwfZzNW9LJitihef1S2RO4kiw883tCvcjRD 6zVlg/EvklakZ0kSPJYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTKw9-002TAK-1k; Tue, 08 Aug 2023 11:31:41 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTKw6-002T8G-1J for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 11:31:40 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-52164adea19so7198601a12.1 for ; Tue, 08 Aug 2023 04:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691494294; x=1692099094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MiAjavq0sK918LzUOhJOnDEbmGyu/bjq8deQKGQYoYk=; b=PMxMnXatU5PaqsWuo2hnDm31Ldi8ScfIFWSihtEttiTbr/1Cx7i6C2vqD+Ctx7ASRj Mb/h+L54l9vuxY6+IfoSjtEzNLdEj6LFyLRJO55TbveC8QjamHHrL7lCJ+/nVpH1cAdP X+5eF9JGR+0HocTbjlsKBKuFOo9ayUGI02LeYKN1Xw6ImynT9CwADfSiL0oV6PLNYtlW Me6YP8lbIC5uvs6uOSwMHcAtJ7sy1+DEC7hk4bdC7J9qODQRCArUOLoP/TwF/rPKWhKy cN3dZW52Yr/BwQbNCEt+2+WIgQOkRKMTPSyfN5OLBcHBbPZxbyU00hfgXzkii+mPkdLg SkyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691494294; x=1692099094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MiAjavq0sK918LzUOhJOnDEbmGyu/bjq8deQKGQYoYk=; b=j04GUGf8pQuLA+UxQwDVvRaa/wtDEvmWEr5uCgczZgVGkgf++mOe2qk7NEdwmaT5iG NDmtFtDncGQQnbBNnCdcW9NnYyMXKobTeZ9o1XmaqppuU/GeScA7gF3zqMEBIeQx71rv OVPg8gpr4SeE3rXj5C0otYv1+Fj8jrGY95CQJNLvjoMcRE+XlWnifDbM02xToT//yRga yzU/f43XjhonkHO4YbbWTShXfme8DmgsrD8y6VRosT6Z3q3FD+dleG+3+CylxOHxpe5D gBNiK9ZpH4suDjLVavTpJSpTu5w5tK9Tg15djTM2WbnzwKMOVUHOcCQQ5DJNdKVoN3hj jIRw== X-Gm-Message-State: AOJu0Yy/uw1uM7YXocfm15Sf8a/9Q7r8xg59PbPRN+PZL9vSkm2NkNgN 3FtX/8M+x27HFr7QrcyBzGqBKA== X-Google-Smtp-Source: AGHT+IHO1SvdXIMzYOuM/7cTZqhd0uBE3xSnzMkXW+UP4EsFgvWuxndxBMzXA8yQRk6sNMAZx/98UQ== X-Received: by 2002:aa7:d055:0:b0:51d:91ef:c836 with SMTP id n21-20020aa7d055000000b0051d91efc836mr9472510edo.32.1691494293685; Tue, 08 Aug 2023 04:31:33 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id a8-20020a170906244800b00992b2c55c67sm6619400ejb.156.2023.08.08.04.31.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 04:31:33 -0700 (PDT) Message-ID: <29e20953-5660-079e-2136-0962eec9cab5@linaro.org> Date: Tue, 8 Aug 2023 13:31:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 2/9] i2c: mlxbf: Use dev_err_probe in probe function Content-Language: en-US To: Andi Shyti Cc: Liao Chang , florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-3-liaochang1@huawei.com> <20230808112907.4rnvmyha4v6cg5ds@intel.intel> From: Krzysztof Kozlowski In-Reply-To: <20230808112907.4rnvmyha4v6cg5ds@intel.intel> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_043138_442876_C89997AF X-CRM114-Status: GOOD ( 20.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 13:29, Andi Shyti wrote: > Hi Krzysztof, > > On Tue, Aug 08, 2023 at 10:36:40AM +0200, Krzysztof Kozlowski wrote: >> On 08/08/2023 03:29, Liao Chang wrote: >>> Use the dev_err_probe function instead of dev_err in the probe function >>> so that the printed messge includes the return value and also handles >>> -EPROBE_DEFER nicely. >>> >>> Reviewed-by: Andi Shyti >>> Signed-off-by: Liao Chang >> >> ... >> >>> @@ -2413,10 +2399,8 @@ static int mlxbf_i2c_probe(struct platform_device *pdev) >>> ret = devm_request_irq(dev, irq, mlxbf_i2c_irq, >>> IRQF_SHARED | IRQF_PROBE_SHARED, >>> dev_name(dev), priv); >>> - if (ret < 0) { >>> - dev_err(dev, "Cannot get irq %d\n", irq); >>> - return ret; >>> - } >>> + if (ret < 0) >>> + return dev_err_probe(dev, ret, "Cannot get irq %d\n", irq); >> >> I don't think this is needed: >> https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/ > > Hmm, that's a bit borderline, I'd say. The change to What's borderline exactly? devm_request_threaded_irq_probe() is coming, right? If it is accepted this hunk is useless and soon should be replaced with proper one. Instead of making many trivial changes doing the same, all these series should be aligned. > devm_request_irq/devm_request_threaded_irq_probe seems like > something for another series. But for now, I think I'll accept > this as it is since it fits within the scope of this current > series. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel