From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
<arnd@arndb.de>, <alexandre.belloni@bootlin.com>,
<krzysztof.kozlowski+dt@linaro.org>,
<claudiu.beznea@microchip.com>
Cc: <soc@kernel.org>, <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.
Date: Mon, 4 Jul 2022 16:06:15 +0200 [thread overview]
Message-ID: <29e72784-2c7b-1c31-357c-012cafe57a00@microchip.com> (raw)
In-Reply-To: <20220704135809.6952-1-kavyasree.kotagiri@microchip.com>
On 04/07/2022 at 15:58, Kavyasree Kotagiri wrote:
> On pcb8291, Flexcom3 usart has only tx and rx pins.
> Cleaningup usart3 pinctrl settings.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
Fine with me as well:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> v1 -> v2:
> - Keep both tx and rx pins into one node.
>
> arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 3c7e3a7d6f14..d56d2054c38d 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -19,19 +19,9 @@ aliases {
> };
>
> &gpio {
> - fc_shrd7_pins: fc_shrd7-pins {
> - pins = "GPIO_49";
> - function = "fc_shrd7";
> - };
> -
> - fc_shrd8_pins: fc_shrd8-pins {
> - pins = "GPIO_54";
> - function = "fc_shrd8";
> - };
> -
> - fc3_b_pins: fcb3-spi-pins {
> - /* SCK, RXD, TXD */
> - pins = "GPIO_51", "GPIO_52", "GPIO_53";
> + fc3_b_pins: fc3-b-pins {
> + /* RX, TX */
> + pins = "GPIO_52", "GPIO_53";
> function = "fc3_b";
> };
>
> @@ -53,7 +43,7 @@ &flx3 {
> status = "okay";
>
> usart3: serial@200 {
> - pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
> + pinctrl-0 = <&fc3_b_pins>;
> pinctrl-names = "default";
> status = "okay";
> };
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-04 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 13:58 [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings Kavyasree Kotagiri
2022-07-04 14:06 ` Nicolas Ferre [this message]
2022-07-05 7:41 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e72784-2c7b-1c31-357c-012cafe57a00@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=kavyasree.kotagiri@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox