From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB86CC4345F for ; Tue, 30 Apr 2024 11:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cfkoSuYKKqSx9gzmFBR/Z28Sh1h+dohbwxjs9hwcOpw=; b=BI/Y2x7RXUFcRb 9w11ebWQ/yk3vi/oEm43DvsnDBxns9UyI7uQe7CiC1qXvDTDRXGI+EfLryLszBcpHwc7l2lqDpqTT DSfKYmQ3JlmyxzjF5tigZ4GVwEIewjrkq/y9vzX4TBThDNcuCa329mMYesYlX/fLuhOUUi+sFXFT9 BiZJLqVWfkJZ67FP9PMAYBGJa+A969y+P1i1HEhmDVVNpbcPpvmARqspVY8kxob0TKGvNjYgzcqQs WR0Di4IydhS3OfT/fLX0GdDiHaePmyNhKi2ByvKYNGvdnewJ4zlCiBcCvcWi78nWi4MrDR0UEONmX teTeYygTwJeMT0dZxGrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1loM-00000006CLS-0fJQ; Tue, 30 Apr 2024 11:38:14 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1lo9-00000006CGj-45UY for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 11:38:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714477077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eiAW+x1zKVTvGTvtjODDDjCAqDM2UP0sxyHU46nIuLU=; b=aX09KW4/VBUT81IL0job8OAy98hlg0bMytHkdppPTLRBYt79Yn/w6Rh5IEFAv1ayEqbigb rRQEFNFdR5P4gQRAqudzxFMDYYYupGOwtscG/2UZ7SYiKE+q1rdKfLS2nz7SYDEuBAWSTg arBROw/Fm0BnqbksrgP7+6dn8RMAXZg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-YyDNmQOWMdS_2LOiDzjBxg-1; Tue, 30 Apr 2024 07:37:56 -0400 X-MC-Unique: YyDNmQOWMdS_2LOiDzjBxg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41c23f368e4so9107645e9.0 for ; Tue, 30 Apr 2024 04:37:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714477075; x=1715081875; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eiAW+x1zKVTvGTvtjODDDjCAqDM2UP0sxyHU46nIuLU=; b=R05eXT2WqNQ7YWBQ6YB2TfFqJO3wvS2W0jbrXVUzit2pOtPH/bjLlTzZ7uAK5La0w2 ClVfaew8BgQs//orhVBW7PH9VZi+nzlQiTBbUxxTL9nKuL/8r+vnAkU+n4Xdi/BtDCWC KCV1Q9V7bx8YUrCjAEoOzMLghLDrt2qwSi1QoG0u3Yraaco5c3KWCCDVW42DLVGikhuV sYqGAPICGv8DiyAqe2XsdGGSqO+Ag1G3Cq73MZctq6pmvy+2u+lTiD2dvosIz+i9yKBA SRJcb3RnFd0aP6lFjop46Ky/l7+9iOFnyFKSHS51w/5TmYFY4S5ZAx4ZgCEIWQriar3C DGJw== X-Forwarded-Encrypted: i=1; AJvYcCVmqyAqJOfcCZLLvJ8Y3dGWkfYpDJNH/boIjMuKNt1gs1JYeq0XGiG7kSEsN96rZhMxPdU99yV4EfiZETwiBHgXwJUux6SjChJUAP+aKsjbS6pjk/E= X-Gm-Message-State: AOJu0YzEKgmpDmTrVqhiPAUUBaDc6SNfHNYXA9x3KYFo+Mczk1ptox9P iEi/nhZ1z34MQNXPE8Bnl6yxVYhnXftnI3T15Cb88TBXQ1mmedMuOtYbcuvd3Y1Nl8yCER+t8PC 59qPKe58kzK9lOjwz3LcA9hEVF7uro9IRyc4hDOl1lB/X2BJaxRopnVLZ5I09JY1+BuIoEoJC X-Received: by 2002:a05:600c:3d9b:b0:41b:fe6e:8a0e with SMTP id bi27-20020a05600c3d9b00b0041bfe6e8a0emr1846692wmb.13.1714477075175; Tue, 30 Apr 2024 04:37:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBjcJ8fnQHVbF6+IV00h/FYxVbVzAtbd0LRfOXotvYUiJsQ0oEvNuNuWmo+BbJ8Y7d1ZbNhg== X-Received: by 2002:a05:600c:3d9b:b0:41b:fe6e:8a0e with SMTP id bi27-20020a05600c3d9b00b0041bfe6e8a0emr1846679wmb.13.1714477074783; Tue, 30 Apr 2024 04:37:54 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id je1-20020a05600c1f8100b0041adf358058sm25048834wmb.27.2024.04.30.04.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 04:37:54 -0700 (PDT) Message-ID: <29fd6909-73d2-4b7e-99ef-0101cde1ba8a@redhat.com> Date: Tue, 30 Apr 2024 13:37:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64/mm: Refactor PMD_PRESENT_INVALID and PTE_PROT_NONE bits To: Catalin Marinas , Ryan Roberts Cc: Will Deacon , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , Peter Xu , Mike Rapoport , Shivansh Vij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240429140208.238056-1-ryan.roberts@arm.com> <20240429140208.238056-2-ryan.roberts@arm.com> <839d6975-ce12-4fc9-aa3b-8ec5787bf577@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_043802_132161_85FB070C X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30.04.24 13:11, Catalin Marinas wrote: > On Mon, Apr 29, 2024 at 06:15:45PM +0100, Ryan Roberts wrote: >> On 29/04/2024 17:20, Catalin Marinas wrote: >>> On Mon, Apr 29, 2024 at 03:02:05PM +0100, Ryan Roberts wrote: >>>> diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h >>>> index dd9ee67d1d87..de62e6881154 100644 >>>> --- a/arch/arm64/include/asm/pgtable-prot.h >>>> +++ b/arch/arm64/include/asm/pgtable-prot.h >>>> @@ -18,14 +18,7 @@ >>>> #define PTE_DIRTY (_AT(pteval_t, 1) << 55) >>>> #define PTE_SPECIAL (_AT(pteval_t, 1) << 56) >>>> #define PTE_DEVMAP (_AT(pteval_t, 1) << 57) >>>> -#define PTE_PROT_NONE (_AT(pteval_t, 1) << 58) /* only when !PTE_VALID */ >>>> - >>>> -/* >>>> - * This bit indicates that the entry is present i.e. pmd_page() >>>> - * still points to a valid huge page in memory even if the pmd >>>> - * has been invalidated. >>>> - */ >>>> -#define PMD_PRESENT_INVALID (_AT(pteval_t, 1) << 59) /* only when !PMD_SECT_VALID */ >>>> +#define PTE_INVALID (_AT(pteval_t, 1) << 59) /* only when !PTE_VALID */ >>> >>> Nitpick - I prefer the PTE_PRESENT_INVALID name as it makes it clearer >>> it's a present pte. We already have PTE_VALID, calling it PTE_INVALID >>> looks like a negation only. >> >> Meh, for me the pte can only be valid or invalid if it is present. So it's >> implicit. And if you have PTE_PRESENT_INVALID you should also have >> PTE_PRESENT_VALID. >> >> We also have pte_mkinvalid(), which is core-mm-defined. In your scheme, surely >> it should be pte_mkpresent_invalid()? >> >> But you're the boss, I'll change this to PTE_PRESENT_INVALID. :-( > > TBH, I don't have a strong opinion but best to avoid the bikeshedding. > I'll leave the decision to you ;). It would match the pmd_mkinvalid() > core code. But if you drop 'present' make sure you add a comment above > that it's meant for present ptes. FWIW, I was confused by present = valid | invalid Something like present = present_valid | present_invalid would be more obvious at least to me ;) -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel