From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 075D3C54E58 for ; Wed, 20 Mar 2024 06:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k2HDLY5XXdieIAi8X9k8eiJdaPbsw2TMHZfvDlvkNug=; b=yinxG/mWzfFG0K lh9hNd1YgjcIozFRAc7syTpauTLScg/4yTzbPleQLWJTqA8+8KyFXAhu1zgpDkIBvbDIFI2+rlzjN xKa0ra9e6/3NxwqjxY9t8GjilydFu41CLdvqij4R46q1Jg6hTWvGNpPeZTCJFu4zQfSv8tlW27IKy 7z0aipLj/Hb9k2+hx+SZdChOHrIzfpU/eHuXmA3UPuBvGfkZCgIQlETH7xLslr+gwfwrcveLp76Xu nvhxh10SYSCDzGncfCihcFpE78RoNtOgSx/zYLe0c9U9LciuoNt1D9cZjiBlB2qfGf82ebg2rYe8/ 0pn1UwTdNWUsTa12pcIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmpNF-0000000Ffci-21Qr; Wed, 20 Mar 2024 06:24:30 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmpN5-0000000FfTB-1mhl; Wed, 20 Mar 2024 06:24:27 +0000 X-UUID: 77505b1ae68211eeacdb61a41848c7d2-20240319 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=BfHe+ARrnShqEUBaUVvC53qLDo9tqGjcnNoghxJJo84=; b=NM//dBSZGQOLqy/Kpu9Gea6X7oRmWj0MsVDTf2qFLIJI5Yr/TmJroGWtD+W3EGmiLgshpdMowxEergdjeqkqLqvLJjPMgebRGFVtF97+knM61/7P6uxlrhXd36siCQ9hkMMEKIWonFKnlDA04ul6Dpo7emvJ6wAehkiHAbPc0GA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:4e3f7350-4bbf-4d68-951b-9417b02f70b2,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6f543d0,CLOUDID:56afb581-4f93-4875-95e7-8c66ea833d57,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: 77505b1ae68211eeacdb61a41848c7d2-20240319 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 775499724; Tue, 19 Mar 2024 23:24:11 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 20 Mar 2024 14:03:33 +0800 Received: from SG2PR03CU006.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 20 Mar 2024 14:03:33 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UCwTlXSWQ2u02N8qnyOLjDpuk/3llCeEL7d4sLRjpW0676Q7HcN3ruGuqA05xrYd/7OlWEv93nqMdZX8xeyavC1BF7/lt1tao30qovFPlXqi2akqK42OgpmOAtyP1s9jwm70mZEXqmqSJKke4oKk8CcPwmsPwosDubPxKY75nY4MDz+DUbgTkPbl/GbsnWSvuMTBzFWLS9gKQSSpUbCVtGy/zcNecT3OsWC7Gas2rkKViTeDlgRtlUT4cP2DlWY2xkYfRFfAIbW8WCwuqsetgEvTSBVsIoHC8u8UB7IGGe28dFqNM5+P2k2xTtDBGPoPDo83swuBlI9QgCPbtJXD6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BfHe+ARrnShqEUBaUVvC53qLDo9tqGjcnNoghxJJo84=; b=JpjzlDc/KWyUMDokoTBk9aXbuwnCb/cucIpd2x4pX3qTBIPzBLCiddY7TNNlMht9pOQ7RZDQ1m5IvQRa2WWJzAtN4yC9jljq6iNLmSf3MvMAE01tqfwOsrkVaC65Jd7jnOvYSOelgPNFYVZluHrMuCg4ANTLZi/MQ+Td1X80NOxDnFbNOyuWhgClCJjotka4rKU91TnqGqNagrIr1NkZx12apK0AuK/712RJ9JizpvO7UCoxMqXhiLMyuEN4+cL+Fizq10Vn99BnymXZJvkrdr5LRYhegEEVfLzYgSL4c0prXqBB7CgHIcSZ7411zoT2a2LJgsUJ2GM9hgCFpIWg2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BfHe+ARrnShqEUBaUVvC53qLDo9tqGjcnNoghxJJo84=; b=eh9XJRLUDJK0oOHoJCw9JjoLqNAksd5FytjFFFj0mcDJnyM0+4uOfIyaQ/hMDXddVDn7fv7tFa37Etj1hD8zjOeKu4Yfl50jU4JmkxEJZdQ/qHiq+minsAD4aEKrl63shTTR3DIs2Id1BK/oYZh+I9u9PsiHps9UacSzuI0ENPg= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by SEYPR03MB7190.apcprd03.prod.outlook.com (2603:1096:101:d3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Wed, 20 Mar 2024 06:03:27 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::f3b6:91a7:e0fb:cb27]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::f3b6:91a7:e0fb:cb27%7]) with mapi id 15.20.7386.025; Wed, 20 Mar 2024 06:03:27 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: =?utf-8?B?U2h1aWppbmcgTGkgKOadjuawtOmdmSk=?= , "chunkuang.hu@kernel.org" , =?utf-8?B?Sml0YW8gU2hpICjnn7PorrDmtpsp?= , "daniel@ffwll.ch" , "p.zabel@pengutronix.de" , "airlied@gmail.com" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group Subject: Re: [PATCH] mediatek: dsi: Add dsi per-frame lp code for mt8188 Thread-Topic: [PATCH] mediatek: dsi: Add dsi per-frame lp code for mt8188 Thread-Index: AQHadfPkOYxnhk7qmk2FGd0xEv068rFALL6A Date: Wed, 20 Mar 2024 06:03:27 +0000 Message-ID: <2a0a4d12edfc92d40d5ae463f8a261e8799ddafa.camel@mediatek.com> References: <20240314094238.3315-1-shuijing.li@mediatek.com> In-Reply-To: <20240314094238.3315-1-shuijing.li@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|SEYPR03MB7190:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H5gfaSaXmXTApT+1U1TVZEzwF2NJjU1kE7t72Q6O3hw+GUS2fPW9g9NeP15ZGEM/+Lhj2NRjcZewZWfmGuT7bWsYdK4TT3fFu+k828QJT7sHtEf3o1IMkVC3EHBgiqZgqqMPVsku2FPzHS2YEuEL2zFbNxLN/q11AJJPgJgakSEaIR4oVDAIJkOj9CWOYK1aEW24Jvc1LebZBDwOlaOuc97n0g10VGV28tCv3lLIDSuFt6Bgch6HYkF2ZsAzgFHMCCl9j2zrFRz83FV/z+wGMGaYnp3Oc5UYL3+pKJMYGgvvJe42y3G1mqTQcQbEKv/Tbp7Ij/8sHndIOXIniDxxokQYZBxaN9Wm4CSbi8IFru909RzDjdjvPqwSbk1FcPKiCwIFMxnrtvz7jOHQQ8TQpV6YFq+vjbewI4Np7xffWEJxPN1LLEc747ubuBJMeAK3pjzA7O9fEpWm4Bqd/QqffHApC+tYQa2geYZhvHiZJNHqw+wFfmXalYVUtsjxjAZbgRfzx2bbm/3XqdZQnLjhzlWslnpYARCsdgZinKlkCTowXEJ/nGEodBFJaYV3EN9pR4y3JopWd+peASVo2jEVfTT9cOhSrg4U0K2aZMFDRq+7Ptly3sf7wBV5cf97Ua/WDsuuCOybaUL6H2d3wEL1FxpgIKSa4f0b+s/K1qPZmQw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(7416005)(376005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q2UycmhkQ3MyZzJIY2FxTWphSnVhN3huZGtmQTNzVzhScXNJck04Vm5pWWhK?= =?utf-8?B?SktWVlVVNjd0ZHJOQkYrWjlmazhOY1QyWXVoWXNqYWtNTSt4YUd0ejIreEpQ?= =?utf-8?B?amlrNy9EbUY0Y2N2KzVkZ3hzRi9uREhlYnVsMkluQ0NKLzEvczA1TnBQV2JV?= =?utf-8?B?eTFEczhualZ1NlJlc004WVJyUXo3YjBJQVBrT1FTcXVnOWxLZHNGbEF4QXhp?= =?utf-8?B?Wit1RkdKZG55WWwydWIwTVlDU3g1c3NGVHhQMkxJSkpEWVRRWUVMOU8ycjNN?= =?utf-8?B?bnZCR3E4Q0Q2T2h0b2dubHZ6d1B1b1JpQ0UwNG5RSFJBbzZNdUlCS0hOTWdQ?= =?utf-8?B?U3RFdUVwUFV3OTZoc1ZVUDdNWmFlQkdHZEhXSmQvRFJMVjR1RnhvVFBWU0t0?= =?utf-8?B?eFJ2eHhZQXZ0L3NaSkxpUGNLMkkwZlM0L2Z5Ry8xeVFOUDlDQnlEdm04clRw?= =?utf-8?B?MXA0L1NWQUYyVFlFcXhuYXh6bFhJWlZxSGRXNnBxUmRiekppL0I5NS82UU43?= =?utf-8?B?RjlCZDRhdm5sa2hxT3ordk5ySFlzVkVRcHhsemRCQlVIM21uMGtGODl0WS9H?= =?utf-8?B?YzlKd0g2ZTl0WlE5ZTJMcG1NbzU2Y0Z4L0xFQ1JkdGJHeFl6RGp5U0FMdmxI?= =?utf-8?B?KzlJL01GaXVuSW5EYXpLWkpGK3EwZGlzZEhyclloMUxVa296N0wzRWl4SnFt?= =?utf-8?B?NytuQ3N3Q2hLdW5EeDd5eHlWR3dmY05BbExCMUhrMG1ITCtPZUdPSlFkSFVh?= =?utf-8?B?WGFVaHBYODlJRUlMc3NJRFA3V2NDN2xXUEU2NkpWck1ONEVwZEtJTEpvdEN3?= =?utf-8?B?VklRc0lUZzdSWHNRM0FxTVFXNkEzTWlEWUVXTEtzMFQxT2hzaHNpQ09qdUdh?= =?utf-8?B?KzdZK0ZOQmpUUUFkbzQ2NjF3Z1QvMjhqNjBtYWN0S3VpRDFFOFhaRUlVZ1gz?= =?utf-8?B?ZUFoWDZnN1BqcDhVL3hzMnRBWlhQbFp3b0pneFhlSCtYejlONnI1N1Q4NEhU?= =?utf-8?B?QUJiWFJsZ2t6V0Z4UzEwZFJuOWJnS1kvUmdhZTF6bis4VUI3aHF3M1A1RnZQ?= =?utf-8?B?QUNxMURiUWhERTBaOXBNQTZQcS95OGZ4TUxjUGVNR2RqMFNJUFlsVGVUejB0?= =?utf-8?B?Z0ptMFFxZ3dXcnNVM0dpOW1mUVFlODZmZ3FFQjZYS1N6S3hydGx5S0xPUzh6?= =?utf-8?B?ZWl6TmdObjBWTkpBMzd4TXZkMGZKanZxdkFYSkZ4NVRjcnh6VDdFNnh6Vkp1?= =?utf-8?B?TWFTTDEwRTY4clpWZjlPUUFjc3VsMmh5MzZ2TkNyTmRSSEhqOTVUa2xFYVRy?= =?utf-8?B?c29jci8yRU14OFdYNFFoNjg4WEJSSWpoQStSWWhtYkl6b1BIaTRJaWtKRGZC?= =?utf-8?B?UDVIdGNuSm51MVI3N3dKd29VNVYxWjVCL2RUVFNMNGJHZ1BrbnMvNEo1eFlm?= =?utf-8?B?dHZHRjdodDR1QkJFVWpDR21xeXJVTy9uODIzbnd5L3cybjRiVWFVRjZKZjFh?= =?utf-8?B?dmZhSTZLMVdvcjczcVVFc3QvaGVxc2svNVlMU2V4OTZRVjJFRkZlRG1tMlZF?= =?utf-8?B?c0lKSUw1a3lsOWNhaEJoNFRtUlVSM0ovVjkvcEFIU2l2UnRBVDlXVlVCRzBx?= =?utf-8?B?L1NCSEh5cTVBNlc1ZGFJS2tZVWwwWjZzM2YwUEJMcHJCUWpVbmk0N0h0QkdI?= =?utf-8?B?V3VuN0Q4akV1cXJhaEd4cWF6VjI0bnRRcnhCQWo0NU12amdqWW1kd3Q1cThT?= =?utf-8?B?VHF2L2tPY01CeTBhdkEyRjdiQlh5QWtwZHl1eTZhMHAvMTF0UDN4MWN4eHc4?= =?utf-8?B?Qkt0aVd6TlBHVDhpZWlDU3EzcWQzeFdyQk5mZ0dkZkN1MUtZREhNVks4TzF3?= =?utf-8?B?ZUY1VGR2cFR0SGFsR3RvWjkyMEZORmpSbEp3cU1DaUlORmJQdE1zN3c5TTVR?= =?utf-8?B?bmJRcU0rVnVxUnNPK1BYaFF2ZC81UnNoUHNzV21qRE41cm1icTNHaHp6Wko1?= =?utf-8?B?T0NQeU5XT3VnTkRXNXQva1psTUVaaGg4dEs1ckM1bE03bEZra01QNjJXV2xK?= =?utf-8?B?ZWtKaDlJZ0U1MklWMDRIK0ZGeWcxendPUlRwQlJMZHRrOVlqQlozeWRET1Jj?= =?utf-8?Q?yuXuPB3Ctb8qBhuUHVdYFsW7X?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d35d0ba-eb2e-45bd-9f7e-08dc48a37620 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2024 06:03:27.8154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Is7Y0PAmzTIAvHtfY/hcB7G1nH2E8LW00W0PJVXjzE0lJ+EnJ5hSUd/ZBX3+B7DVaKMoy8nVNCs5f4cZl9c6qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR03MB7190 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_232419_773330_E5DA4672 X-CRM114-Status: GOOD ( 25.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Shuijing: Add 'drm/' in the title. On Thu, 2024-03-14 at 17:41 +0800, Shuijing Li wrote: > Adding the per-frame lp function of mt8188, which can keep HFP in HS > and > reduce the time required for each line to enter and exit low power. > Per Frame LP: > |<----------One Active Frame-------->| > --______________________________________----___________________ > ^HSA+HBP^^RGB^^HFP^^HSA+HBP^^RGB^^HFP^ ^HSA+HBP^^RGB^^HFP^ > > Per Line LP: > |<---------------One Active Frame----------->| > --______________--______________--______________----______________ > ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^ ^HSA+HBP^^RGB^ As I know, some low power mode would has some side effect. For example, CPU dvfs would let CPU run in low frequency when CPU is idle, but when CPU is suddenly busy, it would take some time to let CPU frequency speed up and may cause some real time issue. Does this have any side effect. If so, please describe it. > > Signed-off-by: Shuijing Li > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 100 > +++++++++++++++++++++++++++++ > 1 file changed, 100 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index a2fdfc8ddb15..e6f4807c8711 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -83,6 +83,7 @@ > #define DSI_HSA_WC 0x50 > #define DSI_HBP_WC 0x54 > #define DSI_HFP_WC 0x58 > +#define DSI_BLLP_WC 0x5C > > #define DSI_CMDQ_SIZE 0x60 > #define CMDQ_SIZE 0x3f > @@ -180,6 +181,7 @@ struct mtk_dsi_driver_data { > bool has_shadow_ctl; > bool has_size_ctl; > bool cmdq_long_packet_ctl; > + bool support_per_frame_lp; > }; > > struct mtk_dsi { > @@ -516,6 +518,103 @@ static void mtk_dsi_config_vdo_timing(struct > mtk_dsi *dsi) > (vm->hactive * dsi_tmp_buf_bpp + 2) % dsi- > >lanes; > } > > + if (dsi->driver_data->support_per_frame_lp) { > + unsigned int lpx = 0, da_hs_exit = 0, da_hs_prep = 0, > da_hs_trail = 0; > + unsigned int da_hs_zero = 0, ps_wc = 0, hs_vb_ps_wc = > 0; It's not necessary to initialize to zero because these variable would be assigned to other value later. > + u32 bllp_wc, bllp_en, v_active_roundup, hstx_cklp_wc; > + u32 hstx_cklp_wc_max, hstx_cklp_wc_min; > + > + da_hs_trail = (readl(dsi->regs + DSI_PHY_TIMECON0) >> > 24) & 0xff; operator '>>' has higher priority than operator '&', so it's not necessary to add '()'. > + bllp_en = (readl(dsi->regs + DSI_TXRX_CTRL) >> 7) & > 0x1; > + if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) { > + horizontal_sync_active_byte = > + (vm->hsync_len * dsi_tmp_buf_bpp - 10); '()' is redundant. > + horizontal_backporch_byte = > + (vm->hback_porch * dsi_tmp_buf_bpp - > 10); ditto. > + horizontal_frontporch_byte = > + (vm->hfront_porch * dsi_tmp_buf_bpp - > 12); ditto. > + > + ps_wc = readl(dsi->regs + DSI_PSCTRL) & 0x7fff; > + v_active_roundup = (32 + > horizontal_sync_active_byte + > + horizontal_backporch_byte + ps_wc + > + horizontal_frontporch_byte) % dsi- > >lanes; > + if (v_active_roundup) > + horizontal_backporch_byte = > horizontal_backporch_byte + > + dsi->lanes - v_active_roundup; > + hstx_cklp_wc_min = (DIV_ROUND_UP((12 + 2 + 4 + > + horizontal_sync_active_byte), dsi- > >lanes) + da_hs_trail + 1) > + * dsi->lanes / 6 - 1; > + hstx_cklp_wc_max = (DIV_ROUND_UP((20 + 6 + 4 + > + horizontal_sync_active_byte + > horizontal_backporch_byte + > + ps_wc), dsi->lanes) + da_hs_trail + 1) > * dsi->lanes / 6 - 1; > + } else { > + horizontal_sync_active_byte = vm->hsync_len * > dsi_tmp_buf_bpp - 4; > + > + horizontal_backporch_byte = (vm->hback_porch + > vm->hsync_len) * > + dsi_tmp_buf_bpp - 10; > + hstx_cklp_wc_min = (DIV_ROUND_UP(4, dsi->lanes) > + da_hs_trail + 1) > + * dsi->lanes / 6 - 1; > + > + if (dsi->mode_flags & > MIPI_DSI_MODE_VIDEO_BURST) { > + ps_wc = readl(dsi->regs + DSI_PSCTRL) & > 0x7fff; > + bllp_wc = readl(dsi->regs + > DSI_BLLP_WC) & 0xfff; > + horizontal_frontporch_byte = (vm- > >hfront_porch * > + dsi_tmp_buf_bpp - 18); > + > + v_active_roundup = (28 + > horizontal_backporch_byte + ps_wc + > + horizontal_frontporch_byte + > bllp_wc) % dsi->lanes; > + if (v_active_roundup) > + horizontal_backporch_byte = > horizontal_backporch_byte + > + dsi->lanes - v_active_roundup; > + if (bllp_en) { > + hstx_cklp_wc_max = > (DIV_ROUND_UP((16 + 6 + 4 + > + horizontal_backporch_by > te + bllp_wc + ps_wc), > + dsi->lanes) + > da_hs_trail + 1) * dsi->lanes / 6 - 1; > + } else { > + hstx_cklp_wc_max = > (DIV_ROUND_UP((12 + 4 + 4 + > + horizontal_backporch_by > te + bllp_wc + ps_wc), > + dsi->lanes) + > da_hs_trail + 1) * dsi->lanes / 6 - 1; > + } > + } else { > + ps_wc = readl(dsi->regs + DSI_PSCTRL) & > 0x7fff; > + horizontal_frontporch_byte = (vm- > >hfront_porch * > + dsi_tmp_buf_bpp - 12); > + > + v_active_roundup = (22 + > horizontal_backporch_byte + ps_wc + > + horizontal_frontporch_byte) % > dsi->lanes; > + if (v_active_roundup) > + horizontal_backporch_byte = > horizontal_backporch_byte + > + dsi->lanes - v_active_roundup; > + > + hstx_cklp_wc_max = (DIV_ROUND_UP((12 + > 4 + 4 + > + horizontal_backporch_byte + > ps_wc), > + dsi->lanes) + da_hs_trail + 1) > * dsi->lanes / 6 - 1; > + } > + } > + hstx_cklp_wc = (readl(dsi->regs + DSI_HSTX_CKL_WC) >> > 2) & 0x3fff; Hardware register is set according to software variable, so you could get this value from software variable. DSI_HSTX_CKL_WC is set in mtk_dsi_ps_control_vact() as ps_wc, so you could use ps_wc instead of read it back from register. Regards, CK > + if (hstx_cklp_wc <= hstx_cklp_wc_min || > + hstx_cklp_wc >= hstx_cklp_wc_max) { > + hstx_cklp_wc = (hstx_cklp_wc_max / 2) << 2; > + writel(hstx_cklp_wc, dsi->regs + > DSI_HSTX_CKL_WC); > + } > + hstx_cklp_wc = hstx_cklp_wc >> 2; > + if (hstx_cklp_wc <= hstx_cklp_wc_min || > + hstx_cklp_wc >= hstx_cklp_wc_max) { > + DRM_WARN("Wrong setting of hstx_ckl_wc\n"); > + } > + > + lpx = readl(dsi->regs + DSI_PHY_TIMECON0) & 0xff; > + da_hs_exit = (readl(dsi->regs + DSI_PHY_TIMECON1) >> > 24) & 0xff; > + da_hs_prep = (readl(dsi->regs + DSI_PHY_TIMECON0) >> 8) > & 0xff; > + da_hs_zero = (readl(dsi->regs + DSI_PHY_TIMECON0) >> > 16) & 0xff; > + ps_wc = readl(dsi->regs + DSI_PSCTRL) & 0x7fff; > + hs_vb_ps_wc = ps_wc - > + (lpx + da_hs_exit + da_hs_prep + da_hs_zero + > 2) > + * dsi->lanes; > + horizontal_frontporch_byte = (1 << 31) > + | (hs_vb_ps_wc << 16) > + | (horizontal_frontporch_byte); > + } > writel(horizontal_sync_active_byte, dsi->regs + DSI_HSA_WC); > writel(horizontal_backporch_byte, dsi->regs + DSI_HBP_WC); > writel(horizontal_frontporch_byte, dsi->regs + DSI_HFP_WC); > @@ -1246,6 +1345,7 @@ static const struct mtk_dsi_driver_data > mt8188_dsi_driver_data = { > .has_shadow_ctl = true, > .has_size_ctl = true, > .cmdq_long_packet_ctl = true, > + .support_per_frame_lp = true, > }; > > static const struct of_device_id mtk_dsi_of_match[] = { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel