From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60046606A334 for ; Sun, 8 Nov 2026 18:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=k4mJW4bu; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=PUN0WCrK DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=idbZZdn1SuOKgz4rauQtb73BBm+iL+Kf0sgPmQoAV8A=; b=k4mJW4bu9l1JH9 vTrv7JOLKL/ihJH0QWkb2nl6myspPKv2SKnHX5Dbp9nkIM3Pra6luXvpMzt17wXUAn3WQDjlXDxBm /x4O92xAFUDJVeHqrTTdR09BCDMJDJ6qNRXrmEgiaOuDOuogYVdFiW7qhXmNhgRqUBMi9uI51wmKi i2rDdJWOr1OQDSBtqNsa/M5AegTyRaLIl2NfyrlOrPuLXR6mVBaZ23/ahuEfLJpY4k+A4xcg55wxc UnstnP8L2QqCziFJWSVh1dB7qJGngD1Oa4q+j/lS44MNsMlO+VzSln4oZI5OtzYAnoU34dkDk92Kl Pko/yMkHpEaRx7t4c4pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQ7aW-0000000GU1D-125y; Sun, 08 Nov 2026 18:25:56 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQ7aV-0000000GU11-2dhv; Sun, 08 Nov 2026 18:25:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0822F40606; Sun, 8 Nov 2026 18:25:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E476A1F0089F; Sun, 8 Nov 2026 18:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794162354; bh=idbZZdn1SuOKgz4rauQtb73BBm+iL+Kf0sgPmQoAV8A=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=PUN0WCrKv0kOZLULktHuNYch9QCXMUz3JcXKhYltea5si9QLYpK6FSQYpTTWkkQDJ o3Vs5WmveOPcHwW8u+LZWIvRyYsAm0I4sgYnsa2HgFDSVOc5YHrJpSrC17bEQvBPtS xPXFwb+NeFQyhd9c2nFYoWghDXgr32gE/uLe0cEy+iTIlxzVElqn2AF+AeNYKO6d61 2HQlOc1vTl2gGLboP1xKfJYCOQ6LW6nSJ9tpmdUMR1Ge28C3FEBs+yWFilVuvbtCMU ejfFP7khTkGmx8xFXEA8OKL2Pp0COHNbgmu3aodcTDkjEJMJa9KNuuRgIv5ja8Bgke PLuv9ZuV0iBng== Message-ID: <2a1fb3a2-6adf-47d3-9aae-2ac46ca95cea@kernel.org> Date: Sun, 8 Nov 2026 19:25:48 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] phy: apple: atc: Add initial M3 series support To: Sasha Finkelstein Cc: Janne Grunau , Neal Gompa , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261108-t8122-phy-v1-0-c2783b2a53a8@chaosmail.tech> <20261108-t8122-phy-v1-3-c2783b2a53a8@chaosmail.tech> <4a6ae329-0d73-4ab7-bd87-7acafcb8778b@kernel.org> Content-Language: en-US From: Sven Peter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/8/26 19:21, Sasha Finkelstein wrote: > On Nov 8, 2026, at 19:17, Sven Peter wrote: >>> /** >>> * struct apple_atcphy - Apple Type-C PHY device struct >>> * @np: Device node pointer >>> @@ -599,9 +647,10 @@ struct apple_atcphy { >>> struct apple_tunable *lane_usb4[2]; >>> } tunables; >>> + const struct atcphy_hw *hw; >>> enum atcphy_mode mode; >>> - bool swap_lanes; >>> int dp_link_rate; >>> + bool swap_lanes; >> ugh.. somehow dropped this comment from the email i just sent.. >> is there any reason you move swap_lanes around here? > It saves 3 bytes of alignment padding. Yes, it makes no sense on > machines of that performance class, but I could not resist. Can drop it > in v2. Fine with me either way ;) Sven