From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B7C1C71141 for ; Sat, 14 Jun 2025 08:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4ETVyAEu+mCnw7Aoo8sghtHkONxhtFSL8TYuVFAPM7A=; b=rz6WeeVAJHcpmTk2Z1o+c1Qjmj 5a8eKQi6IBnAPW3/a7j+WDpUrg8oLiBXd8mAalHnE4ucpDFHLNgs1zdDC5KBJZIRDlnijVOBkTLEf /IAdsPB65i9xbwRw7DeFwkVCssJaW8ndhi5AyLi+x+85rCXocd6oOHLIHmPzu4YJi4HPzz8OJpkT0 9ZyjOqW+MwU7vE/jtSqrgxt2lLp1/fN7hWbz4vYzEEH+8Ck1uvV01pr52R1ujIhoOW7KDGZINKAqX Ru6V4PLaKVaJBsBS2/E3/L4C6q6URHXlM0GesOMwpESizTtnBYDHVVSoZO6bibXRO5Z7RveWIU+hd ifFf9oxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQLwY-00000000xtp-0NyF; Sat, 14 Jun 2025 08:08:50 +0000 Received: from mail-dm6nam12on20624.outbound.protection.outlook.com ([2a01:111:f403:2417::624] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQL7P-00000000rbe-1Htu for linux-arm-kernel@lists.infradead.org; Sat, 14 Jun 2025 07:16:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SUNEl4XNdkGp80bPoixicKYwwuOVhXVJTjTQDC7QA/3C0JgaqCIjTbkBnlxGKNJwJqT8KrjQsJt9vUhd/yt8AwQ1GV/7osuZQmigQ4+hK/ZQjr/vvbpRyy/cXPfpPynGNKzoaevPa1f+IHySMvokhrz8JBJhRxCFfxShwQXY+Dp9MxHQfuGML/JtNESLpcUt5ncAmtmDGrwczmMJEZ+E0wuqFIgxKXNjrgeiJsFx42+xIDFtHlIfc08tiu0v1UP9V4/2G0Nz10lc/3xKjj1XFMPWqqIMqdaaSLU4FsufGyZJt0OSm1UAbGpxg/0VcqMpJZbgag+6h34RiLJZAs0hiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ETVyAEu+mCnw7Aoo8sghtHkONxhtFSL8TYuVFAPM7A=; b=Uzhypl0Yvn0g8qmvNDHwX1OnW6yKs4MKoobd85o1B0z6IXcsgkSvT4eKrniJFOD5RwlWCtcHmMbcIv1TKE5yK/n4iMzX2OkldwAvIeR/YTupnPSfIFeJ7CK/o3vHH8ziw1EOMJskTIXFNVLGgeJmhBPM1WasApg0CUcoaCKxaVJsqomAAZJkyGMQBWhUzrcJ6XqFujy5m26RUBHAjyqS4P9DLhWHnEZxcMdtTKuuUSjlimif20nugqfx+bju5C8NvWIYKff1AQOwuDVTBYFRdocWMNW/Z+Ma5zHnakVUZlO2owu77BYDZBi8PzZFxoTNrVXmMBlCSs02sZNpu1Ujkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ETVyAEu+mCnw7Aoo8sghtHkONxhtFSL8TYuVFAPM7A=; b=JwdhaL7MCgP+qgc6ncx9qSXjOY3WQaj0M50Sv1W8eozrLyx4Tq1l+pAd58WjWfpPvanNjgc6ud6QTx09Fe/UUZ5JBtWrOObFCDEaUlkbWmLOlegXxS8xC7Cxq1InsgDOpoV0eyKctlYM0Fx7yHsw2XY7glcVdlqPzGo0iFk/+piy3H/FfntYh4yVQaeJqmleK3EF7XySSgUUbeVeLycNYVOQZN/0Rub9KWUH+pESTEkd1xybGYD01hO1LZwUlKLZwIVuXBsIWpec32cUshDGI0w/JApSH6rykXImWqsnvLK0McCzX/aP7RKnd5MkMgAjELLWzSXirMgi5nLRZZm/rw== Received: from BL1PR13CA0387.namprd13.prod.outlook.com (2603:10b6:208:2c0::32) by DM4PR12MB5723.namprd12.prod.outlook.com (2603:10b6:8:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.22; Sat, 14 Jun 2025 07:15:53 +0000 Received: from BL02EPF0001A0FE.namprd03.prod.outlook.com (2603:10b6:208:2c0:cafe::54) by BL1PR13CA0387.outlook.office365.com (2603:10b6:208:2c0::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.18 via Frontend Transport; Sat, 14 Jun 2025 07:15:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF0001A0FE.mail.protection.outlook.com (10.167.242.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.15 via Frontend Transport; Sat, 14 Jun 2025 07:15:52 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 14 Jun 2025 00:15:41 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sat, 14 Jun 2025 00:15:40 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sat, 14 Jun 2025 00:15:39 -0700 From: Nicolin Chen To: , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v6 22/25] iommu/tegra241-cmdqv: Simplify deinit flow in tegra241_cmdqv_remove_vintf() Date: Sat, 14 Jun 2025 00:14:47 -0700 Message-ID: <2a4e9a40715109ef66957e79e7d021e505cf069a.1749884998.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FE:EE_|DM4PR12MB5723:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fe1cd43-a7ba-4ac5-7852-08ddab134c48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0qOnL3+xaNUrsHmhMv4ROi+As0n4lYUEvFXPwTRP0+12YsXy3H5UAiPcBWCx?= =?us-ascii?Q?FolIMwrGIhwi42jQ3CA3VkbLeIivcMTaNs9rXI2gQNWAZSUExrfdCxjpq55N?= =?us-ascii?Q?SpLSqSLOVaUeGHPxDIAuk0X9XKVzevWhTNEDldPpD4+QMP/lXIztqcLv9wl3?= =?us-ascii?Q?9QrVWD+Ne+YIRiVPtxh1YLVNozhfxuHFvCLPDHX5Tlp7poWgQYV+nSsQYsjJ?= =?us-ascii?Q?zsY15goSTF/o40lFaTNdeCVFhEZ9gOZ8kWnCCCPyH6W4Vmbx2DRJ+0gKaDcU?= =?us-ascii?Q?S0YGxVtdf+DP7F9uOGeXffw71HqDxGIVqRpzzgY1CPLF1iyJJlW/kb+8Gp8s?= =?us-ascii?Q?YpN8D3ZwWxR+nTy5VPDynGCMslEGY9JqaEby3Acx2QQHIUk6F+R5i9e4s7ru?= =?us-ascii?Q?UMSOXnv13VCuxYJ4Y1Apm9WK99SLpjpfetHGP80NrP3kCIsqX0guRs2JHqsh?= =?us-ascii?Q?BPZnnbsNvIRcEw3WJJcywDW4JRrsF0i6qQQxODE4ZUIlcsPKbXXqFKETn9QL?= =?us-ascii?Q?6MUk76I1RhvE/7lpcJuzO4aub+Bn3UF4VZPrDG/OT0LtX64DeyPgy67xV+RO?= =?us-ascii?Q?jyCyQoiDMRe3wROce3zZI1nz1wXJwRBxLAEBVwXgdWCJW8jDIc7GSn1ICYFf?= =?us-ascii?Q?qxow2qjQ025J/jYrR0ncM6osg0+P/sdgdJ/J6ZqvmnSlIBJaeAGa6EDrIP4D?= =?us-ascii?Q?XhArgk/9s8EY1xtGiIGkhgyID7T/zilDTgqUTYSUIWBLDZ6NFF9vfvutzd3N?= =?us-ascii?Q?AytpDixcM4Gi0Zem6OP2Lj1wNql5+NTg1JZSHOHEpdIvprBPpkWi5tEw++P8?= =?us-ascii?Q?plqqzHMoMbMJrrIK09zctuaZ+CPspBxOSSSB7yagtXoVij+vzzafGBl6FBWl?= =?us-ascii?Q?2QCotkSKddvHJo8CVkU7iWsv3m0diy53vUW7EKOeQPF++SOq0EEWJVGoTLIC?= =?us-ascii?Q?ixlGBC9wluqO8fXY6S8RwnQ/UdUhudjLQu+4KrGw1f0B+bjpVkvGF/g79d7e?= =?us-ascii?Q?lQl29QoGlGwDRLD5+6bzPhqMgF+gbBDnGcwzdv7idyo/d7sVpORkRhaRSBeJ?= =?us-ascii?Q?VlEJFJr8NjQr0n/Adj4Xwt6jzs8+o89LQgDuMyDpQ1EcI27C5Mc/MeGZrc9e?= =?us-ascii?Q?nEim+fA+eMIs5+rffAbKA3R3RSJKz7umnhdNHLI0XMGUv2HWf/OlEUPIHEej?= =?us-ascii?Q?PKqkmk6fFjgbZVQQT7uPva1+Sz9hGpDxhaM2Nfaa/wSWUrspuUcdE1DFiJgt?= =?us-ascii?Q?0QO7rqMksOu6ctbgIQJpei9we3CPe1gH47fuk7c+FkseKj9CuKydcoX3zyiz?= =?us-ascii?Q?sFnZbUPPOPaRkZO3lZp33ZRjOllEiFj9o5tFkQaazZHZwyTVZuniz3XybVDg?= =?us-ascii?Q?n+LzAlcn1nAqwV2vEB6EsbpNRgbx8GIvrsknzdxDCqRCLvkXBxFHXBlHyGcv?= =?us-ascii?Q?RWj+HulbProjWPfh4hGDyVLsG85lstCCyWheq2FeBnXJaG628lEgFuO39ZJC?= =?us-ascii?Q?gaIP1he2onBi1/t37vOqPigXnqamq5Ool5Un?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2025 07:15:52.7005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fe1cd43-a7ba-4ac5-7852-08ddab134c48 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5723 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250614_001559_350764_389F1C5B X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The current flow of tegra241_cmdqv_remove_vintf() is: 1. For each LVCMDQ, tegra241_vintf_remove_lvcmdq(): a. Disable the LVCMDQ HW b. Release the LVCMDQ SW resource 2. For current VINTF, tegra241_vintf_hw_deinit(): c. Disable all LVCMDQ HWs d. Disable VINTF HW Obviously, the step 1.a and the step 2.c are redundant. Since tegra241_vintf_hw_deinit() disables all of its LVCMDQ HWs, it could simplify the flow in tegra241_cmdqv_remove_vintf() by calling that first: 1. For current VINTF, tegra241_vintf_hw_deinit(): a. Disable all LVCMDQ HWs b. Disable VINTF HW 2. Release all LVCMDQ SW resources Drop tegra241_vintf_remove_lvcmdq(), and move tegra241_vintf_free_lvcmdq() as the new step 2. Acked-by: Pranjal Shrivastava Reviewed-by: Jason Gunthorpe Reviewed-by: Kevin Tian Signed-off-by: Nicolin Chen --- drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c b/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c index ba029f7d24ce..8d418c131b1b 100644 --- a/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c +++ b/drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c @@ -628,24 +628,17 @@ static int tegra241_cmdqv_init_vintf(struct tegra241_cmdqv *cmdqv, u16 max_idx, /* Remove Helpers */ -static void tegra241_vintf_remove_lvcmdq(struct tegra241_vintf *vintf, u16 lidx) -{ - tegra241_vcmdq_hw_deinit(vintf->lvcmdqs[lidx]); - tegra241_vintf_free_lvcmdq(vintf, lidx); -} - static void tegra241_cmdqv_remove_vintf(struct tegra241_cmdqv *cmdqv, u16 idx) { struct tegra241_vintf *vintf = cmdqv->vintfs[idx]; u16 lidx; + tegra241_vintf_hw_deinit(vintf); + /* Remove LVCMDQ resources */ for (lidx = 0; lidx < vintf->cmdqv->num_lvcmdqs_per_vintf; lidx++) if (vintf->lvcmdqs[lidx]) - tegra241_vintf_remove_lvcmdq(vintf, lidx); - - /* Remove VINTF resources */ - tegra241_vintf_hw_deinit(vintf); + tegra241_vintf_free_lvcmdq(vintf, lidx); dev_dbg(cmdqv->dev, "VINTF%u: deallocated\n", vintf->idx); tegra241_cmdqv_deinit_vintf(cmdqv, idx); -- 2.43.0