From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49B4DC3DA4A for ; Wed, 21 Aug 2024 02:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fgMs9fxEwK6R86E8GznAkMJVuLhtqjJi/m3zDh7uEHc=; b=Np0lgMte5qbPMVAFtcDZ2ma615 /kYOGOtQOLgor2MqKH1O+tDh/S+/U6TorHNKoV3w+wKfIalPvRx6BbIM8Jm3QM9FX9ISscU4o/839 SnEc2pwTY+nJoKofk4IKHJQ7dFCY4Oo1iRP9fEfQ/ipztZE5kjfNjp0NKAIAbeEFhnklNEjb2wnLf tRLk3JgXU3eYuzLbskzOygLvVoMNL2YMgOohU4VZvzrxnxrwrdHZsDmATBqkoeZ0adh2FmwDjdWay JC2jGK6b0Ju0iDjYoLfm9I5Z+4rZT0XIHodP4mioQc1dfU0tsxactVxywpuo4XwoZ2UuIBWfGETp7 gAgT07Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgayu-00000007GZD-33Bx; Wed, 21 Aug 2024 02:21:52 +0000 Received: from out30-110.freemail.mail.aliyun.com ([115.124.30.110]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgay8-00000007GTO-1wMX for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 02:21:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1724206859; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=fgMs9fxEwK6R86E8GznAkMJVuLhtqjJi/m3zDh7uEHc=; b=hnIdJ/drNXGYcWGGoOYTWU1DYonerHGjSfsOr3fp5YXqLTxLS89ImUg640O1Q0LtNfBizcvMXSlib+hwqA81380t7BrWtvGKKZCg56c49lRrWC/N9NjLk2qmij1gFmwc+61dtaLxe6lZn5L5OIbP+tZxXkzAnC+hDbTCcjDODKU= Received: from 30.15.196.200(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0WDK4yif_1724206855) by smtp.aliyun-inc.com; Wed, 21 Aug 2024 10:20:56 +0800 Message-ID: <2a70eaa3-f1c5-4803-948b-4b8eb86190c6@linux.alibaba.com> Date: Wed, 21 Aug 2024 10:20:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/perf: Fix ali_drw_pmu driver interrupt status clearing To: Mark Rutland Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Shuai Xue References: <1724068110-45239-1-git-send-email-renyu.zj@linux.alibaba.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_192104_860895_70803EE1 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 在 2024/8/20 下午5:18, Mark Rutland 写道: > On Mon, Aug 19, 2024 at 07:48:30PM +0800, Jing Zhang wrote: >> The alibaba_uncore_pmu driver forgot to clear all interrupt status >> in the interrupt processing function. After the PMU counter overflow >> interrupt occurred, an interrupt storm occurred, causing the system >> to hang. >> >> Therefore, clear the correct interrupt status in the interrupt handling >> function to fix it. >> >> Signed-off-by: Jing Zhang > > Presumably this should have > > Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC") > > ... right? You are right, I forgot it. > > With that: > > Acked-by: Mark Rutland > > Mark. > >> --- >> drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c >> index 38a2947..c6ff1bc 100644 >> --- a/drivers/perf/alibaba_uncore_drw_pmu.c >> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c >> @@ -400,7 +400,7 @@ static irqreturn_t ali_drw_pmu_isr(int irq_num, void *data) >> } >> >> /* clear common counter intr status */ >> - clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, 1); >> + clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, status); >> writel(clr_status, >> drw_pmu->cfg_base + ALI_DRW_PMU_OV_INTR_CLR); >> } >> -- >> 1.8.3.1 >>