From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9644BEA3C59 for ; Thu, 9 Apr 2026 12:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eAJORP4yvVpx09va/gLQhRQ8QtEPqvg5cOSSG0sGfbM=; b=nwHuKt1zincpVo/X1ZI1Duuy6Y U/URdYSyGv4D8/gLHwfRyAShvbld2ra3zkFPZ0rFj7Vpk8WltY81fFYnO7wFQSaDQ/qPt05a/DmAx RoqtxuCD4n84ucIZV20w7nnEZDnyFLn/XqodgcGC7R/Z7OsMFh5kyd0f8axEmAtmUGMxu+q1PlR7O q2528PbuxGBj2XdnFwYrt8i0QbzUvlr74vQD8aiW7/gFYytSDNFGADfveD2DK+4uWOM0UIPwDc+75 nWeA90rRM08Rrq26RvzP4wpJzUPfhERwDyGNW5ErwxJfAGfFmhL26qUHdHU4OdfDinkbnHI2A/LWb Y7gcfZ3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wAoIO-0000000AMMl-0Ifi; Thu, 09 Apr 2026 12:15:40 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wAoIM-0000000AMML-0R3k; Thu, 09 Apr 2026 12:15:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 79B6F44187; Thu, 9 Apr 2026 12:15:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4407FC4CEF7; Thu, 9 Apr 2026 12:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775736937; bh=LeCW2P/szJe6cVudyWtP80LMlbY6d4j0KunVlklwTXE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cahYN4isF4wArBwUKnNVy5lfqA30WZJbQcrUj05txqAkLzrZMleHCmGo+CPqJ/8S6 FxuyL2bQycr7XVw1PlWUOg7H7xSr902/7CFOFhAF3BuxnJjO9Djo+OZjXmWqPQE70T lH7Lj4XaObRfvZ5ek3orCsnIfZzs93ZsIwbTltrUmdn6TA9ul/YP07C9wsAa4v7Y15 dWaIE+cvkV+oIn0etM2savnaNOD5G9S68zp+AxjuxLgh2MGKggC2wS+4KD1G3Jglsc 3dr6vczpOA/crzXAhrrG0CfBm9my1CVkrcYLcxYvJvRI3iI3lSpFc1lqxSvZzjvPnk 8+K0JONjvb2jA== Message-ID: <2aa66897-12ce-47c5-993d-e9e1d01a0cdd@kernel.org> Date: Thu, 9 Apr 2026 14:15:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: broadcom: bcm2712: Add the otp nodes to firmware To: Gregor Herburger Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Eric Anholt , Stefan Wahren , Srinivas Kandagatla , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260408-rpi-otp-driver-v1-0-e02d1dbe6008@linutronix.de> <20260408-rpi-otp-driver-v1-3-e02d1dbe6008@linutronix.de> <20260409-imposing-strict-snail-5d2a6f@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260409_051538_212733_2D86E5DF X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/04/2026 14:02, Gregor Herburger wrote: > Hi Krzysztof, > > thanks for reviewing. > > On Thu, Apr 09, 2026 at 10:15:12AM +0200, Krzysztof Kozlowski wrote: >> On Wed, Apr 08, 2026 at 10:00:17AM +0200, Gregor Herburger wrote: >>> The Raspberry Pi 5 has two OTP registers (private and customer), add these >>> to the devicetree. >> >> So this sentence confirms my question on bindings - your device >> raspberrypi,bcm2835-firmware has these, thus you do not need these child >> nodes at all. Neither compatibles. > > I dont't think so. In my understanding the bcm2835-firmware does not > provide the otp registers but only provides the interface to the > registers. Though I don't know the details how this is done but [1] says > that only BCM2712 has 512bits and the others (like bcm2711) have Still the same. s/otp/interface/ so your device provides interface. > 256bits. So both devicetrees have the raspberrypi,bcm2835-firmware node > but only the bcm2712 has the raspberrypi,firmware-otp-private node while the Why does bcm2712 use bcm2835 compatible? Nodes and properties are not a solution. See DTS101 question - "... because my new device, which is compatible with an older one, does not support ..." and answer: No. > raspberrypi,firmware-otp-customer is available in all raspberrys. > >> Drop entire DTS and binding patches. > > If I drop the binding patch how to distinguish the variants? Should I > add a SoC specific compatible? e.g. `raspberrypi,bcm2712-firmware` and > use it in the firmware/raspberrypi driver to add the second otp region? So you have different devices/variants? What is the "variant" here? Writing-bindings asks you to have per device compatible. Why standard rules do not apply here? (see also DTS101) > > Also what I don't understand why we have all the bindings for Neither do I. > 'raspberrypi,firmware-clocks', 'raspberrypi,firmware-gpio', > 'raspberrypi,firmware-reset', 'raspberrypi,firmware-poe-pwm' and > 'raspberrypi,firmware-ts'. What is the difference between these devices > and the otp registers. They are all accessed through the firmware. Best regards, Krzysztof