[PATCH 1/2] Remove unneeded __init from s3c24xx_ts_set_platdata

[PATCH 1/2] Remove unneeded __init from s3c24xx_ts_set_platdata

[Nelson Castillo]

Remove unneeded __init in function definition.

Signed-off-by: Nelson Castillo <arhuaco@freaks-unidos.net>
---

 arch/arm/plat-s3c24xx/devs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-s3c24xx/devs.c b/arch/arm/plat-s3c24xx/devs.c
index 7f686a3..267f36a 100644
--- a/arch/arm/plat-s3c24xx/devs.c
+++ b/arch/arm/plat-s3c24xx/devs.c
@@ -193,7 +193,7 @@ EXPORT_SYMBOL(s3c_device_ts);
 
 static struct s3c2410_ts_mach_info s3c2410ts_info;
 
-void __init s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *hard_s3c2410ts_info)
+void s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *hard_s3c2410ts_info)
 {
 	memcpy(&s3c2410ts_info, hard_s3c2410ts_info, sizeof(struct s3c2410_ts_mach_info));
 	s3c_device_ts.dev.platform_data = &s3c2410ts_info;

[PATCH 2/2] Remove unneeded __init for s3c_nand_set_platdata

[Nelson Castillo]

Remove unneeded __init in function definition.

Signed-off-by: Nelson Castillo <arhuaco@freaks-unidos.net>
---

 arch/arm/plat-s3c/dev-nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-s3c/dev-nand.c b/arch/arm/plat-s3c/dev-nand.c
index 84808cc..a1137a7 100644
--- a/arch/arm/plat-s3c/dev-nand.c
+++ b/arch/arm/plat-s3c/dev-nand.c
@@ -79,7 +79,7 @@ static int __init s3c_nand_copy_set(struct s3c2410_nand_set *set)
 	return 0;
 }
 
-void __init s3c_nand_set_platdata(struct s3c2410_platform_nand *nand)
+void s3c_nand_set_platdata(struct s3c2410_platform_nand *nand)
 {
 	struct s3c2410_platform_nand *npd;
 	int size;

[PATCH 1/2] Remove unneeded __init from s3c24xx_ts_set_platdata

[Uwe Kleine-König]

Hello,

On Wed, Jan 06, 2010 at 04:41:47AM -0500, Nelson Castillo wrote:
> Remove unneeded __init in function definition.
you should only remove '__init's if they are wrong.  And if these are
wrong, you should point out why.
 
Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

[PATCH 1/2] Remove unneeded __init from s3c24xx_ts_set_platdata

[Nelson Castillo]

2010/1/6 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Wed, Jan 06, 2010 at 04:41:47AM -0500, Nelson Castillo wrote:
>> Remove unneeded __init in function definition.
> you should only remove '__init's if they are wrong. ?And if these are
> wrong, you should point out why.

Sure.

It's  because the functions are both marked as __init and they're
exported and we get a warning at build time. I should have written
this in the patch :-/ I'll resend them later if no mpre comments are
received.