From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34B8EFA372B for ; Fri, 13 Sep 2024 08:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/y3Vva3fvwuIn0WsxTO61vMjrXBBZReSc8alqn8Lbu0=; b=06IxplclqTwOHLGjdqLqcUxOZy giCt4rzeijlCvws191NH5WVbU5IaMJuUzWxl5+SugLt1YVTRuoYpBo2RMEfvBn76xb7nnXrpLFsi4 xaZcG2KbKV/aoBfLsCi8e+gr5M46ro2wJHdwSC4k+SCxvtt2Rip20sq3hZqfdbZOd3PylNN0GiAEx X+BAycR8oEAhGhbsaU78pIHtQKZf8jYz7D8UVSjGBpeQl7iIuQC1/cPLvdfkSIkdoh1f2cODVzQpT 8fxa2t9uOEOYzKFI4rvD7mlp7BlLUkBa9M+P7Xj5tsJwGqQHOjZb5+mKhRbR6UBITeEHbGojiBmnR yckHbdVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp1ZM-0000000FJyh-2I4l; Fri, 13 Sep 2024 08:22:20 +0000 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp1YH-0000000FJq0-1c1f for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2024 08:21:14 +0000 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 3BEE11380105; Fri, 13 Sep 2024 04:21:12 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 13 Sep 2024 04:21:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726215672; x=1726302072; bh=/y3Vva3fvwuIn0WsxTO61vMjrXBBZReSc8alqn8Lbu0=; b= kbGjOGVLyhT5AcUPXyJX/gVgfzeBdBZ2k6n4152IS8zOQWEG8okL0/yZvqNsD7IH KeEdZQsdgQvMFXh8G5fPdXJVjYYpt/r9ZDRYic+Uctjb/U0k732HbRI7X8yvPLI+ KA0QTRD3W+eLOGOjrHWXDKrp2SnbGrZ8yN1tWRSwhMm3sRG5ZS5/TuR1RvNXddjr 6JF8Ygk9qzotzdtnhTSo9RfcrDqv/kr0Iw/yMnpPKg6qruwwTWDSoOMyhR6WRnEI kyK/JbR+DQseHUzuvppS7WMQWEZmE0yzjY9iNJG2Ff1RWEjsAdauGsVSWeIeu6uP 0gSzrn0meL79F4MxiO7v3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726215672; x= 1726302072; bh=/y3Vva3fvwuIn0WsxTO61vMjrXBBZReSc8alqn8Lbu0=; b=U Jw/ImulLkS2wu4z1qp6wWly45JBZEkJuLLDmbKcDG0nWZGIlUAgwrGJYiLe8Z60C 3VtBC1QbG4ZeF55S0fhcihHjbOfCEpnwMQFYrHhST1V0CtvV9Bv08QZAB+Rkfyr3 yPK7Klm8vuhWzr3A/8mI39horA5ad1kFHt8EuT6VbkdPDRvNLyFs7tE/XiQQSt1p 8WpEQsWU3k8QqVwgi0o9FtdH4NhaM5spI8YSTjdi4xF4if8PouuYUDlkThAtt9zm JTgBI6YPGoQrUsV4CFopPzrP+AAF2x+Pt/ez6rA1g3P3kfuVoydiE49DmvDATo// k7fhco4CuXNTMGGy8zRdA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejjedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvdek pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehuthhsrghvrdgrghgrrhifrghlse grnhgrlhhoghdrtghomhdprhgtphhtthhopegrughsphdqlhhinhhugiesrghnrghlohhg rdgtohhmpdhrtghpthhtoheprghrthhurhhsrdgrrhhtrghmohhnohhvshesrghnrghloh hgrdgtohhmpdhrtghpthhtoheptggrthgrlhhinhdrmhgrrhhinhgrshesrghrmhdrtgho mhdprhgtphhtthhopehmthhurhhquhgvthhtvgessggrhihlihgsrhgvrdgtohhmpdhrtg hpthhtohepsghrghhlsegsghguvghvrdhplhdprhgtphhtthhopegrnhguihdrshhhhiht iheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlh drohhrghdprhgtphhtthhopehjihhrihhslhgrsgihsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 885EE222006F; Fri, 13 Sep 2024 04:21:11 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 13 Sep 2024 08:20:41 +0000 From: "Arnd Bergmann" To: arturs.artamonovs@analog.com, "Catalin Marinas" , "Will Deacon" , "Greg Malysa" , "Philipp Zabel" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Utsav Agarwal" , "Michael Turquette" , "Stephen Boyd" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Andi Shyti" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Olof Johansson" , soc@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, adsp-linux@analog.com, "Nathan Barrett-Morrison" Message-Id: <2ad02a70-8926-45db-8ab5-503ec1e65552@app.fastmail.com> In-Reply-To: <20240912-test-v1-0-458fa57c8ccf@analog.com> References: <20240912-test-v1-0-458fa57c8ccf@analog.com> Subject: Re: [PATCH 00/21] Adding support of ADI ARMv8 ADSP-SC598 SoC. Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240913_012113_566544_E2613FF9 X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote: > This set of patches based on ADI fork of Linux Kerenl that support > family of ADSP-SC5xx > SoC's and used by customers for some time . Patch series contains > minimal set > of changes to add ADSP-SC598 support to upstream kernel. This series > include > UART,I2C,IRQCHIP,RCU drivers and device-tree to be able boot on > EV-SC598-SOM > board into serial shell and able to reset the board. Current SOM board > requires I2C expander to enable UART output. > > UART,I2C and PINCTRL drivers are based on old Blackfin drivers with > ADSP-SC5xx related bug fixes and improvments. > > Signed-off-by: Arturs Artamonovs Hi Arturs, Thanks for your submission. I've done a first pass of a review now, but the drivers will all need a more detailed review from the subsystem maintainers as well. For the drivers/soc and include/linux/soc portions, I need to do second review round when you have added a description about what these are used for, ideally I would hope that most of those can disappear from the final series when the required bits are moved into other drivers. I commented on one of the bindings about the compatible string, but later saw that the same issue is present in all of the bindings, which each need a more specific identifier for a particular piece of hardware they are compatible with. Arnd