Re: [PATCH v4 05/10] arm64: dts: lx2160a: add sda gpio references for i2c bus recovery

[Josua Mayer <josua@solid-run.com>]

Am 13.03.26 um 15:20 schrieb Josua Mayer:
> LX2160A pinmux is done in groups by various length bitfields within
> configuration registers.
>
> In particular i2c sda/scl pins are always configured together. Therefore
> bus recovery may control both sda and scl.
>
> When pinmux nodes and bus recovery was enabled originally for LX2160,
> only the scl-gpios were added to the i2c controller nodes.
>
> Add references to sda-gpios for each i2c controller.
>
> Fixes: 8a1365c7bbc1 ("arm64: dts: lx2160a: add pinmux and i2c gpio to support bus recovery")
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 28500e8873909..a7fcfb7339f1d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -753,6 +753,7 @@ i2c0: i2c@2000000 {
>  			pinctrl-0 = <&i2c0_pins>;
>  			pinctrl-1 = <&gpio0_3_2_pins>;
>  			scl-gpios = <&gpio0 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -769,6 +770,7 @@ i2c1: i2c@2010000 {
>  			pinctrl-0 = <&i2c1_pins>;
>  			pinctrl-1 = <&gpio0_31_30_pins>;
>  			scl-gpios = <&gpio0 31 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio0 30 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -785,6 +787,7 @@ i2c2: i2c@2020000 {
>  			pinctrl-0 = <&i2c2_pins>;
>  			pinctrl-1 = <&gpio0_29_28_pins>;
>  			scl-gpios = <&gpio0 29 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio0 28 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -801,6 +804,7 @@ i2c3: i2c@2030000 {
>  			pinctrl-0 = <&i2c3_pins>;
>  			pinctrl-1 = <&gpio0_27_26_pins>;
>  			scl-gpios = <&gpio0 27 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio0 26 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -817,6 +821,7 @@ i2c4: i2c@2040000 {
>  			pinctrl-0 = <&i2c4_pins>;
>  			pinctrl-1 = <&gpio0_25_24_pins>;
>  			scl-gpios = <&gpio0 25 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio0 24 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -833,6 +838,7 @@ i2c5: i2c@2050000 {
>  			pinctrl-0 = <&i2c5_pins>;
>  			pinctrl-1 = <&gpio0_23_22_pins>;
>  			scl-gpios = <&gpio0 23 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio0 22 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -849,6 +855,7 @@ i2c6: i2c@2060000 {
>  			pinctrl-0 = <&i2c6_i2c7_pins>;
>  			pinctrl-1 = <&gpio1_18_15_pins>;
>  			scl-gpios = <&gpio1 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio1 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  			status = "disabled";
>  		};
>  
> @@ -865,6 +872,7 @@ i2c7: i2c@2070000 {
>  			pinctrl-0 = <&i2c6_i2c7_pins>;
>  			pinctrl-1 = <&gpio1_18_15_pins>;
>  			scl-gpios = <&gpio1 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +			sda-gpios = <&gpio0 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
Should be &gpio1, queued for v5 ....
>  			status = "disabled";
>  		};
>  
>