* [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name
@ 2023-09-17 8:34 Bragatheswaran Manickavel
2023-09-19 17:04 ` Bragatheswaran Manickavel
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Bragatheswaran Manickavel @ 2023-09-17 8:34 UTC (permalink / raw)
To: rafael, daniel.lezcano, rui.zhang, amitk, shawnguo, s.hauer,
kernel, festevam
Cc: Bragatheswaran Manickavel, linux-imx, linux-pm, linux-arm-kernel,
linux-kernel
Added identifier names to respective definitions for fix
warnings reported by checkpatch.pl
WARNING: function definition argument 'void *' should also have an identifier name
WARNING: function definition argument 'int *' should also have an identifier name
Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
---
drivers/thermal/imx8mm_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
index 14111ccf6e4c..5dc6c18f12df 100644
--- a/drivers/thermal/imx8mm_thermal.c
+++ b/drivers/thermal/imx8mm_thermal.c
@@ -78,7 +78,7 @@
struct thermal_soc_data {
u32 num_sensors;
u32 version;
- int (*get_temp)(void *, int *);
+ int (*get_temp)(void *data, int *temp);
};
struct tmu_sensor {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name
2023-09-17 8:34 [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name Bragatheswaran Manickavel
@ 2023-09-19 17:04 ` Bragatheswaran Manickavel
2023-09-22 9:31 ` Bragatheswaran Manickavel
2023-09-28 7:40 ` Daniel Lezcano
2 siblings, 0 replies; 6+ messages in thread
From: Bragatheswaran Manickavel @ 2023-09-19 17:04 UTC (permalink / raw)
To: rafael, daniel.lezcano, rui.zhang, amitk, shawnguo, s.hauer,
kernel, festevam
Cc: linux-imx, linux-pm, linux-arm-kernel, linux-kernel
On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
>Added identifier names to respective definitions for fix
>warnings reported by checkpatch.pl
>
>WARNING: function definition argument 'void *' should also have an
identifier name
>WARNING: function definition argument 'int *' should also have an
identifier name
>Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>---
> drivers/thermal/imx8mm_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/thermal/imx8mm_thermal.c
b/drivers/thermal/imx8mm_thermal.c
>index 14111ccf6e4c..5dc6c18f12df 100644
>--- a/drivers/thermal/imx8mm_thermal.c
>+++ b/drivers/thermal/imx8mm_thermal.c
>@@ -78,7 +78,7 @@
> struct thermal_soc_data {
> u32 num_sensors;
> u32 version;
>- int (*get_temp)(void *, int *);
>+ int (*get_temp)(void *data, int *temp);
> };
>
> struct tmu_sensor {
Gentle remainder
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name
2023-09-17 8:34 [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name Bragatheswaran Manickavel
2023-09-19 17:04 ` Bragatheswaran Manickavel
@ 2023-09-22 9:31 ` Bragatheswaran Manickavel
2023-09-25 7:47 ` Daniel Lezcano
2023-09-28 7:40 ` Daniel Lezcano
2 siblings, 1 reply; 6+ messages in thread
From: Bragatheswaran Manickavel @ 2023-09-22 9:31 UTC (permalink / raw)
To: rafael, daniel.lezcano, rui.zhang, amitk, shawnguo, s.hauer,
kernel, festevam
Cc: linux-imx, linux-pm, linux-arm-kernel, linux-kernel
On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
> Added identifier names to respective definitions for fix
> warnings reported by checkpatch.pl
>
> WARNING: function definition argument 'void *' should also have an identifier name
> WARNING: function definition argument 'int *' should also have an identifier name
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
> drivers/thermal/imx8mm_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index 14111ccf6e4c..5dc6c18f12df 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -78,7 +78,7 @@
> struct thermal_soc_data {
> u32 num_sensors;
> u32 version;
> - int (*get_temp)(void *, int *);
> + int (*get_temp)(void *data, int *temp);
> };
>
> struct tmu_sensor {
Hi Team, Could someone help in reviewing it.
Thanks,
Bragathe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name
2023-09-22 9:31 ` Bragatheswaran Manickavel
@ 2023-09-25 7:47 ` Daniel Lezcano
2023-09-27 14:38 ` Bragatheswaran Manickavel
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Lezcano @ 2023-09-25 7:47 UTC (permalink / raw)
To: Bragatheswaran Manickavel, rafael, rui.zhang, amitk, shawnguo,
s.hauer, kernel, festevam
Cc: linux-imx, linux-pm, linux-arm-kernel, linux-kernel
On 22/09/2023 11:31, Bragatheswaran Manickavel wrote:
>
> On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
>> Added identifier names to respective definitions for fix
>> warnings reported by checkpatch.pl
>>
>> WARNING: function definition argument 'void *' should also have an
>> identifier name
>> WARNING: function definition argument 'int *' should also have an
>> identifier name
>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>> ---
>> drivers/thermal/imx8mm_thermal.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/thermal/imx8mm_thermal.c
>> b/drivers/thermal/imx8mm_thermal.c
>> index 14111ccf6e4c..5dc6c18f12df 100644
>> --- a/drivers/thermal/imx8mm_thermal.c
>> +++ b/drivers/thermal/imx8mm_thermal.c
>> @@ -78,7 +78,7 @@
>> struct thermal_soc_data {
>> u32 num_sensors;
>> u32 version;
>> - int (*get_temp)(void *, int *);
>> + int (*get_temp)(void *data, int *temp);
>> };
>> struct tmu_sensor {
>
> Hi Team, Could someone help in reviewing it.
Please no more "gentle reminder"
Read:
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/Documentation/process/submitting-patches.rst
Especially, the section _9_
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name
2023-09-25 7:47 ` Daniel Lezcano
@ 2023-09-27 14:38 ` Bragatheswaran Manickavel
0 siblings, 0 replies; 6+ messages in thread
From: Bragatheswaran Manickavel @ 2023-09-27 14:38 UTC (permalink / raw)
To: Daniel Lezcano, rafael, rui.zhang, amitk, shawnguo, s.hauer,
kernel, festevam
Cc: linux-imx, linux-pm, linux-arm-kernel, linux-kernel
On 25/09/23 13:17, Daniel Lezcano wrote:
> On 22/09/2023 11:31, Bragatheswaran Manickavel wrote:
>>
>> On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
>>> Added identifier names to respective definitions for fix
>>> warnings reported by checkpatch.pl
>>>
>>> WARNING: function definition argument 'void *' should also have an
>>> identifier name
>>> WARNING: function definition argument 'int *' should also have an
>>> identifier name
>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>>> ---
>>> drivers/thermal/imx8mm_thermal.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/thermal/imx8mm_thermal.c
>>> b/drivers/thermal/imx8mm_thermal.c
>>> index 14111ccf6e4c..5dc6c18f12df 100644
>>> --- a/drivers/thermal/imx8mm_thermal.c
>>> +++ b/drivers/thermal/imx8mm_thermal.c
>>> @@ -78,7 +78,7 @@
>>> struct thermal_soc_data {
>>> u32 num_sensors;
>>> u32 version;
>>> - int (*get_temp)(void *, int *);
>>> + int (*get_temp)(void *data, int *temp);
>>> };
>>> struct tmu_sensor {
>>
>> Hi Team, Could someone help in reviewing it.
>
> Please no more "gentle reminder"
>
> Read:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/Documentation/process/submitting-patches.rst
>
>
> Especially, the section _9_
>
> Thanks
>
> -- Daniel
>
Hi Daniel,
Understood. Will wait for this to get reviewed.
Thanks,
Bragathe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name
2023-09-17 8:34 [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name Bragatheswaran Manickavel
2023-09-19 17:04 ` Bragatheswaran Manickavel
2023-09-22 9:31 ` Bragatheswaran Manickavel
@ 2023-09-28 7:40 ` Daniel Lezcano
2 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2023-09-28 7:40 UTC (permalink / raw)
To: Bragatheswaran Manickavel, rafael, rui.zhang, amitk, shawnguo,
s.hauer, kernel, festevam
Cc: linux-imx, linux-pm, linux-arm-kernel, linux-kernel
On 17/09/2023 10:34, Bragatheswaran Manickavel wrote:
> Added identifier names to respective definitions for fix
> warnings reported by checkpatch.pl
>
> WARNING: function definition argument 'void *' should also have an identifier name
> WARNING: function definition argument 'int *' should also have an identifier name
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-28 7:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-17 8:34 [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name Bragatheswaran Manickavel
2023-09-19 17:04 ` Bragatheswaran Manickavel
2023-09-22 9:31 ` Bragatheswaran Manickavel
2023-09-25 7:47 ` Daniel Lezcano
2023-09-27 14:38 ` Bragatheswaran Manickavel
2023-09-28 7:40 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).