From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80BD2C67861 for ; Tue, 9 Apr 2024 11:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=te12gLReOvznVROtwkqGV3REwLRyftWJp07eFyNuCJs=; b=fv9xBfzeP3O7dn qwHrd+LxZDD37VujTI6iHYXdeQ59OmFZ6KwmwXt7ZRd2fWpwOPS8kPkc6AdXm/+2qOgnC7sl9+NtE D9Bbik765tYJ9AJnXQWBu5RrvLZSlPwQOZVUdzrBGQs60FNSrZlhLMbdT67R/3cKI2J/ff2RqtGQ3 FTdIpUNw5m8MAPWI+1V8WgrJgN3ZM4QaNWxRhEXxW37HzEQ6/Zh6qXCUAv7c/aZD5Karb0hCviPUW krTipyP/kHQM3lO6enDC9Ug44CaOdUD5Po8wY1DYdJTAW30zJT6xncQ0EFKGKjYP+JCp0FmsiOGuG Z9QmoMAlZr/7DVcohuwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9wP-00000001mMe-33vc; Tue, 09 Apr 2024 11:47:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9wM-00000001mKN-0VkL for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 11:47:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 349A51007; Tue, 9 Apr 2024 04:47:31 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94BEF3F766; Tue, 9 Apr 2024 04:46:59 -0700 (PDT) Message-ID: <2af66586-c528-43be-adee-e1eb6baf00fd@arm.com> Date: Tue, 9 Apr 2024 12:46:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iommu/arm-smmu-v3: Free MSIs in case of ENOMEM Content-Language: en-GB To: Mostafa Saleh Cc: Aleksandr Aprelkov , Will Deacon , Joerg Roedel , Jason Gunthorpe , Nicolin Chen , Michael Shavit , Lu Baolu , Marc Zyngier , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240403053759.643164-1-aaprelkov@usergate.com> <8a7f0218-39e3-4e4b-ba99-7fe4389fb703@arm.com> From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_044702_344217_CFC5A1A9 X-CRM114-Status: GOOD ( 27.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDkvMDQvMjAyNCAxMjozMSBwbSwgTW9zdGFmYSBTYWxlaCB3cm90ZToKPiBIaSBSb2JpbiwK PiAKPiBPbiBUdWUsIEFwciAwOSwgMjAyNCBhdCAxMjoxNzo1NFBNICswMTAwLCBSb2JpbiBNdXJw aHkgd3JvdGU6Cj4+IE9uIDA5LzA0LzIwMjQgMTE6NDMgYW0sIE1vc3RhZmEgU2FsZWggd3JvdGU6 Cj4+PiBIaSBBbGVrc2FuZHIsCj4+Pgo+Pj4gT24gV2VkLCBBcHIgMDMsIDIwMjQgYXQgMTI6Mzc6 NTlQTSArMDcwMCwgQWxla3NhbmRyIEFwcmVsa292IHdyb3RlOgo+Pj4+IElmIGRldm1fYWRkX2Fj dGlvbigpIHJldHVybnMgRU5PTUVNLCB0aGVuIE1TSXMgYWxsb2NhdGVkIGJ1dAo+Pj4+IG5vdCBm cmVlZCBvbiB0ZWFyZG93bi4KPj4+Pgo+Pj4+IEZvdW5kIGJ5IExpbnV4IFZlcmlmaWNhdGlvbiBD ZW50ZXIgKGxpbnV4dGVzdGluZy5vcmcpIHdpdGggU1ZBQ0UuCj4+Pj4KPj4+PiBGaXhlczogMTY2 YmRiZDIzMTYxICgiaW9tbXUvYXJtLXNtbXU6IEFkZCBzdXBwb3J0IGZvciBNU0kgb24gU01NVXYz IikKPj4+PiBTaWduZWQtb2ZmLWJ5OiBBbGVrc2FuZHIgQXByZWxrb3YgPGFhcHJlbGtvdkB1c2Vy Z2F0ZS5jb20+Cj4+Pj4gLS0tCj4+Pj4gdjI6IFVzZSBhcHByb3ByaWF0ZSBmdW5jdGlvbiBmb3Ig cmVnaXN0cmF0aW9uIGZhaWx1cmUgYXMKPj4+PiBKb25hdGhhbiBDYW1lcm9uIDxKb25hdGhhbi5D YW1lcm9uQEh1YXdlaS5jb20+IHN1Z2dlc3RlZC4KPj4+Pgo+Pj4+ICAgIGRyaXZlcnMvaW9tbXUv YXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMgfCA0ICsrKy0KPj4+PiAgICAxIGZpbGUgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMv aW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMKPj4+PiBpbmRleCA0MWY5M2MzYWIx NjAuLjg4MDBhZjA0MWU1ZiAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2FybS9hcm0t c21tdS12My9hcm0tc21tdS12My5jCj4+Pj4gKysrIGIvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNt bXUtdjMvYXJtLXNtbXUtdjMuYwo+Pj4+IEBAIC0zNDAyLDcgKzM0MDIsOSBAQCBzdGF0aWMgdm9p ZCBhcm1fc21tdV9zZXR1cF9tc2lzKHN0cnVjdCBhcm1fc21tdV9kZXZpY2UgKnNtbXUpCj4+Pj4g ICAgCXNtbXUtPnByaXEucS5pcnEgPSBtc2lfZ2V0X3ZpcnEoZGV2LCBQUklRX01TSV9JTkRFWCk7 Cj4+Pj4gICAgCS8qIEFkZCBjYWxsYmFjayB0byBmcmVlIE1TSXMgb24gdGVhcmRvd24gKi8KPj4+ PiAtCWRldm1fYWRkX2FjdGlvbihkZXYsIGFybV9zbW11X2ZyZWVfbXNpcywgZGV2KTsKPj4+PiAr CXJldCA9IGRldm1fYWRkX2FjdGlvbl9vcl9yZXNldChkZXYsIGFybV9zbW11X2ZyZWVfbXNpcywg ZGV2KTsKPj4+PiArCWlmIChyZXQpCj4+Pj4gKwkJZGV2X3dhcm4oZGV2LCAiZmFpbGVkIHRvIGFk ZCBmcmVlIE1TSXMgY2FsbGJhY2sgLSBmYWxsaW5nIGJhY2sgdG8gd2lyZWQgaXJxc1xuIik7Cj4+ Pgo+Pj4gSSBhbSBub3Qgc3VyZSB0aGF0IGlzIHRoZSByaWdodCBmaXgsIGFzIGFsbG93aW5nIHRo ZSBkcml2ZXIgdG8gcHJvYmUKPj4+IHdpdGhvdXQgTVNJcywgc2VlbXMgd29yc2UgdGhhbiBsZWFr aW5nIE1TSSBtZW1vcnkuCj4+Pgo+Pj4gSU1ITywgd2UgY2FuIGp1c3QgYWRkIHNvbWV0aGluZyBs aWtlOgo+Pj4gICAgICAgZGV2X2VycihzbW11LT5kZXYsIOKAnENhbuKAmXQgYWxsb2NhdGUgZGV2 bSBhY3Rpb24sIE1TSXMgYXJlIG5ldmVyIGZyZWVkISAhXG7igJ0pIDsKPj4KPj4gSG9uZXN0bHkg SSBkb24ndCB0aGluayB0aGlzIG1hdHRlcnMuIElmIHdlIGV2ZXIgcmVhbGx5IGRpZCBmYWlsIHRv IGFsbG9jYXRlCj4+IDE2IGJ5dGVzLCBTTFVCIHdvdWxkIGFscmVhZHkgYmUgc2NyZWFtaW5nIGFu ZCBzcGV3aW5nIHN0YWNrdHJhY2VzLCBhbmQgdGhlCj4+IHN5c3RlbSBpcyBkZWFkIGFscmVhZHku Cj4+Cj4+PiBBbHNvLCB3ZSBjYW7igJl0IHVuY29uZGl0aW9uYWxseSBmYWxsYmFjayB0byB3aXJl ZCBpcnFzIGlmIE1TSSBleGlzdHMsCj4+PiBhY2NvcmRpbmcgdG8gdGhlIHVzZXIgbWFudWFsOgo+ Pj4gICAgICAgQW4gaW1wbGVtZW50YXRpb24gbXVzdCBzdXBwb3J0IG9uZSBvZiwgb3Igb3B0aW9u YWxseSBib3RoIG9mLAo+Pj4gICAgICAgd2lyZWQgaW50ZXJydXB0cyBhbmQgTVNJcwo+Pj4gICAg ICAgLi4uCj4+PiAgICAgICBUaGUgZGlzY292ZXJ5IG9mIHN1cHBvcnQgZm9yIHdpcmVkIGludGVy cnVwdHMgaXMgSU1QTEVNRU5UQVRJT04gREVGSU5FRC4KPj4+Cj4+PiBXZSBjYW4gYWRkIHNvbWUg bG9naWMsIHRvIGNoZWNrIGR0L2FjcGkgaXJxcyBhbmQgdG8gY2hvb3NlIHRvIGZhbGxiYWNrCj4+ PiBvciBub3QgYmFzZWQgb24gdGhhdCwgYnV0LCBpZiB3ZSBnZXQgLUVOT01FTSwgKGVzcGVjaWFs bHkgZWFybHkgYXQKPj4+IHByb2JlKSBzb21ldGhpbmcgcmVhbGx5IHdlbnQgd3JvbmcsIHNvIEkg YW0gbm90IHN1cmUgaXTigJlzIHdvcnRoCj4+PiB0aGUgY29tcGxleGl0eS4KPj4KPj4gVGhhdCBs b2dpYyBhbHJlYWR5IGV4aXN0cyBpbiBhcm1fc21tdV9zZXR1cF91bmlxdWVfaXJxcygpIC0gdGhl IG1lc3NhZ2VzCj4+IGhlcmUgYXJlIGluIHRoZSBzZW5zZSBvZiAid2UncmUgZ2l2aW5nIHVwIG9u IE1TSXMgYW5kIGZhbGxpbmcgYmFjayB0byB0cnlpbmcKPj4gd2hhdGV2ZXIgd2lyZWQgSVJRcyB3 ZSBtYXkgb3IgbWF5IG5vdCBoYXZlLiIgVGhlIGNyaXRpY2FsIHBvaW50IGlzIHRoYXQKPj4gd2Un cmUgbm90IHVzaW5nIE1TSXMgZm9yIHNvbWUgcG90ZW50aWFsbHkgYWN0aW9uYWJsZSByZWFzb24s IGkuZS4gaWYgdGhlCj4+IHVzZXIgZG9lcyBleHBlY3QgdGhlIHN5c3RlbSB0byBiZSBNU0ktY2Fw YWJsZSwgdGhlbiBpdCBjb3VsZCBiZSBhbgo+PiBpbmRpY2F0aW9uIG9mIHBlcmhhcHMgYSB3cm9u ZyBvciBtaXNzaW5nIG1zaS1wYXJlbnQsIGZvciB3aGljaCB0aGV5IG1heQo+PiBwdXJzdWUgYSBm aXJtd2FyZSBmaXguIEluIG90aGVyIGNhc2VzIGl0J3Mgbm9ybWFsIGFuZCBleHBlY3RlZCBub3Qg dG8gdXNlCj4+IE1TSXMgdGhvdWdoIChlLmcuIHRoZSBzeXN0ZW0ganVzdCBkb2Vzbid0IGhhdmUg YW4gSVRTKSwgc28gd2UgZG9uJ3Qgd2FudCB0bwo+PiBiZSAqdG9vKiBub2lzeSBhYm91dCBpdC4K PiAKPiBUaGUgY2FzZSBJIGFtIHdvcnJpZWQgYWJvdXQgaW4gdGhpcyBwYXRjaCwgaXMgZm9yIHN5 c3RlbXMgd2l0aAo+IE1TSXMgb25seS4KPiBXaXRoIHRoaXMgcGF0Y2gsIHRoYXQgbWVhbnMsIHdl IGZhbGxiYWNrIHRvIHdpcmVkIGlycXMgd2hpY2ggZG9uJ3QKPiBleGlzdCwgc28gdGhlIGRyaXZl ciB3aWxsIHByb2JlIHdpdGggbm8gaW50ZXJydXB0cyBhdCBhbGwsIHdoaWNoIGluIG15Cj4gb3Bp bmlvbiB3b3JzZSB0aGFuIGxlYWtpbmcgdGhlIG1lbW9yeS4KClRydWUsIHRoZSBsb2dpYyBsb29r cyBhIGJpdCBvZmYgYXQgZmlyc3QgZ2xhbmNlIC0gSSB3YXMgaGFsZndheSB0aHJvdWdoIAp3cml0 aW5nIGEgcmVwbHkgdG8gdGhhdCBlZmZlY3QgLSBidXQgdGhlbiBpZiB5b3UgbG9vayBwYXN0IHRo ZSByZWFsaXR5IAp0aGF0IHRoaXMgaXMgYWxsIGFjYWRlbWljIHNpbmNlIGl0J3MgbmV2ZXIgcmVh bGx5IGdvaW5nIHRvIGhhcHBlbiAKYW55d2F5LCBpZiB3ZSAqZGlkKiBmYWlsIHRvIGFsbG9jYXRl IDE2IGJ5dGVzIGhlcmUsIHRoZXJlJ3MgYW4gCmluY3JlZGlibHkgaGlnaCBjaGFuY2UgdGhhdCBp bW1lZGlhdGVseSBwcm9jZWVkaW5nIGludG8gCmlvbW11X2RldmljZV9zeXNmc19hZGQoKSBpcyBh bHNvIGdvaW5nIHRvIHJlc3VsdCBpbiBhbm90aGVyIChsYXJnZXIpIAphbGxvY2F0aW9uIGZhaWx1 cmUgd2hpY2ggZW5kcyB1cCBhYm9ydGluZyB0aGUgd2hvbGUgcHJvYmUgYW55d2F5LiBQbHVzIAp0 aGUgY2hhbmNlIG9mIHN1YnNlcXVlbnRseSBiZWluZyBhYmxlIHRvIGFsbG9jYXRlIGFueSAKZG9t YWlucy9wYWdldGFibGVzL2V0Yy4gZm9yIGFueSBtZWFuaW5nZnVsIElPTU1VIHVzYWdlIHdvdWxk IHNlZW0gc2xpbS4KCkhvbmVzdGx5IEknZCBiZSBpbmNsaW5lZCB0byBkbyBub3RoaW5nIG1vcmUg dGhhbiBhZGQgdGhlIF9vcl9yZXNldCB0byAKc2h1dCB0aGUgc3RhdGljIGNoZWNrZXJzIHVwLCBh bmQgbm90IHdhc3RlIGNvZGUgYW5kIGRhdGEgb24gYSB1c2VsZXNzIAptZXNzYWdlIGZvciBhIHRo ZW9yZXRpY2FsIGNvbmRpdGlvbiBhdCBhbGwuCgpDaGVlcnMsClJvYmluLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=