From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAF82C54EAA for ; Mon, 23 Jan 2023 16:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0WQMEVG2JcPTeHOhsdG1yjhPBObR/32eQuBkaipkCZU=; b=RH0pzycZveKzF+ vmkEw9hbALdo5tE/2CSfMkadRoFHkxP9B50gK8MNRt5yt9/23XQtQlGVn+Dv6JsQDRR4JtZZjnljD yfwSMWi5oYTnsr2jTFX9/N6uJ13N4vsz+AnYmgO+msAZ147CgrtrMjCNTU0L6aEV5S/pgkraLj0h+ gubXnSXO2SjgSRtvA6SxZq3jcwaDBkTRhVy+J9eVhdpHon8gUe13wJp+kwXcSLbipbUimxI2lKKjF 3zIYu3CG5AgVVm/6zhiAgmuyOAtkTj2DYEvZ5dtR0wxYVhcsqt8U/B/iRPEzLtGy6b2Dc0V8/7seH n2mwFt1aqk/1+Je738tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJzKB-000Pyd-Ue; Mon, 23 Jan 2023 16:05:36 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJz7s-000LE5-1D for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 15:52:55 +0000 Received: by mail-wm1-x330.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so10951758wmb.2 for ; Mon, 23 Jan 2023 07:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b/tZ8f/hKuTnmPmwm/3gfR1U9pPYCEdQziOfOTsHWD8=; b=TCXyArpwkAYCRDfZdgOD2gG5tf1XscU6cRLcpKr8YcqSwXGE1Hbdh6WcdLTcNM1A+v +yiZgwW3u/17k5TuCdfHv5Y7P8vYYeJ71i1Q8xBGLpgr+mo25UedeqZCPViGsKO1p74E Yx3oi0jPjP1m9IaYG3yhyICLWUKaWyPAkxCMqNSvyt6ozOKnlbQHWd9jIrkXbQ3H265S gUZz3KZrXaMntBZkIjne9xs1kbUuY8vYMHXAIAPowBhTznp7akNPSIUTfFKFR9P+0rCE t4qsPaaOFTtr9erNSp21NGWkrwnkxJtgNFOx1fZo8s56ai8iWom8/hn3rETqxhqmCSZM ExsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b/tZ8f/hKuTnmPmwm/3gfR1U9pPYCEdQziOfOTsHWD8=; b=ZWnQvtbNqIl8ISm8S4dTSSxKQe/SdSS/PwbriWSuXvKJZdOKkKQ4Dx/bhvRyDQGGrt gh5s0BL+x+TalB+6XofkllPsA2+vxDOWYMAC6lZAKM44QExnjLa/jSGkKlSG+uhDd+fo lu3wL+F51a8UlkdhJWTWINlmYtQf5HtOWvL40KvDFv8CEcdABeXVxhL2ppJVW+c6VI+b eMTZnDQ1TVJTZZyYjxtJl8+5sYN8R91ZSN5u2M/EIqQFFhzVpb4B2VlF2+lvd68/ynWM jdmtGztfgtxrbA0eBckYC0IXZXS7pS+TkQbaSETNv9z39ly/ay09FGdGo4D5Zr0QaA+G 3zvw== X-Gm-Message-State: AFqh2krq62Lk0efDYHeG9ALRZyqbqgpytft7BXlrk6fAQkW7r8hUZBTK 8rJfq4DOV6lamK0qKxvHoFmebA== X-Google-Smtp-Source: AMrXdXsvW74isMnE439bftM+OiixytOe6bWOxjDuWosmwOrIoj8bddguUkHujZ5s9OEGL+NVoCbNAA== X-Received: by 2002:a05:600c:1d12:b0:3db:53f:baea with SMTP id l18-20020a05600c1d1200b003db053fbaeamr24195728wms.6.1674489168770; Mon, 23 Jan 2023 07:52:48 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f23-20020a7bc8d7000000b003d358beab9dsm10811991wml.47.2023.01.23.07.52.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 07:52:48 -0800 (PST) Message-ID: <2b210dc5-fe63-d295-a488-2988601424f3@linaro.org> Date: Mon, 23 Jan 2023 16:52:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 04/15] dt-bindings: arm: add support for Ambarella SoC Content-Language: en-US To: Li Chen Cc: Li Chen , Rob Herring , Krzysztof Kozlowski , "moderated list:ARM/Ambarella SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-5-lchen@ambarella.com> <7d191871-1025-43a3-20bf-8fc6b3f92c89@linaro.org> <875ycxi8xm.wl-me@linux.beauty> From: Krzysztof Kozlowski In-Reply-To: <875ycxi8xm.wl-me@linux.beauty> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_075252_208720_B4C44078 X-CRM114-Status: GOOD ( 24.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/01/2023 16:09, Li Chen wrote: > On Mon, 23 Jan 2023 16:07:32 +0800, > Krzysztof Kozlowski wrote: >> >> On 23/01/2023 08:32, Li Chen wrote: >>> Create a vendor directory for Ambarella, and add >>> cpuid, rct, scratchpad documents. >>> >>> Signed-off-by: Li Chen >>> Change-Id: I2c29e45c08666489b0d9b588ac37d713f5b723d1 >> >> Please run scripts/checkpatch.pl and fix reported warnings. >> >> Applies to all your patches. Also test them... I have doubts that you >> tested if you actually ignored checkpatch :/ > > Yeah, I checkpatch all patches, and have planned to fix Change-Id finally(manually), > but forget it before sending mails, my bad, sorry. I will remove it in v2. > >>> --- >>> .../arm/ambarella/ambarella,cpuid.yaml | 24 +++++++++++++++++++ >>> .../bindings/arm/ambarella/ambarella,rct.yaml | 24 +++++++++++++++++++ >>> .../arm/ambarella/ambarella,scratchpad.yaml | 24 +++++++++++++++++++ >>> .../bindings/arm/ambarella/ambarella.yaml | 22 +++++++++++++++++ >>> MAINTAINERS | 4 ++++ >>> 5 files changed, 98 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/ambarella/ambarella,cpuid.yaml >>> create mode 100644 Documentation/devicetree/bindings/arm/ambarella/ambarella,rct.yaml >>> create mode 100644 Documentation/devicetree/bindings/arm/ambarella/ambarella,scratchpad.yaml >>> create mode 100644 Documentation/devicetree/bindings/arm/ambarella/ambarella.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/arm/ambarella/ambarella,cpuid.yaml b/Documentation/devicetree/bindings/arm/ambarella/ambarella,cpuid.yaml >>> new file mode 100644 >>> index 000000000000..1f4d9cec8f92 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/arm/ambarella/ambarella,cpuid.yaml >> >> This goes to soc > > Thanks, I wasn't aware that there is a document dir named soc. I will move cpuid yaml > to bindings/soc/ambarella/, and leave other yaml still here. However if device has chip identification features (chipid), then the location is "hwinfo". > >>> @@ -0,0 +1,24 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/ambarella,cpuid.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Ambarella SoC ID >>> + >>> +maintainers: >>> + - Li Chen >> >> Missing description. > > Sorry, description will be added in v2. BTW, does other YAMLs in this patch > also need descriptions? In general yes - we want descriptions which will bring additional information. Description should not repeat title, but add more data. For trivial cases - maybe actually this one SoC ID - you can skip it. > >>> + >>> +properties: >>> + compatible: >>> + const: "ambarella,cpuid", "syscon" >> >> Drop quotes (applies to all your patches) > > OK, thanks! > >> Missing SoC specific compatible. >> >>> + >>> + reg: >>> + maxItems: 1 >> >> Missing additionalProperties. sorry, start from scratch from some >> existing recent bindings or better example-schema. > > Good to know that there is example-schema, thanks! > >>> + >>> +examples: >>> + - | >>> + cpuid_syscon: cpuid@e0000000 { >>> + compatible = "ambarella,cpuid", "syscon"; >>> + reg = <0xe0000000 0x1000>; >>> + }; >>> diff --git a/Documentation/devicetree/bindings/arm/ambarella/ambarella,rct.yaml b/Documentation/devicetree/bindings/arm/ambarella/ambarella,rct.yaml >>> new file mode 100644 >>> index 000000000000..7279bab17d9e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/arm/ambarella/ambarella,rct.yaml >>> @@ -0,0 +1,24 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/ambarella,rct.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Ambarella RCT module >>> + >>> +maintainers: >>> + - Li Chen >>> + >>> +properties: >>> + compatible: >>> + const: "ambarella,rct", "syscon" >> >> All the same problems. > > Well noted. > >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> +examples: >>> + - | >>> + rct_syscon: rct_syscon@ed080000 { >> >> Really? Just take a look and you will see wrong indentation. Also drop >> underscores in node names and "rct". Node names should be generic. > > Sorry for the wrong indentation, will fix it in v2. > > Is it ok to contain underscores in lable? if so, I will change it into > > rct_syscon: syscon@ed080000 { Yes, label can have it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel