From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3A4C43381 for ; Tue, 19 Mar 2019 10:17:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADC3820828 for ; Tue, 19 Mar 2019 10:17:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cdXeU1na"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="AJI5WQiH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADC3820828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jRq3ixZH2jhsAgDa0zqKSNSwG7WqRmbvsG/fSx/Tr+c=; b=cdXeU1naShtIaC J0YG77DMKYhO80bwASKBEmRHYEiOu5FknuHclEqPnNUmnYMyXUoFHiEf81Vwd+VlAJK8y1ircRA/a GSx0UY1vK+wzaJUSXDbLCjhnvL1iXJ1gyupcHwnA11kAL5GB9PYVedb9qQWFWiGW3fiBiUeLVp+CH l7jdFq/Tgh8Gopsc0s7eH/lCS8mHChwAtAsFRGA2TPNalkVloepPiqdELiBVyulvNECrYNdWP32yt 1TjfTCIuhXGSXUpEnAiM7SWSspXF4Vz102GArcU2OqkExu1eh7cLOn7wCCFJHfpNOmLEy90AvtHLe YVBeGezQq73P7u9q/X5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6Bnw-0002Ao-Bb; Tue, 19 Mar 2019 10:17:08 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6Bnh-0001v9-SN for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 10:16:54 +0000 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 19 Mar 2019 03:16:50 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 19 Mar 2019 03:16:52 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 19 Mar 2019 03:16:52 -0700 Received: from [10.21.132.148] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 19 Mar 2019 10:16:50 +0000 Subject: Re: [PATCH] arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support To: Thierry Reding References: <20190318232313.24270-1-thierry.reding@gmail.com> From: Jon Hunter Message-ID: <2b4ec55b-d9f3-3c09-5590-f586609f0b3e@nvidia.com> Date: Tue, 19 Mar 2019 10:16:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190318232313.24270-1-thierry.reding@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1552990610; bh=nX3PadgN1GgQ68TC1zD/Q3MxFc/q5woxUHE9lyXz5yg=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=AJI5WQiHAswwGVEI2NEb9KOt8mB1H4/grGzqlIwXKwbeRxEqHD4TmfHWZObJZGS2W xk2lMwqpvNJ3rR1z8FoFCWI6Zlw5eockHJTD3jo1+DRzKQzLK4y8eOLnmoVtuNOOzQ G+WAE6Mr0vYjVg2AdrlWJ7mnz+rUWKekLYqVkSQRAG2YcX6JciXnAEt05oh8yqxTQg iRyRAYA7IzID4S/2M6NLloFc+Amumiwz+Mu3MrxEbeAsEg7rmDpgcebfqGvVob3UEl E4hJEtBG5L1Eiq7oloz/gLwLZLS9YjQq0yC4ja3e7+7S8VLhqsdP7yuJ6qW4u0JOrc 9HgCAkRQ5PIXQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_031653_930148_47957A1C X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/03/2019 23:23, Thierry Reding wrote: > From: Thierry Reding > > The Jetson Nano Developer Kit is a Tegra X1 based development board. It > is similar to Jetson TX1 but it is not pin compatible. It features 4 GB > of LPDDR4, an SPI NOR flash for early boot firmware and an SD card slot > used for storage. > > HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB 2.0 > and 1 USB 3.0) can be used to attach a variety of peripherals and a PCI > Ethernet controller provides onboard network connectivity. > > A 40-pin header on the board can be used to extend the capabilities and > exposed interfaces of the Jetson Nano. > > Signed-off-by: Thierry Reding > --- > This patch, along with some related patches can be found in the p3450 > branch in the following repository: > > https://github.com/thierryreding/linux > > arch/arm64/boot/dts/nvidia/Makefile | 1 + > .../boot/dts/nvidia/tegra210-p3450-0000.dts | 1911 +++++++++++++++++ > 2 files changed, 1912 insertions(+) > create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts > > diff --git a/arch/arm64/boot/dts/nvidia/Makefile b/arch/arm64/boot/dts/nvidia/Makefile > index 6b8ab5568481..bcd018c3162b 100644 > --- a/arch/arm64/boot/dts/nvidia/Makefile > +++ b/arch/arm64/boot/dts/nvidia/Makefile > @@ -3,6 +3,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb > +dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p3450-0000.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2894-0050-a08.dtb > dtb-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186-p2771-0000.dtb > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts b/arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts > new file mode 100644 > index 000000000000..b1d8a49ca8c4 > --- /dev/null > +++ b/arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts > @@ -0,0 +1,1911 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/dts-v1/; > + > +#include > +#include > +#include > + > +#include "tegra210.dtsi" > + > +/ { > + model = "NVIDIA Jetson Nano Developer Kit"; > + compatible = "nvidia,p3450-0000", "nvidia,tegra210"; I am just curious but any reason why we do not have a dtsi file for the Nano module that we include for the developer kit? Or is there no point because the module and kit will never be separate in this case? The developer kit user guide lists both the module (p3448) and carrier board (p3449) and so was just curious. > + > + aliases { > + ethernet = "/pcie@1003000/pci@2,0/ethernet@0,0"; > + rtc0 = "/i2c@7000d000/pmic@3c"; > + rtc1 = "/rtc@7000e000"; > + serial0 = &uarta; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + memory { > + device_type = "memory"; > + reg = <0x0 0x80000000 0x1 0x0>; > + }; > + > + pcie@1003000 { > + status = "okay"; > + > + hvddio-pex-supply = <&vdd_1v8>; > + dvddio-pex-supply = <&vdd_pex_1v05>; > + vddio-pex-ctl-supply = <&vdd_1v8>; > + > + pci@1,0 { > + phys = <&{/padctl@7009f000/pads/pcie/lanes/pcie-1}>, > + <&{/padctl@7009f000/pads/pcie/lanes/pcie-2}>, > + <&{/padctl@7009f000/pads/pcie/lanes/pcie-3}>, > + <&{/padctl@7009f000/pads/pcie/lanes/pcie-4}>; > + phy-names = "pcie-0", "pcie-1", "pcie-2", "pcie-3"; > + nvidia,num-lanes = <4>; > + status = "okay"; > + }; > + > + pci@2,0 { > + phys = <&{/padctl@7009f000/pads/pcie/lanes/pcie-0}>; > + phy-names = "pcie-0"; > + status = "okay"; > + > + ethernet@0,0 { > + reg = <0x000000 0 0 0 0>; > + mac-address = [ 00 00 00 00 00 00 ]; > + }; > + }; > + }; > + > + host1x@50000000 { > + dpaux@54040000 { > + status = "okay"; > + }; > + > + sor@54580000 { > + status = "okay"; > + > + avdd-io-supply = <&avdd_1v05>; > + vdd-pll-supply = <&vdd_1v8>; > + hdmi-supply = <&vdd_hdmi>; > + > + nvidia,ddc-i2c-bus = <&hdmi_ddc>; > + nvidia,hpd-gpio = <&gpio TEGRA_GPIO(CC, 1) > + GPIO_ACTIVE_LOW>; > + nvidia,xbar-cfg = <0 1 2 3 4>; > + }; > + }; > + > + gpu@57000000 { > + vdd-supply = <&vdd_gpu>; > + status = "okay"; > + }; > + > + pinmux: pinmux@700008d4 { > + pinctrl-names = "boot"; > + pinctrl-0 = <&state_boot>; > + > + state_boot: pinmux { > + pex_l0_rst_n_pa0 { > + nvidia,pins = "pex_l0_rst_n_pa0"; > + nvidia,function = "pe0"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; > + nvidia,io-hv = ; > + }; > + pex_l0_clkreq_n_pa1 { > + nvidia,pins = "pex_l0_clkreq_n_pa1"; > + nvidia,function = "pe0"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; > + nvidia,io-hv = ; > + }; > + pex_wake_n_pa2 { > + nvidia,pins = "pex_wake_n_pa2"; > + nvidia,function = "pe"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; > + nvidia,io-hv = ; > + }; > + pex_l1_rst_n_pa3 { > + nvidia,pins = "pex_l1_rst_n_pa3"; > + nvidia,function = "pe1"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; > + nvidia,io-hv = ; > + }; > + pex_l1_clkreq_n_pa4 { > + nvidia,pins = "pex_l1_clkreq_n_pa4"; > + nvidia,function = "pe1"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; > + nvidia,io-hv = ; > + }; > + sata_led_active_pa5 { > + nvidia,pins = "sata_led_active_pa5"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; > + }; > + pa6 { > + nvidia,pins = "pa6"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; > + }; > + dap1_fs_pb0 { > + nvidia,pins = "dap1_fs_pb0"; > + nvidia,pull = ; > + nvidia,tristate = ; > + nvidia,enable-input = ; > + nvidia,open-drain = ; I am guessing this is generated by the pinmux spreadsheet, but any reason why there is no 'nvidia,function' for some pins? Some that are not used have the function defined as 'rsvd1', however, the above pin does not, but AFAIK it is not used. Otherwise looks good to me! Cheers Jon -- nvpublic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel