From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0561C61DE1 for ; Sun, 30 Aug 2026 16:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GmBfcRy0uBNjSyTd3QM14EIKLu45BjfLWEcmRo1I9Ms=; b=OaV8atcL1fFKiq/fyUjjPv2xr7 bkFhIzz0LF7ZiILmXtQdSz5reNqTKkMEyaBn1wF62FJh3UUuw0+1e7Zg5RRo/WTlzVfFkNUp7mU17 E6HjaUgfJQoMnU9gZpKbWiYrj1j13VdTRo+xpvFzlQTbAzPr328Id9aGfNc8IF2qFXI6B5jkAJlWN KwZXgTtsqmHNSuuKpl9r+8810WQY63ptmwcOU2H8InuKS3aIPR1Wp9hdesHHTUblnt8hptl1c5HuI MgW+qgkUhR5uujaIYTa+OD1DPRj2IpPqZcxLWZIgFHTcwvJDIASYvyOkaXUjRnAwiAN2Qzh2Dlf4M dmSpxvSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x0iKw-00000007uve-1M4C; Sun, 30 Aug 2026 16:24:50 +0000 Received: from sender4-op-o12.zoho.com ([136.143.188.12]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x0iKu-00000007uv2-0THq for linux-arm-kernel@lists.infradead.org; Sun, 30 Aug 2026 16:24:49 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1788107074; cv=none; d=zohomail.com; s=zohoarc; b=XdGy/sr3rnNAf8bb96XvAwHAREUe3cxNcki7E02MDYhicdhOLJ282kjyglQU+XtaWx5TA06MqCm0wk7Q0B/d2OACuwrtYX2cfKlOiSYW9pL9vuP1peRUvK0dpoN34aYQocCRn9dlVG58C9u7MkgUbTiyOBHpI3Nl6NXJxKoozbI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788107074; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=GmBfcRy0uBNjSyTd3QM14EIKLu45BjfLWEcmRo1I9Ms=; b=cjG7BqArSc+oKGncPM+El5jlT03vBF0aMBJG76ONkzviNZ3SramFZHixGtyGtn3WB42lUMyzNueS+mqXEaqBgq5/+5k/2D3ICbkN2HrgX8PeOCK+2aDt8W08potEuvX1myhZOMnymnLmtSGCvM/l+tqwL43601NJHGkqUUnnYKY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=yoavmoshe.com; spf=pass smtp.mailfrom=linux@yoavmoshe.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788107074; s=zoho; d=yoavmoshe.com; i=linux@yoavmoshe.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=GmBfcRy0uBNjSyTd3QM14EIKLu45BjfLWEcmRo1I9Ms=; b=DeGxx07cvLm+imNF4WG1+C4HClXhhNxqAZhzUxJm29XeW/VnL+KUtXpFXAq+lb2P YhkAfbUlBj5xvj30g56/9yaKf9TRPHd7vKY8VlA2E61PA1A26xArZAM6EfUgFPgj2wb 3C+vm/GzQAb6jackRPdpQpYV2fyZ7JSO6/uL+bKU= Received: by mx.zohomail.com with SMTPS id 178810707135525.803322459182027; Sun, 30 Aug 2026 09:24:31 -0700 (PDT) Message-ID: <2bd0c842-d0cb-4ad7-b3a3-fed2000dea83@yoavmoshe.com> Date: Sun, 30 Aug 2026 18:24:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] ARM: imx: Fix suspend/resume crash with Clang CFI To: Sami Tolvanen , Nick Desaulniers Cc: Yo'av Moshe , Frank Li , Sascha Hauer , Russell King , Pengutronix Kernel Team , Fabio Estevam , Nathan Chancellor , Bill Wendling , Justin Stitt , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718111340.159896-1-linux@yoavmoshe.com> <20260827194508.446733-1-linux@yoavmoshe.com> Content-Language: en-GB, sv-SE From: Yo'av Moshe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260830_092448_232781_E747699C X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2026-08-28 10:50 PM, Sami Tolvanen wrote: > Looks reasonable, but this still feels ARM-specific to me. How about > adding the macro to arch/arm/include/asm/linkage.h unless you have > other users in mind? I've now sent a v5 with Nick's macro added to arch/arm/include/asm/linkage.h as you suggested, plus the other fixes Nick asked for: https://lore.kernel.org/all/20260830155100.1020620-1-linux@yoavmoshe.com/ The sashiko-bot's comment on v5 indeed pointed out that imx5, at91 and omap1 might suffer from the same bug: their suspend routines are also fncpy()'d into SRAM without a type hash and called indirectly. They're all ARM, so asm/linkage.h still seems like the right place for the macro. Do you think these need to be fixed as part of this patch, or as follow-ups? I only have my one imx6 device (a Kobo Clara HD), so I'm not sure how to test the fixes for the others. Yo'av