From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD659C433F5 for ; Sat, 16 Apr 2022 19:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BIf2Hziu69zEjsGJS28VeDYepzB9uD7te1JJDTlAGZo=; b=l84jwBFwc/RXDt XXO5Oa2LhspxVutFHW2LqRs1qtNkfdgZB3mfdG/W3bm23xyOHPLPuCC5/laNm15Kw7mnLO1h8pKjG YAdAIeWMGJCpM/K/r0yAkBTfssxERBfYrD9NJPDWCe4hRtRiFpvAozUV5rlUz76d3e6bEkqUijspz N3+YYBWgP77wefe4j8ifdqgyGp/HnO82RCAUQFARJeQrZHij1sHHM5+tCTCdMsVHWnPMQ5XWqRaYs Rz190GzdQTgm6a35f77gpzuPNwZXFrd322m+m3Lm8tV/BEjantSo+BSt/QRCbJzTyaICStBoF+aGU JLiRkCG6w6+wR4i2Fi9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfoG9-00DQyQ-TO; Sat, 16 Apr 2022 19:39:06 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfoG7-00DQxJ-6N for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 19:39:04 +0000 Received: by mail-pj1-x102d.google.com with SMTP id n11-20020a17090a73cb00b001d1d3a7116bso1596022pjk.0 for ; Sat, 16 Apr 2022 12:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=N+DA4t8WHVTUtbydzYgACjP/GeP+iQmNsdDutAJHeuA=; b=ipkj2w+o4JXJ3KVPO0DxLQWuqs4OEyi3UxINeXoIACCYu6fi6SkJQHqTkrYwYGprUQ eFmI7HinPBK1VOkYjtuvYxcz0o+axmOWFuu05Ikj/TH1PrTl1EbSnsUo0T8FWlF4ucXj UIdtITPmr4CiwPguZXFmrLHp1mzUxubJ2PQLWe91Zk2tpcpgQRCgqJsfRW06Go+ljivI D6CuHcdtpbXh1GP7kTxAbofHF6QwSBpbAIYYbNPw9ms5N9bglUTEtjE5UD7rXrParXGc kZzuK5gHoSIDFJqFGQlftcu7Dut1Gv5ZlsMOVF1z39g57L5NEGalhGUQoG6dehteKE89 HYKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=N+DA4t8WHVTUtbydzYgACjP/GeP+iQmNsdDutAJHeuA=; b=ZC3FGOyy7SFEwNV21emEJmcsa7HNJPWL+dlHXCWLB8PDWer3TAc+0G0gB+T1VsqkVY 6/8PnYJMgtdw3m+D6CFEdVROVwBDC1EvM8ef1Ix0nbApX6TFXs8RjUfk+EZ872bqQKCi sHcUiBxX54qWMCdwZF+Z/11oDTV8CDjRk1Kv+hQJ1GPmnAhjTdaF51vXEOfknBUwrpw4 k7KkO7f5/wScRdyT4KofFFAP/kbZ4DHlx2tQJSjm+4FWJ1MXXysOwh7M9M968kDnlPrx 1/rI609B21XXCuOldKevvCIRNwhmJmOJRubgusawmazi1lkBbWAKAR6F//qwyFqcBRAI DSPg== X-Gm-Message-State: AOAM531ygRjdtJHXbOzMTWPYFD2/dFUbbvDPlM8A/5LXBngtaRywSXXr Z+C/U+/wxqcwoK3fZenAC44= X-Google-Smtp-Source: ABdhPJyeyAQ30+cHYCLhpzgXBLBNZ+Oa9HOuk6mMsnj9uqD+miynqPFri5VlK2WPnuSq25kcoNNBeA== X-Received: by 2002:a17:903:11c7:b0:154:b936:d1d4 with SMTP id q7-20020a17090311c700b00154b936d1d4mr4694779plh.78.1650137940950; Sat, 16 Apr 2022 12:39:00 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id g15-20020a056a0023cf00b004e17e11cb17sm7142471pfc.111.2022.04.16.12.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Apr 2022 12:39:00 -0700 (PDT) Message-ID: <2c0e1778-4602-67eb-8481-33e29764c84d@gmail.com> Date: Sat, 16 Apr 2022 12:38:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH net-next v4 04/18] net: dsa: sja1105: use list_add_tail(pos) instead of list_add(pos->prev) Content-Language: en-US To: Jakob Koschel , "David S. Miller" Cc: Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Edward Cree , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Casper Andersson , Bjarni Jonasson , Christophe JAILLET , Arnd Bergmann , Colin Ian King , Eric Dumazet , Xu Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, bpf@vger.kernel.org, Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." , Vladimir Oltean References: <20220415122947.2754662-1-jakobkoschel@gmail.com> <20220415122947.2754662-5-jakobkoschel@gmail.com> From: Florian Fainelli In-Reply-To: <20220415122947.2754662-5-jakobkoschel@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220416_123903_286503_467100C7 X-CRM114-Status: UNSURE ( 8.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/15/2022 5:29 AM, Jakob Koschel wrote: > From: Vladimir Oltean > > When passed a non-head list element, list_add_tail() actually adds the > new element to its left, which is what we want. Despite the slightly > confusing name, use the dedicated function which does the same thing as > the open-coded list_add(pos->prev). > > Suggested-by: Jakub Kicinski > Signed-off-by: Vladimir Oltean > Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel